✗ Fi.CI.CHECKPATCH: warning for pmu changes with igt (rev2)

Patchwork
2024-10-29T21:48:29Z

State : warning

== Summary ==

Error: dim checkpatch failed
78b9c1eafb55 pmu changes
-:7: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#7:
git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git perf/pmu-unregister

-:37: WARNING:TABSTOP: Statements should start on a tabstop
#37: FILE: include/linux/idr.h:137:
+ if (_T.id >= 0) idr_remove(_T.idr, _T.id),

-:37: ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#37: FILE: include/linux/idr.h:137:
+ if (_T.id >= 0) idr_remove(_T.idr, _T.id),

-:39: ERROR:CODE_INDENT: code indent should use tabs where possible
#39: FILE: include/linux/idr.h:139:
+^I ^I.idr = idr,$

-:39: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#39: FILE: include/linux/idr.h:139:
+^I ^I.idr = idr,$

-:55: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#55: FILE: include/linux/perf_event.h:321:
+ spinlock_t events_lock;

-:138: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#138: FILE: include/linux/perf_event.h:1113:
+extern int perf_pmu_unregister(struct pmu *pmu);

-:168: WARNING:LINE_SPACING: Missing a blank line after declarations
#168: FILE: kernel/events/core.c:1196:
+ int *count = &(*this_cpu_ptr(pmu->cpu_pmu_context))->pmu_disable_count;
+ WARN_ON_ONCE(*count == 0);

-:502: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#502: FILE: kernel/events/core.c:5403:
+DEFINE_FREE(__free_event, struct perf_event *, if (_T) __free_event(_T))
[...]
+static void _free_event(struct perf_event *event)

-:542: WARNING:BRACES: braces {} are not necessary for any arm of this statement
#542: FILE: kernel/events/core.c:5548:
+ if (event->state > PERF_EVENT_STATE_REVOKED) {
[...]
+ } else {
[...]

-:543: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#543: FILE: kernel/events/core.c:5549:
+ perf_remove_from_context(event, DETACH_GROUP|DETACH_DEAD);
^

-:768: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#768: FILE: kernel/events/core.c:11868:
+DEFINE_FREE(pmu_unregister, struct pmu *, if (_T) perf_pmu_free(_T))
[...]
+int perf_pmu_register(struct pmu *_pmu, const char *name, int type)

-:1143: ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#1143: FILE: kernel/events/core.c:12497:
+ return (void*)pmu;

total: 3 errors, 7 warnings, 3 checks, 1214 lines checked