From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51646D10F30 for ; Sun, 17 Nov 2024 21:19:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AACA010E31F; Sun, 17 Nov 2024 21:19:44 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="i1ESlBtd"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 65B8510E31F; Sun, 17 Nov 2024 21:19:43 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C67007CA; Sun, 17 Nov 2024 22:19:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1731878366; bh=LCxOYDveABxYci6xcGPLQzoY5X2ur4NiEvJHNv8MSqc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i1ESlBtdKSP8T3VJsiyviRYpYYbIEmbGaQmDPwC+LZ2O7kjbwJns8m16yNh8iQgt0 tJWzm+lcCtnLT6dw2MHxLrrP3j4E4ME5dwLNZw/bOqw3GIPpRMke3fcNRpRBPuYmsh pEOpUxNtWT/SrQqwxbZe8h+iAv0MPMGJe6JswldA= Date: Sun, 17 Nov 2024 23:19:33 +0200 From: Laurent Pinchart To: Dmitry Baryshkov Cc: Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Karol Herbst , Lyude Paul , Danilo Krummrich , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?utf-8?B?S8O2bmln?= , Xinhui Pan , Alain Volmat , Raphael Gallais-Pou , Liviu Dudau , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Peter Senna Tschudin , Ian Ray , Martyn Welch , Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar , Stefan Agner , Alison Wang , Patrik Jakobsson , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , Dave Airlie , Gerd Hoffmann , Sandy Huang , Heiko =?utf-8?Q?St=C3=BCbner?= , Andy Yan , Chen-Yu Tsai , Samuel Holland , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Dave Stevenson , =?utf-8?B?TWHDrXJh?= Canal , Raspberry Pi Kernel Maintenance , Gurchetan Singh , Chia-I Wu , Zack Rusin , Broadcom internal kernel review list , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, imx@lists.linux.dev, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, virtualization@lists.linux.dev, spice-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org Subject: Re: [PATCH 3/5] drm/sti: hda: pass const struct drm_display_mode* to hda_get_mode_idx() Message-ID: <20241117211933.GG12409@pendragon.ideasonboard.com> References: <20241115-drm-connector-mode-valid-const-v1-0-b1b523156f71@linaro.org> <20241115-drm-connector-mode-valid-const-v1-3-b1b523156f71@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20241115-drm-connector-mode-valid-const-v1-3-b1b523156f71@linaro.org> X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Dmitry, Thank you for the patch. On Fri, Nov 15, 2024 at 11:09:28PM +0200, Dmitry Baryshkov wrote: > Make hda_get_mode_idx() accept const struct drm_display_mode pointer > instead of just raw struct drm_display_mode. This is a preparation to > converting the mode_valid() callback of drm_connector to accept const > struct drm_display_mode argument. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/sti/sti_hda.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/sti/sti_hda.c b/drivers/gpu/drm/sti/sti_hda.c > index f18faad974aa2eda58c1e49537f8337db119d4b7..829dc4b034e8a79a908bda60485c2b94ef96890c 100644 > --- a/drivers/gpu/drm/sti/sti_hda.c > +++ b/drivers/gpu/drm/sti/sti_hda.c > @@ -280,12 +280,12 @@ static void hda_write(struct sti_hda *hda, u32 val, int offset) > * > * Return true if mode is found > */ > -static bool hda_get_mode_idx(struct drm_display_mode mode, int *idx) > +static bool hda_get_mode_idx(const struct drm_display_mode *mode, int *idx) > { > unsigned int i; > > for (i = 0; i < ARRAY_SIZE(hda_supported_modes); i++) > - if (drm_mode_equal(&hda_supported_modes[i].mode, &mode)) { > + if (drm_mode_equal(&hda_supported_modes[i].mode, mode)) { > *idx = i; > return true; > } > @@ -443,7 +443,7 @@ static void sti_hda_pre_enable(struct drm_bridge *bridge) > if (clk_prepare_enable(hda->clk_hddac)) > DRM_ERROR("Failed to prepare/enable hda_hddac clk\n"); > > - if (!hda_get_mode_idx(hda->mode, &mode_idx)) { > + if (!hda_get_mode_idx(&hda->mode, &mode_idx)) { > DRM_ERROR("Undefined mode\n"); > return; > } > @@ -526,7 +526,7 @@ static void sti_hda_set_mode(struct drm_bridge *bridge, > > drm_mode_copy(&hda->mode, mode); > > - if (!hda_get_mode_idx(hda->mode, &mode_idx)) { > + if (!hda_get_mode_idx(&hda->mode, &mode_idx)) { > DRM_ERROR("Undefined mode\n"); > return; > } > @@ -614,7 +614,7 @@ sti_hda_connector_mode_valid(struct drm_connector *connector, > = to_sti_hda_connector(connector); > struct sti_hda *hda = hda_connector->hda; > > - if (!hda_get_mode_idx(*mode, &idx)) { > + if (!hda_get_mode_idx(mode, &idx)) { > return MODE_BAD; > } else { > result = clk_round_rate(hda->clk_pix, target); > -- Regards, Laurent Pinchart