From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9D0DC3ABAA for ; Fri, 2 May 2025 12:52:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4730710E087; Fri, 2 May 2025 12:52:19 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=amazon.com header.i=@amazon.com header.b="O8I/BDPc"; dkim-atps=neutral Received: from smtp-fw-6002.amazon.com (smtp-fw-6002.amazon.com [52.95.49.90]) by gabe.freedesktop.org (Postfix) with ESMTPS id 56F0D10E19A; Thu, 1 May 2025 03:19:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1746069563; x=1777605563; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0jfy50eL43x6RabkD0VNeUvZqkKb2RUgwxKYds+fE2o=; b=O8I/BDPcJzOHE5cR+khuNEUVuZ/xYvo52rJ7TIYc0uNzGwcb1KWHbxKF e8F4ua8YcboHzPT860LzGluuyZidQhtWEEyDVlaDol7EqQW+VGhsGe0CO niiJ5LLxbTy6kYTo4dOtbAXgJhUJJkR2s9Ik8Y6iR14hB1CEEClz3fTkI Y=; X-IronPort-AV: E=Sophos;i="6.15,253,1739836800"; d="scan'208";a="494284256" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO smtpout.prod.us-west-2.prod.farcaster.email.amazon.dev) ([10.43.8.6]) by smtp-border-fw-6002.iad6.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 May 2025 03:19:15 +0000 Received: from EX19MTAUWA002.ant.amazon.com [10.0.21.151:56266] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.38.92:2525] with esmtp (Farcaster) id 6a9c4c01-a4bf-4386-a275-e61fc1e6a511; Thu, 1 May 2025 03:19:13 +0000 (UTC) X-Farcaster-Flow-ID: 6a9c4c01-a4bf-4386-a275-e61fc1e6a511 Received: from EX19D004ANA001.ant.amazon.com (10.37.240.138) by EX19MTAUWA002.ant.amazon.com (10.250.64.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1544.14; Thu, 1 May 2025 03:19:13 +0000 Received: from 6c7e67bfbae3.amazon.com (10.187.171.60) by EX19D004ANA001.ant.amazon.com (10.37.240.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1544.14; Thu, 1 May 2025 03:19:08 +0000 From: Kuniyuki Iwashima To: CC: , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v6 08/10] net: add symlinks to ref_tracker_dir for netns Date: Wed, 30 Apr 2025 20:07:56 -0700 Message-ID: <20250501031900.71399-1-kuniyu@amazon.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.187.171.60] X-ClientProxiedBy: EX19D040UWB004.ant.amazon.com (10.13.138.91) To EX19D004ANA001.ant.amazon.com (10.37.240.138) X-Mailman-Approved-At: Fri, 02 May 2025 12:52:18 +0000 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" From: Jeff Layton Date: Wed, 30 Apr 2025 19:59:23 -0700 > On Wed, 2025-04-30 at 14:29 -0700, Kuniyuki Iwashima wrote: > > From: Jeff Layton > > Date: Wed, 30 Apr 2025 08:06:54 -0700 > > > After assigning the inode number to the namespace, use it to create a > > > unique name for each netns refcount tracker with the ns.inum value in > > > it, and register a symlink to the debugfs file for it. > > > > > > init_net is registered before the ref_tracker dir is created, so add a > > > late_initcall() to register its files and symlinks. > > > > > > Signed-off-by: Jeff Layton > > > --- > > > net/core/net_namespace.c | 28 +++++++++++++++++++++++++++- > > > 1 file changed, 27 insertions(+), 1 deletion(-) > > > > > > diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c > > > index 008de9675ea98fa8c18628b2f1c3aee7f3ebc9c6..6cbc8eabb8e56c847fc34fa8ec9994e8b275b0af 100644 > > > --- a/net/core/net_namespace.c > > > +++ b/net/core/net_namespace.c > > > @@ -763,12 +763,38 @@ struct net *get_net_ns_by_pid(pid_t pid) > > > } > > > EXPORT_SYMBOL_GPL(get_net_ns_by_pid); > > > > > > +#ifdef CONFIG_NET_NS_REFCNT_TRACKER > > > +static void net_ns_net_debugfs(struct net *net) > > > +{ > > > + ref_tracker_dir_symlink(&net->refcnt_tracker, "netns-%u-refcnt", net->ns.inum); > > > + ref_tracker_dir_symlink(&net->notrefcnt_tracker, "netns-%u-notrefcnt", net->ns.inum); > > > > Could you use net->net_cookie ? > > > > net->ns.inum is always 1 when CONFIG_PROC_FS=n. > > My main use-case for this is to be able to match the inode number in > the /proc//ns/net symlink with the correct ref_tracker debugfs > file. Is there a way to use the net_cookie to make that association? It's roundabout, but net_cookie can be retrieved by creating a random socket in the netns and calling setsockopt(SO_NETNS_COOKIE). Ido proposed a handy ip-netns subcommand here, and I guess it will be implemented soon(?) https://lore.kernel.org/netdev/1d99d7ccfc3a7a18840948ab6ba1c0b5fad90901.camel@fejes.dev/ > > If there isn't, and ns.inum is always 1 with procfs is disabled, we > could just skip adding the symlink when CONFIG_PROC_FS=n.