From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DE17C3ABAC for ; Tue, 6 May 2025 14:57:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EE62B10E6CF; Tue, 6 May 2025 14:57:31 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="PdFnN5nW"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id E382410E6CF; Tue, 6 May 2025 14:57:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746543451; x=1778079451; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=PnqG5aCmZVnbtzeDgnCI36u8tn+GfMdDLfSAe7AHHkU=; b=PdFnN5nWqcwFB223owjLgbSiZKuG1wyZQeUN0MtCodssGC9LDZzgEoxB 3l2imbceBiKZp9HMDZj+QJvumqwerZMNMsw9h1HhHZYyTejvySkP1uvQs TVJmRhew3ZtK1pZmyETQY2aBJgYjUcz3YwNn7PHthZo7e4p3nNvjCXuo0 wOwWVLiOv959ycqrByXu/A+MK5yfiObNNKIXeTWXEwqVGH4p7WA9BpQ9r MuGI99SxgjwJzJ9pOP+Jyj1+JDRq1zXoi0zz51EKDB4vtvSCZP+/B/dW8 rygklG09/bCjtcCDIZm3PX02snPiBeAwjr18Rs+rSwT/GxrooJDNvaWul w==; X-CSE-ConnectionGUID: 2901fWl7SaGoX7UScYp0dg== X-CSE-MsgGUID: KIIvGEaTSry61FJjS6WD9A== X-IronPort-AV: E=McAfee;i="6700,10204,11425"; a="59206053" X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="59206053" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2025 07:57:31 -0700 X-CSE-ConnectionGUID: xdDM7x0mQpqfmjVqlI4zDA== X-CSE-MsgGUID: 1a/f0ArlR9Gtim8M8OqkZA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,266,1739865600"; d="scan'208";a="166572193" Received: from mgolanimitul-x299-ud4-pro.iind.intel.com ([10.190.239.114]) by orviesa002.jf.intel.com with ESMTP; 06 May 2025 07:57:29 -0700 From: Mitul Golani To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Cc: ankit.k.nautiyal@intel.com, ville.syrjala@intel.com Subject: [PATCH v4 09/17] drm/i915/vrr: Add compute config for DC Balance params Date: Tue, 6 May 2025 20:25:09 +0530 Message-ID: <20250506145517.4129419-10-mitulkumar.ajitkumar.golani@intel.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250506145517.4129419-1-mitulkumar.ajitkumar.golani@intel.com> References: <20250506145517.4129419-1-mitulkumar.ajitkumar.golani@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Compute DC Balance parameters and tunable params based on experiments. --v2: - Document tunable params. (Ankit) --v3: - Add line spaces to compute config. (Ankit) - Remove redundancy checks. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_vrr.c | 25 ++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c index 726fa49558d1..dcaae7631b0a 100644 --- a/drivers/gpu/drm/i915/display/intel_vrr.c +++ b/drivers/gpu/drm/i915/display/intel_vrr.c @@ -16,6 +16,13 @@ #define FIXED_POINT_PRECISION 100 #define CMRR_PRECISION_TOLERANCE 10 +/* + * Tunable parameters for DC Balance correction. + * These are captured based on experimentations. + */ +#define DCB_CORRECTION_SENSITIVITY 30 +#define DCB_CORRECTION_AGGRESSIVENESS 1000 +#define DCB_BLANK_TARGET 50 bool intel_vrr_is_capable(struct intel_connector *connector) { @@ -409,6 +416,24 @@ intel_vrr_compute_config(struct intel_crtc_state *crtc_state, (crtc_state->hw.adjusted_mode.crtc_vtotal - crtc_state->hw.adjusted_mode.vsync_end); } + + if (crtc_state->vrr.dc_balance.enable) { + crtc_state->vrr.dc_balance.vmax = crtc_state->vrr.vmax; + crtc_state->vrr.dc_balance.vmin = crtc_state->vrr.vmin; + crtc_state->vrr.dc_balance.max_increase = + crtc_state->vrr.vmax - crtc_state->vrr.vmin; + crtc_state->vrr.dc_balance.max_decrease = + crtc_state->vrr.vmax - crtc_state->vrr.vmin; + crtc_state->vrr.dc_balance.guardband = + DIV_ROUND_UP(crtc_state->vrr.dc_balance.vmax * + DCB_CORRECTION_SENSITIVITY, 100); + crtc_state->vrr.dc_balance.slope = + DIV_ROUND_UP(DCB_CORRECTION_AGGRESSIVENESS * 10, + crtc_state->vrr.dc_balance.guardband); + crtc_state->vrr.dc_balance.vblank_target = + DIV_ROUND_UP((crtc_state->vrr.vmax - crtc_state->vrr.vmin) * + DCB_BLANK_TARGET, 100); + } } void intel_vrr_compute_config_late(struct intel_crtc_state *crtc_state) -- 2.48.1