From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92653C3ABD4 for ; Mon, 12 May 2025 12:34:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2B92D10E3D7; Mon, 12 May 2025 12:34:36 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="EiqSqx7B"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6726F10E3D5 for ; Mon, 12 May 2025 12:34:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747053271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AsNfuXk++hQsXcSMH0/ZpoD/Dq28xwSeg936k+p2z/0=; b=EiqSqx7BvCevIQt6Dyf+XfBRUFGfMYLa6xlrlpJMx+Ny03URQBAgF1Pk2R8LF/hU/XGcdk MwptCJAbHV5mdq8Zg8izMk3nlEBD2Lh7X7YXTY1QRXrZ573i8UchXvLTCPAeJPPp3Pq6om t4ln7b7fUHpBRinhDTVkzxXoqPV40XM= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-269-nJ76JH8KM9i0zwYsCN0Nsg-1; Mon, 12 May 2025 08:34:28 -0400 X-MC-Unique: nJ76JH8KM9i0zwYsCN0Nsg-1 X-Mimecast-MFC-AGG-ID: nJ76JH8KM9i0zwYsCN0Nsg_1747053267 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a205227595so449961f8f.3 for ; Mon, 12 May 2025 05:34:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747053267; x=1747658067; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AsNfuXk++hQsXcSMH0/ZpoD/Dq28xwSeg936k+p2z/0=; b=hM1z3e46OIg4jl5ePp75TUzoflnlkSUFB5ZdSoEg5UIbzlMIlpt7q9eS9D47EvXFQQ zM05tmA4JGpdYSy5i9XS1IovS6d5d6bZ3/3V9AjVxALzczkwdCbGUIpR3yN3aYktXHpw Mm2mFhzInJ6L6YtLM0ru2SiFol59BjeN2f1BY/SLReC5tOVR5g7uiZCEH77YMcXza2vq RXbmVlBWtgyGi3ue8RJpLDIFdp0fC1+0ZD+/HGXORndBvnZLunkzt7G6lfO32qzamLk5 llBrGoOQvMqceoEnzWX8Qd9HNJ3iyTb73cyPHpZvwTJ1qwIKwcfxHfjjO/h/iZvrb5W3 cM8w== X-Forwarded-Encrypted: i=1; AJvYcCXfz0VY0juU0FLEIR9W+9KD8q7y83UmRx1Sc7yGJVZc13r8zfmqYzWAdT9TNSH8rogRAKylgZH6lLo=@lists.freedesktop.org X-Gm-Message-State: AOJu0YzEkU1JzfbAjc/LzosW9W4U0lwuqCcKt1IDqwuwYgo5JHgC5kVD zmUHYxUh83f6HcO7dUbMpx8u74F6cbYQwwOvo+oVtwTGZ3RhK6toTXQWlKjtIXS0vBrb51Pv1h2 da4rUGIEvECdHHeTgVYlZ1I51enWk6iSYTzN/9FMWwfq0WYDhx1/AVCqiYeH0m+1VvQ== X-Gm-Gg: ASbGncv1Qk/9QUvAZEXbQaMNWaYAOW8kIVchBu9DPfTlFSzvlCtHYP2TjgBvLdbjfys MmP+sZUBHlk+2OnJB1T0YlcuDUT9CNsbmu69VubVZMF5Y8MC8Vg+5p46z7OpL2jx+iNiM22Qrdd lO994gWSwpkw03X4Ejgn70zBJNGorDtx/49KwfeKOR7uf+8s0FVFZ1JUtSyAZQz8wQPSoTi3dV6 COvspHP0EkRB6VaTZqIL3ljMw8kYx22QNip0gdWY2tAwfSrdGYK7bdZVJhSHWvh6MhL0Dz7iyls 1co/98dZGy6bb4pb7NGzMhUHO2L7j6XUSPblWfYM4cdgdodN/CJ/M1w1rFEzfzaPTtw6rs0Q X-Received: by 2002:a05:6000:1a8a:b0:3a2:6bc:3f25 with SMTP id ffacd0b85a97d-3a206bc6568mr3282302f8f.36.1747053267151; Mon, 12 May 2025 05:34:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEbVOvWh8aR7BY5sT0iHvCaoLmEQsNhObrlGdsawBm2VmjmvFE+wMDlxjPW6z9Q2DtavCs6CQ== X-Received: by 2002:a05:6000:1a8a:b0:3a2:6bc:3f25 with SMTP id ffacd0b85a97d-3a206bc6568mr3282274f8f.36.1747053266780; Mon, 12 May 2025 05:34:26 -0700 (PDT) Received: from localhost (p200300d82f4a5800f1ae8e20d7f451b0.dip0.t-ipconnect.de. [2003:d8:2f4a:5800:f1ae:8e20:d7f4:51b0]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a1f5a4c583sm12119696f8f.84.2025.05.12.05.34.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 May 2025 05:34:26 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, x86@kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-trace-kernel@vger.kernel.org, David Hildenbrand , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pedro Falcato , Peter Xu Subject: [PATCH v2 00/11] mm: rewrite pfnmap tracking and remove VM_PAT Date: Mon, 12 May 2025 14:34:13 +0200 Message-ID: <20250512123424.637989-1-david@redhat.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: UONw3uvxk3cxtfKmWTyWyj21sSEmQ7hFmdaklvq7vp0_1747053267 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On top of mm-unstable. VM_PAT annoyed me too much and wasted too much of my time, let's clean PAT handling up and remove VM_PAT. This should sort out various issues with VM_PAT we discovered recently, and will hopefully make the whole code more stable and easier to maintain. In essence: we stop letting PAT mode mess with VMAs and instead lift what to track/untrack to the MM core. We remember per VMA which pfn range we tracked in a new struct we attach to a VMA (we have space without exceeding 192 bytes), use a kref to share it among VMAs during split/mremap/fork, and automatically untrack once the kref drops to 0. This implies that we'll keep tracking a full pfn range even after partially unmapping it, until fully unmapping it; but as that case was mostly broken before, this at least makes it work in a way that is least intrusive to VMA handling. Shrinking with mremap() used to work in a hacky way, now we'll similarly keep the original pfn range tacked even after this form of partial unmap. Does anybody care about that? Unlikely. If we run into issues, we could likely handled that (adjust the tracking) when our kref drops to 1 while freeing a VMA. But it adds more complexity, so avoid that for now. Briefly tested with the new pfnmap selftests [1]. [1] https://lkml.kernel.org/r/20250509153033.952746-1-david@redhat.com Cc: Dave Hansen Cc: Andy Lutomirski Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: "H. Peter Anvin" Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Simona Vetter Cc: Andrew Morton Cc: Steven Rostedt Cc: Masami Hiramatsu Cc: Mathieu Desnoyers Cc: "Liam R. Howlett" Cc: Lorenzo Stoakes Cc: Vlastimil Babka Cc: Jann Horn Cc: Pedro Falcato Cc: Peter Xu v1 -> v2: * "mm: convert track_pfn_insert() to pfnmap_setup_cachemode*()" -> Call it "pfnmap_setup_cachemode()" and improve the documentation -> Add pfnmap_setup_cachemode_pfn() -> Keep checking a single PFN for PMD/PUD case and document why it's ok * Merged memremap conversion patch with pfnmap_track() introduction patch -> Improve documentation * "mm: convert VM_PFNMAP tracking to pfnmap_track() + pfnmap_untrack()" -> Adjust to code changes in mm-unstable * Added "x86/mm/pat: inline memtype_match() into memtype_erase()" * "mm/io-mapping: track_pfn() -> "pfnmap tracking"" -> Adjust to code changes in mm-unstable David Hildenbrand (11): x86/mm/pat: factor out setting cachemode into pgprot_set_cachemode() mm: convert track_pfn_insert() to pfnmap_setup_cachemode*() mm: introduce pfnmap_track() and pfnmap_untrack() and use them for memremap mm: convert VM_PFNMAP tracking to pfnmap_track() + pfnmap_untrack() x86/mm/pat: remove old pfnmap tracking interface mm: remove VM_PAT x86/mm/pat: remove strict_prot parameter from reserve_pfn_range() x86/mm/pat: remove MEMTYPE_*_MATCH x86/mm/pat: inline memtype_match() into memtype_erase() drm/i915: track_pfn() -> "pfnmap tracking" mm/io-mapping: track_pfn() -> "pfnmap tracking" arch/x86/mm/pat/memtype.c | 194 ++++------------------------- arch/x86/mm/pat/memtype_interval.c | 63 ++-------- drivers/gpu/drm/i915/i915_mm.c | 4 +- include/linux/mm.h | 4 +- include/linux/mm_inline.h | 2 + include/linux/mm_types.h | 11 ++ include/linux/pgtable.h | 127 ++++++++++--------- include/trace/events/mmflags.h | 4 +- mm/huge_memory.c | 5 +- mm/io-mapping.c | 2 +- mm/memory.c | 86 ++++++++++--- mm/memremap.c | 8 +- mm/mmap.c | 5 - mm/mremap.c | 4 - mm/vma_init.c | 50 ++++++++ 15 files changed, 242 insertions(+), 327 deletions(-) base-commit: c68cfbc5048ede4b10a1d3fe16f7f6192fc2c9c8 -- 2.49.0