From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EA48C83F0F for ; Mon, 7 Jul 2025 13:00:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0FA0A10E474; Mon, 7 Jul 2025 13:00:01 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=tuxedocomputers.com header.i=@tuxedocomputers.com header.b="PR+2xoaQ"; dkim-atps=neutral Received: from mail.tuxedocomputers.com (mail.tuxedocomputers.com [157.90.84.7]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0613A10EA67; Fri, 4 Jul 2025 19:20:26 +0000 (UTC) Received: from wse-pc.fritz.box (pd9e59880.dip0.t-ipconnect.de [217.229.152.128]) (Authenticated sender: wse@tuxedocomputers.com) by mail.tuxedocomputers.com (Postfix) with ESMTPA id 3E54F2FC00A3; Fri, 4 Jul 2025 21:20:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxedocomputers.com; s=default; t=1751656824; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7FI4wcSRyziI8xdf6I8dg5gPLqWgZXWsbhhOo4O2J6c=; b=PR+2xoaQw7M1ghb2QA3aJ/RFQbhx8sN242qKExuCiPyvbVyELiEVSwI9pFrLObTm7pvCgo VR8m4h0I4Q2lso6Q3ncq1N7z5TuV7BgPWUR8VDFgZMj7pPqPLO5fhTUoP7Gg81vXputRxz UuFagD0xRAQaiM/HFL5yoDthgEpr2h4= Authentication-Results: mail.tuxedocomputers.com; auth=pass smtp.auth=wse@tuxedocomputers.com smtp.mailfrom=wse@tuxedocomputers.com From: Werner Sembach To: Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , David Airlie , Simona Vetter Cc: Tim Guttzeit , Werner Sembach , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH 1/1] drm/i915/display: Avoid unsupported 300Hz output mode on a TUXEDO device Date: Fri, 4 Jul 2025 21:03:46 +0200 Message-ID: <20250704192007.526044-2-wse@tuxedocomputers.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250704192007.526044-1-wse@tuxedocomputers.com> References: <20250704192007.526044-1-wse@tuxedocomputers.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Mon, 07 Jul 2025 12:59:55 +0000 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" From: Tim Guttzeit Removes all display modes with more than 240 Hz for the integrated display on a TUXEDO Stellaris 16 Gen7, because using the iGPU with higer refresh rates causes screen flicker. Signed-off-by: Tim Guttzeit Co-developed-by: Werner Sembach Signed-off-by: Werner Sembach --- drivers/gpu/drm/i915/display/intel_dp.c | 5 ++++ drivers/gpu/drm/i915/display/intel_quirks.c | 30 +++++++++++++++++++++ drivers/gpu/drm/i915/display/intel_quirks.h | 1 + 3 files changed, 36 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 640c43bf62d4c..5ce00cfe36ee1 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -1436,6 +1436,11 @@ intel_dp_mode_valid(struct drm_connector *_connector, if (mode->clock < 10000) return MODE_CLOCK_LOW; + if (intel_has_quirk(display, QUIRK_EDP_MAX_240HZ_HOOK) && + intel_dp_is_edp(intel_dp) && + drm_mode_vrefresh(mode) > 240) + return MODE_BAD; + fixed_mode = intel_panel_fixed_mode(connector, mode); if (intel_dp_is_edp(intel_dp) && fixed_mode) { status = intel_panel_mode_valid(connector, mode); diff --git a/drivers/gpu/drm/i915/display/intel_quirks.c b/drivers/gpu/drm/i915/display/intel_quirks.c index a32fae510ed27..438ce2cb37a01 100644 --- a/drivers/gpu/drm/i915/display/intel_quirks.c +++ b/drivers/gpu/drm/i915/display/intel_quirks.c @@ -72,6 +72,12 @@ static void quirk_no_pps_backlight_power_hook(struct intel_display *display) drm_info(display->drm, "Applying no pps backlight power quirk\n"); } +static void quirk_edp_max_240hz_hook(struct intel_display *display) +{ + intel_set_quirk(display, QUIRK_EDP_MAX_240HZ_HOOK); + drm_info(display->drm, "Applying max 240Hz quirk\n"); +} + static void quirk_fw_sync_len(struct intel_dp *intel_dp) { struct intel_display *display = to_intel_display(intel_dp); @@ -120,6 +126,12 @@ static int intel_dmi_no_pps_backlight(const struct dmi_system_id *id) return 1; } +static int intel_dmi_edp_max_240hz(const struct dmi_system_id *id) +{ + DRM_INFO("Restrict output refreshrate to maximum 240Hz %s\n", id->ident); + return 1; +} + static const struct intel_dmi_quirk intel_dmi_quirks[] = { { .dmi_id_list = &(const struct dmi_system_id[]) { @@ -166,6 +178,24 @@ static const struct intel_dmi_quirk intel_dmi_quirks[] = { }, .hook = quirk_no_pps_backlight_power_hook, }, + { + .dmi_id_list = &(const struct dmi_system_id[]) { + { + .callback = intel_dmi_edp_max_240hz, + .ident = "TUXEDO Stellaris 16 Intel Gen7", + .matches = {DMI_EXACT_MATCH(DMI_BOARD_NAME, "X6AR5xxY"), + }, + }, + { + .callback = intel_dmi_edp_max_240hz, + .ident = "TUXEDO Stellaris 16 Intel Gen7", + .matches = {DMI_EXACT_MATCH(DMI_BOARD_NAME, "X6AR5xxY_mLED"), + }, + }, + { } + }, + .hook = quirk_edp_max_240hz_hook, + }, }; static struct intel_quirk intel_quirks[] = { diff --git a/drivers/gpu/drm/i915/display/intel_quirks.h b/drivers/gpu/drm/i915/display/intel_quirks.h index cafdebda75354..8fe3f3467106a 100644 --- a/drivers/gpu/drm/i915/display/intel_quirks.h +++ b/drivers/gpu/drm/i915/display/intel_quirks.h @@ -20,6 +20,7 @@ enum intel_quirk_id { QUIRK_LVDS_SSC_DISABLE, QUIRK_NO_PPS_BACKLIGHT_POWER_HOOK, QUIRK_FW_SYNC_LEN, + QUIRK_EDP_MAX_240HZ_HOOK, }; void intel_init_quirks(struct intel_display *display); -- 2.43.0