From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B645CA0FE4 for ; Thu, 21 Aug 2025 20:07:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D0A6810E9D2; Thu, 21 Aug 2025 20:07:32 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="W9dd/Bj/"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id AC79010E9D7 for ; Thu, 21 Aug 2025 20:07:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755806849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A9Znt0atqEjtEUkbTSfKRsvBJ9rEcbnqI7Kn1XkJSrA=; b=W9dd/Bj/wbbTcXkSwqfISdP029wUxlVJLeThAn8+QdYJqZd87yyVZl3OdO7Mi4EdNvVPDJ pe90WwlD86bh/Ty+q1TRGr8yQUO8kIPMV4SuEiJwChATrpJzcNKP6r+80WZBChvOYLZg7N G7IvhtChARwoWTvY8ahgFrJnjlyYRhs= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-206-hFPGkY5jPuWaj0jnFeSC5w-1; Thu, 21 Aug 2025 16:07:28 -0400 X-MC-Unique: hFPGkY5jPuWaj0jnFeSC5w-1 X-Mimecast-MFC-AGG-ID: hFPGkY5jPuWaj0jnFeSC5w_1755806847 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-45b4d6f3ab0so8376875e9.0 for ; Thu, 21 Aug 2025 13:07:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755806847; x=1756411647; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A9Znt0atqEjtEUkbTSfKRsvBJ9rEcbnqI7Kn1XkJSrA=; b=qhMco+IrQxSMhIresJtrlVXhKYvPB8x/2pMY83OFe+00cPtf6jj+BHx95j90gEzg/k WFKxWXpi1fnZJ/HvUm+qhmA9KfmaPmWhHhSJWSS6ALPtq4So6mfZ6U8AfV25qj583HSH SWXmyxP5EYtpQKfGwBTKb8nfXtoTXkR4nJMgZ1+NakgLkfUBcWs74DXLgGCy30HfNDbP J0P6E+QgNuajgADOixkJUNjHxm26uElteWvm3rD1JHp8+CClwCCpJpk4O2g3XQ4Ytz5U xejz4TfnKpl4GAVzBgBA+IDOTeI+HQvt5e2VKQbROVnY5LssgCByWsY4ZtIKIbdlm+Tb F5Jw== X-Forwarded-Encrypted: i=1; AJvYcCWMlMEZHEn/d96U7rm/qMjzdq7RM5qKQ9+ohy1UU9uusByNaHa4MovUvl7SJ8eq5Y3AeoX++1iS2b0=@lists.freedesktop.org X-Gm-Message-State: AOJu0YzQRdbkgJ0ZVi2cu561dWCKpGvqHXIAR/aqb+bUc5dUGWz5rnZN 35+wZ5o5z50fhWQl2MZLwBG6bp84demIYGfznoPQ3tQv0WeES6+c3lfdQiwCulIBXCfbxoERqqI UZvAQJza044nUqQ3SrznjEZAkm4KNIbyG3lhQZN8h+8tHlliSH8ygmaw0heN0mcZBGwowxA== X-Gm-Gg: ASbGncsc+JoJCruZ5VL438ywZyCVaObgDS/ZNM6WdufZqfWYjyDqaU1xhFZB78/oB1f cpCV3OHpmHplUQWb2PMTrLfhbNA4ejg72U1p7OghsOHwwnNX6d7F4HhQzgxx4bpsyVPDbRud92P Tt3R97rR3/apmWW7Gv9fM1XHBMzrKFdkD+cF+inyr95TjdmHalfLwSm8aMId1aP3bJjYFt9qRjV PBxi/7Ry1JtKBfS8gXyujCsfQYbDEy89X5bAV/imOKrFnuS2Pi0x0nrLoT8Y7YN1IVtlywMp+Zr YEAd2h8OagEiflb5/5/7h+JH32whSZBfn27sKwycWvGdV98jk2O1iEGtTBgtm8Ce+dpmFGOVEDk 989bdaRlsYC15DsscVCWT+A== X-Received: by 2002:a05:600c:3552:b0:459:dde3:1a33 with SMTP id 5b1f17b1804b1-45b517d26d4mr2922205e9.26.1755806847222; Thu, 21 Aug 2025 13:07:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGUeapMM5JkcwJNJXC+LM6ICHu4lGUEF2ir46AAuHXhYXAFzTcPIdec/q/lplZD/isU7mGEgg== X-Received: by 2002:a05:600c:3552:b0:459:dde3:1a33 with SMTP id 5b1f17b1804b1-45b517d26d4mr2921795e9.26.1755806846742; Thu, 21 Aug 2025 13:07:26 -0700 (PDT) Received: from localhost (p200300d82f26ba0008036ec5991806fd.dip0.t-ipconnect.de. [2003:d8:2f26:ba00:803:6ec5:9918:6fd]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-45b50d62991sm9535385e9.0.2025.08.21.13.07.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Aug 2025 13:07:26 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: David Hildenbrand , Alexander Potapenko , Andrew Morton , Brendan Jackman , Christoph Lameter , Dennis Zhou , Dmitry Vyukov , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, iommu@lists.linux.dev, io-uring@vger.kernel.org, Jason Gunthorpe , Jens Axboe , Johannes Weiner , John Hubbard , kasan-dev@googlegroups.com, kvm@vger.kernel.org, "Liam R. Howlett" , Linus Torvalds , linux-arm-kernel@axis.com, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-ide@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Lorenzo Stoakes , Marco Elver , Marek Szyprowski , Michal Hocko , Mike Rapoport , Muchun Song , netdev@vger.kernel.org, Oscar Salvador , Peter Xu , Robin Murphy , Suren Baghdasaryan , Tejun Heo , virtualization@lists.linux.dev, Vlastimil Babka , wireguard@lists.zx2c4.com, x86@kernel.org, Zi Yan Subject: [PATCH RFC 07/35] mm/memremap: reject unreasonable folio/compound page sizes in memremap_pages() Date: Thu, 21 Aug 2025 22:06:33 +0200 Message-ID: <20250821200701.1329277-8-david@redhat.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250821200701.1329277-1-david@redhat.com> References: <20250821200701.1329277-1-david@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: JX3zFxkCMcN8YEm26Z_4OYvH6SJioRJ7HIKaFkcFMFw_1755806847 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Let's reject unreasonable folio sizes early, where we can still fail. We'll add sanity checks to prepare_compound_head/prepare_compound_page next. Is there a way to configure a system such that unreasonable folio sizes would be possible? It would already be rather questionable. If so, we'd probably want to bail out earlier, where we can avoid a WARN and just report a proper error message that indicates where something went wrong such that we messed up. Signed-off-by: David Hildenbrand --- mm/memremap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/memremap.c b/mm/memremap.c index b0ce0d8254bd8..a2d4bb88f64b6 100644 --- a/mm/memremap.c +++ b/mm/memremap.c @@ -275,6 +275,9 @@ void *memremap_pages(struct dev_pagemap *pgmap, int nid) if (WARN_ONCE(!nr_range, "nr_range must be specified\n")) return ERR_PTR(-EINVAL); + if (WARN_ONCE(pgmap->vmemmap_shift > MAX_FOLIO_ORDER, + "requested folio size unsupported\n")) + return ERR_PTR(-EINVAL); switch (pgmap->type) { case MEMORY_DEVICE_PRIVATE: -- 2.50.1