From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB6D7CA1013 for ; Thu, 4 Sep 2025 16:27:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 44EEB10EAAC; Thu, 4 Sep 2025 16:27:52 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="IASTFfbe"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 07DFE10EA97; Thu, 4 Sep 2025 16:27:51 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id AB9C943605; Thu, 4 Sep 2025 16:27:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85A5EC4CEF0; Thu, 4 Sep 2025 16:27:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757003270; bh=P+wVfpodom1uA9pmTbOEoXVmpJnSH0vCG+IZWf3uVHc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IASTFfbeyei4PtKr8lAOptE2IvgxStUhs/N2PDRJTB980jj/baN9bi/M8fg1/gicM KodQ90/N1nwsj3dQIaIVB2Hh9oXwRcXCMi5OnWEQU/IHuq5f+sRBcRZEtNtxvJjCG6 XIthoG9yL0QB3fUTOBGldnKRUgdE44VdN32dJm9NQm4XLUsebl3UZYBu5oEilrpZua XDEZvkDwl9fK4uLPH5NdRRJbuAfd7rOpPHnWeXQ/R4sx45dEFrSpV4A+oaam9sEZhC yduDUbfipB1NFPy8vKF/wPtMuzsfjjJW8W6lnTlOrWZ/S2zX+T8OEOL7nFxZGAnzbh jV/J8CAT0rK+Q== Date: Thu, 4 Sep 2025 09:27:50 -0700 From: Kees Cook To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org Subject: Re: [PATCH 3/3] overflow: add range_overflows() and range_end_overflows() Message-ID: <202509040927.30BEE17@keescook> References: <20250829174601.2163064-1-jani.nikula@intel.com> <20250829174601.2163064-3-jani.nikula@intel.com> <202509031942.A1669D10F@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Sep 04, 2025 at 10:34:04AM +0300, Jani Nikula wrote: > On Wed, 03 Sep 2025, Kees Cook wrote: > > On Fri, Aug 29, 2025 at 08:46:01PM +0300, Jani Nikula wrote: > >> Move the range_overflows() and range_end_overflows() along with the _t > >> variants over from drm/i915 and drm/buddy to overflow.h. > >> > >> Cc: Kees Cook > >> Cc: Gustavo A. R. Silva > >> Cc: linux-hardening@vger.kernel.org > >> Signed-off-by: Jani Nikula > > > > Looks good to me! :) > > > > Reviewed-by: Kees Cook > > Cool, thanks! How do you want to handle merging this? Since it's touching drm, feel free to take it there. I'm not worried about conflict resolution in overflow.h. -- Kees Cook