From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9EB42CAC59E for ; Tue, 16 Sep 2025 14:55:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C34C010E7F0; Tue, 16 Sep 2025 14:55:20 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="buS1pCSa"; dkim-atps=neutral Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5678C10E63D for ; Tue, 16 Sep 2025 04:48:54 +0000 (UTC) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2570bf605b1so48699645ad.2 for ; Mon, 15 Sep 2025 21:48:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757998134; x=1758602934; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+E/nxXHnOkpnquuQqI/t3YoOv7z+zhY+r7/SIcSNR5s=; b=buS1pCSaQo4PUcwAw6b50HAZU1PjqZVL4XZgfyymK2/2GHjl21VqvZlDsBkTIzJbGW TEFQ7q1K31Eo4y6e60Obwy9o3jGoHenHxPk45kXTofw/aBJfPsAwYcFAneuxEmnvEMts 2nVkJGPD8kLjk9Z3HJeZz5pAqp/KXCng36k/v6E6w7MgP9jMjRpRyUPnG7KsyUTArQuZ dSR8hqgHevnsLH0Np0B0kc9obWAm+su/wVkJdwrWUXARD5IZdfyP/Ho6ZaBs6yFWh7Ik eMvA5vZ3/ZwHKc3NZXwr3EoWO4NwL05QU5YrR3M+juhlEDRKE+sbg7BYnApzU8JxjryO xWgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757998134; x=1758602934; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+E/nxXHnOkpnquuQqI/t3YoOv7z+zhY+r7/SIcSNR5s=; b=DhgfEesaaHJPe05gJyAuBhhshHZOCmIY3jWlAZRoA661/cDBIadcOhKK2xpU+yjzAZ UmiReOO64acOChzMwFiKZm5IhEHTP/R808icyhucw8I8wDlET44zWpPdKkNZl+Xifs1+ fLanZ+SL5RhzRbDOxKGZ7SPicP9EQOanG5hJNJVcWpQePo86t5eY+USnh/GdJDyUIT6v RbsyBbYkkTAyIj+x7jIzzK+gJPMFVDTFB8T7u/hzokDhfCP9E6HL6xegye/4n9tpkeTE fYqsj8rP1imXdVMuhBDpgFaugEtGPz/+tS/wnF68ssO15hPB3IRfrPnVISWDLnySfT7F zKyw== X-Forwarded-Encrypted: i=1; AJvYcCWv3I7RZpDvIcWbJOMK1XEUgV7+/xHH/aBuFCO+3aV2el8zL6oSkKhrH8zlK3eVApU9bxAKv7RK1KY=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yz9Fb1cFrSRSP7UjJyVmejk852Xf/vT9aE6OPwmx9IhxXdrsaBR CrcH8UabLWgraDI7E3wA6mOuKL5Zd5ia759lWe7uBzzHeAEnkCvJwn6u X-Gm-Gg: ASbGnctwAkxZfrpSCmGlmQqOlSaqA48++Dm8I4KMgHNAABZ8LuW86TjbaSXwN14NjV0 f3V4nVgf5R6pSEXeklSxN6dYGicoALOd0xwd7E4Bu0RdFrGNPa6Snj07jAXtFQvlSbGt4ajKOjM Nv9mY54GkAhORFLTnPqU5RVUetPAh5ajcxcxjiXbR7zUO9Oes+A5JR0hqLceZhwlSmDgflri4J4 ActsbYvZxCpcdYyJt/bDsqmbOwoFgnymch0h13JBl8a1aTcf5QN7ymmBDM+CtcDCHdS8hR/mj22 HtVjPpgy2N6VuCjo0/egCItovY2LO7rnE4mcsCR4sg2EGTPxEMfhPLhZvF5+MQDGiJqcZVFRYD5 sN9ZB1pnoOWvxStbQqCuk2Pbe23r36K/mK+7noYaw41k4GbeiRw== X-Google-Smtp-Source: AGHT+IHsN0GBYzT4MMuIYjW4jOX+BASz3i1Lsko5ULcFSIEXx1CyBAF2xoChVB4z7RicwE9rHAP4nQ== X-Received: by 2002:a17:902:db02:b0:267:b357:9445 with SMTP id d9443c01a7336-267b35796d4mr43637625ad.28.1757998133829; Mon, 15 Sep 2025 21:48:53 -0700 (PDT) Received: from pengdl-pc.mioffice.cn ([43.224.245.249]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-25ef09c77f8sm104600605ad.15.2025.09.15.21.48.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Sep 2025 21:48:53 -0700 (PDT) From: pengdonglin To: tj@kernel.org, tony.luck@intel.com, jani.nikula@linux.intel.com, ap420073@gmail.com, jv@jvosburgh.net, freude@linux.ibm.com, bcrl@kvack.org, trondmy@kernel.org, longman@redhat.com, kees@kernel.org Cc: bigeasy@linutronix.de, hdanton@sina.com, paulmck@kernel.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, linux-nfs@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-wireless@vger.kernel.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, cgroups@vger.kernel.org, pengdonglin , pengdonglin Subject: [PATCH v3 06/14] ipc: Remove redundant rcu_read_lock/unlock() in spin_lock Date: Tue, 16 Sep 2025 12:47:27 +0800 Message-Id: <20250916044735.2316171-7-dolinux.peng@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250916044735.2316171-1-dolinux.peng@gmail.com> References: <20250916044735.2316171-1-dolinux.peng@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Tue, 16 Sep 2025 14:55:20 +0000 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" From: pengdonglin Since commit a8bb74acd8efe ("rcu: Consolidate RCU-sched update-side function definitions") there is no difference between rcu_read_lock(), rcu_read_lock_bh() and rcu_read_lock_sched() in terms of RCU read section and the relevant grace period. That means that spin_lock(), which implies rcu_read_lock_sched(), also implies rcu_read_lock(). There is no need no explicitly start a RCU read section if one has already been started implicitly by spin_lock(). Simplify the code and remove the inner rcu_read_lock() invocation. Signed-off-by: pengdonglin Signed-off-by: pengdonglin --- ipc/msg.c | 1 - ipc/sem.c | 1 - ipc/shm.c | 1 - ipc/util.c | 2 -- 4 files changed, 5 deletions(-) diff --git a/ipc/msg.c b/ipc/msg.c index ee6af4fe52bf..1e579b57023f 100644 --- a/ipc/msg.c +++ b/ipc/msg.c @@ -179,7 +179,6 @@ static int newque(struct ipc_namespace *ns, struct ipc_params *params) } ipc_unlock_object(&msq->q_perm); - rcu_read_unlock(); return msq->q_perm.id; } diff --git a/ipc/sem.c b/ipc/sem.c index a39cdc7bf88f..38ad57b2b558 100644 --- a/ipc/sem.c +++ b/ipc/sem.c @@ -579,7 +579,6 @@ static int newary(struct ipc_namespace *ns, struct ipc_params *params) ns->used_sems += nsems; sem_unlock(sma, -1); - rcu_read_unlock(); return sma->sem_perm.id; } diff --git a/ipc/shm.c b/ipc/shm.c index a9310b6dbbc3..61fae1b6a18e 100644 --- a/ipc/shm.c +++ b/ipc/shm.c @@ -795,7 +795,6 @@ static int newseg(struct ipc_namespace *ns, struct ipc_params *params) error = shp->shm_perm.id; ipc_unlock_object(&shp->shm_perm); - rcu_read_unlock(); return error; no_id: diff --git a/ipc/util.c b/ipc/util.c index cae60f11d9c2..1be691b5dcad 100644 --- a/ipc/util.c +++ b/ipc/util.c @@ -293,7 +293,6 @@ int ipc_addid(struct ipc_ids *ids, struct kern_ipc_perm *new, int limit) idr_preload(GFP_KERNEL); spin_lock_init(&new->lock); - rcu_read_lock(); spin_lock(&new->lock); current_euid_egid(&euid, &egid); @@ -316,7 +315,6 @@ int ipc_addid(struct ipc_ids *ids, struct kern_ipc_perm *new, int limit) if (idx < 0) { new->deleted = true; spin_unlock(&new->lock); - rcu_read_unlock(); return idx; } -- 2.34.1