From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F028CAC59B for ; Tue, 16 Sep 2025 14:55:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C1E3D10E7F5; Tue, 16 Sep 2025 14:55:26 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="AfHe9fK4"; dkim-atps=neutral Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by gabe.freedesktop.org (Postfix) with ESMTPS id B3F3E10E63D for ; Tue, 16 Sep 2025 04:49:07 +0000 (UTC) Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-b54b0434101so3147126a12.2 for ; Mon, 15 Sep 2025 21:49:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757998147; x=1758602947; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Gp+N7RFYdL+M8U5Aod5ZJl4PoDAFL89oD30EaW4MsNY=; b=AfHe9fK45pRKOY+4778IXHGf1cT2+yPbCCPYMVfdl3CVBQadKOkdMhyX577eZ8DnQL KYAHud9Yz5icCniMvOShHl1QY561B2dnbaWKZvz8jekJFmAq8lMHw7vV5npvnnZVY2zY GVZ8lIZG/NLcKYe5+3KDOCM8Yuj/t6hW/QtQp9yLT8QUEC5oHGNRbEAI71NJdmHStHed h0EvhZAOwus0r5slvenprGifNKCztcAg4NDjNhC2O7j8XBoXtFlxk0TIMsRSCgd+0g5N Kha0aX5tmIiwVxczqxLKzCeyZ13rBx86RVpBJ+p7BRQuD7K1d8mIVkZk0iF05ZWoc6Cz i5cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757998147; x=1758602947; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Gp+N7RFYdL+M8U5Aod5ZJl4PoDAFL89oD30EaW4MsNY=; b=DG4UshKol1WyvtyEDos9DT3HjPpMqhHSaYLAlds3/bpBNjurYQ5Q1t9qsWDSRo1To3 AzcVO9uw59ZXPbbIfNqaxO50v9MvyxV0bfCaCd/JR+N1dp3kPx52tWNH7Uj11R8ABfdA NQrx2kvG5vmhlWe3kYvqfwf2Ao+5abvKlvQZVyAtHcoMKa4tT8KNkOrQgXRgybcjUaIG BfwTe+LNarackhE6DaMg46e0Wh5J6doF8mgeqM1SLRbkBbuUq/1h5M/Yh4uhVLmAsQRz cRggDiDAIovHYGM1JUAvdtPSFn1ja75RUClI9mXTIuL+tgwby//URp4Yyr9+T6AExfHc ECuQ== X-Forwarded-Encrypted: i=1; AJvYcCUnrOAhSC1nb2qYp1Q6sFkceDVPGcCefkamvncS6ebgabvzzycDOWYPYZdY5umHA+2JbXfQMcvO2/4=@lists.freedesktop.org X-Gm-Message-State: AOJu0YxJR4LNXPB/HIw4LRunakSd017BHvpXPM63oJQgRJR1VdW2MmqD 9FUM8ev5+akpSJ3FeXkLW65s0z0WLZ9GfX9AxfjyY1E7fgRfMT7drYns X-Gm-Gg: ASbGncv0VJPrs5QGMYRK2PNarFu0J68Vvdu0i3Qj+xgH7DC4fzp0aGUwQhwxddX7E/a RdBMVJ27uPNbem3j/8BLQvpNjJ+Hm5H/FrozLr0dEMJ6B3ipIFb1+xAtZ0AxY+r1ywPG9tkx5bG RFaGcSXNlek1gwkD9E6jCIQmkqcMP1lzPKL7EiMLsDD4L8vk98/hRnAG/X7aIDgMsw+VRQZZlV7 gG7qpnepv9LcdnuGBt6DfdOTgxRKIL2L+GO7tgUwInjLB1kdIZ0ZLrTk82N8aup0vQSpfJ34OhV iLSPSoGuYSPOo7xD46bExO8kQck0JGxym9nhy7DAaWbnj5y6h3xS5+HM/5TRcb77d/TPlO/YZtB 29a29HCWT3SSxxlOJIj9u5r0g9nQzSVOgqCIkjUM= X-Google-Smtp-Source: AGHT+IFqD7sgMgos1nHHN1tffY5PC8RBagTW/SlAHYpHIH6iPNz9WSa7pJxkI6T7wvTsG+plknRS6A== X-Received: by 2002:a17:902:f70e:b0:266:120a:29c7 with SMTP id d9443c01a7336-266120a3078mr75581275ad.6.1757998147150; Mon, 15 Sep 2025 21:49:07 -0700 (PDT) Received: from pengdl-pc.mioffice.cn ([43.224.245.249]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-25ef09c77f8sm104600605ad.15.2025.09.15.21.49.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Sep 2025 21:49:06 -0700 (PDT) From: pengdonglin To: tj@kernel.org, tony.luck@intel.com, jani.nikula@linux.intel.com, ap420073@gmail.com, jv@jvosburgh.net, freude@linux.ibm.com, bcrl@kvack.org, trondmy@kernel.org, longman@redhat.com, kees@kernel.org Cc: bigeasy@linutronix.de, hdanton@sina.com, paulmck@kernel.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, linux-nfs@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-wireless@vger.kernel.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, cgroups@vger.kernel.org, pengdonglin , Johannes Weiner , pengdonglin Subject: [PATCH v3 08/14] cgroup: Remove redundant rcu_read_lock/unlock() in spin_lock Date: Tue, 16 Sep 2025 12:47:29 +0800 Message-Id: <20250916044735.2316171-9-dolinux.peng@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250916044735.2316171-1-dolinux.peng@gmail.com> References: <20250916044735.2316171-1-dolinux.peng@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Tue, 16 Sep 2025 14:55:20 +0000 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" From: pengdonglin Since commit a8bb74acd8efe ("rcu: Consolidate RCU-sched update-side function definitions") there is no difference between rcu_read_lock(), rcu_read_lock_bh() and rcu_read_lock_sched() in terms of RCU read section and the relevant grace period. That means that spin_lock(), which implies rcu_read_lock_sched(), also implies rcu_read_lock(). There is no need no explicitly start a RCU read section if one has already been started implicitly by spin_lock(). Simplify the code and remove the inner rcu_read_lock() invocation. Cc: Tejun Heo Cc: Johannes Weiner Cc: Waiman Long Signed-off-by: pengdonglin Signed-off-by: pengdonglin --- kernel/cgroup/cgroup.c | 2 -- kernel/cgroup/debug.c | 4 ---- 2 files changed, 6 deletions(-) diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index 312c6a8b55bb..db9e00a559df 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -2944,14 +2944,12 @@ int cgroup_attach_task(struct cgroup *dst_cgrp, struct task_struct *leader, /* look up all src csets */ spin_lock_irq(&css_set_lock); - rcu_read_lock(); task = leader; do { cgroup_migrate_add_src(task_css_set(task), dst_cgrp, &mgctx); if (!threadgroup) break; } while_each_thread(leader, task); - rcu_read_unlock(); spin_unlock_irq(&css_set_lock); /* prepare dst csets and commit */ diff --git a/kernel/cgroup/debug.c b/kernel/cgroup/debug.c index 80aa3f027ac3..81ea38dd6f9d 100644 --- a/kernel/cgroup/debug.c +++ b/kernel/cgroup/debug.c @@ -49,7 +49,6 @@ static int current_css_set_read(struct seq_file *seq, void *v) return -ENODEV; spin_lock_irq(&css_set_lock); - rcu_read_lock(); cset = task_css_set(current); refcnt = refcount_read(&cset->refcount); seq_printf(seq, "css_set %pK %d", cset, refcnt); @@ -67,7 +66,6 @@ static int current_css_set_read(struct seq_file *seq, void *v) seq_printf(seq, "%2d: %-4s\t- %p[%d]\n", ss->id, ss->name, css, css->id); } - rcu_read_unlock(); spin_unlock_irq(&css_set_lock); cgroup_kn_unlock(of->kn); return 0; @@ -95,7 +93,6 @@ static int current_css_set_cg_links_read(struct seq_file *seq, void *v) return -ENOMEM; spin_lock_irq(&css_set_lock); - rcu_read_lock(); cset = task_css_set(current); list_for_each_entry(link, &cset->cgrp_links, cgrp_link) { struct cgroup *c = link->cgrp; @@ -104,7 +101,6 @@ static int current_css_set_cg_links_read(struct seq_file *seq, void *v) seq_printf(seq, "Root %d group %s\n", c->root->hierarchy_id, name_buf); } - rcu_read_unlock(); spin_unlock_irq(&css_set_lock); kfree(name_buf); return 0; -- 2.34.1