From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 513AACE8D55 for ; Fri, 14 Nov 2025 17:15:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D280410EAE4; Fri, 14 Nov 2025 17:15:49 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="nU+iuGAT"; dkim-atps=neutral Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0133210EADE; Fri, 14 Nov 2025 17:15:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1763140546; bh=ID+wxlGDegTSQQqO+tfv+j3F//xuzjuJ6+40mXVWHgY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nU+iuGATE0QjIxjGhzFYT6AUXWPCOhQdAJu/0W8EeKONVvx28VL4l3LWvT8ti+wnq +xbEFjKI3wOXVR0b2FApQZpSaFWkNXCU7xXgw3rWQjBQzC1kj8yel2Tcrq4+ZhXBaK uXB/FJPJC8jm5qEJo3pfFqZeRF1n4JxVzKCOBMj+QLff+2m4l/SH5OOUtWHMCXbnof CLpAdSxKiln4mzIs+3D25R2MEZzE1f5fI//kmoSMdvmcWKx91cfbmxr/Rd8tsMY58x TjHf1gQEWa/3TIK3bfNMqykgd6dcCBsivQWynhnjFE+pQmiAY32ASryZdqairHzF54 OSmSAnXo9ArXg== Received: from fedora (unknown [IPv6:2a01:e0a:2c:6930:d919:a6e:5ea1:8a9f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 5EB6C17E12D5; Fri, 14 Nov 2025 18:15:45 +0100 (CET) Date: Fri, 14 Nov 2025 18:15:40 +0100 From: Boris Brezillon To: =?UTF-8?B?TG/Dr2M=?= Molinari Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Rob Herring , Steven Price , Liviu Dudau , Melissa Wen , =?UTF-8?B?TWHDrXJh?= Canal , Hugh Dickins , Baolin Wang , Andrew Morton , Al Viro , =?UTF-8?B?TWlrb8WCYWo=?= Wasiak , Christian Brauner , Nitin Gote , Andi Shyti , Jonathan Corbet , Christopher Healy , Matthew Wilcox , Bagas Sanjaya , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH v9 07/11] drm/gem: Get rid of *_with_mnt helpers Message-ID: <20251114181540.102789b1@fedora> In-Reply-To: <20251114170303.2800-8-loic.molinari@collabora.com> References: <20251114170303.2800-1-loic.molinari@collabora.com> <20251114170303.2800-8-loic.molinari@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, 14 Nov 2025 18:02:58 +0100 Lo=C3=AFc Molinari wrote: > diff --git a/drivers/gpu/drm/v3d/v3d_bo.c b/drivers/gpu/drm/v3d/v3d_bo.c > index 211578abf9b6..c4316b768b3d 100644 > --- a/drivers/gpu/drm/v3d/v3d_bo.c > +++ b/drivers/gpu/drm/v3d/v3d_bo.c > @@ -153,12 +153,7 @@ struct v3d_bo *v3d_bo_create(struct drm_device *dev,= struct drm_file *file_priv, > struct v3d_bo *bo; > int ret; > =20 > -#ifdef CONFIG_TRANSPARENT_HUGEPAGE > - shmem_obj =3D drm_gem_shmem_create_with_mnt(dev, unaligned_size, > - dev->huge_mnt); > -#else > shmem_obj =3D drm_gem_shmem_create(dev, unaligned_size); > -#endif Hm, okay, the thing I complained about in patch 6 is dropped here. If there's nothing else to address, don't bother sending a new version just for that. > if (IS_ERR(shmem_obj)) > return ERR_CAST(shmem_obj); > bo =3D to_v3d_bo(&shmem_obj->base);