From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1011D116E2 for ; Fri, 28 Nov 2025 21:06:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1648E10E92E; Fri, 28 Nov 2025 21:06:55 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="YRUeWAHT"; dkim-atps=neutral Received: from sender3-pp-f112.zoho.com (sender3-pp-f112.zoho.com [136.143.184.112]) by gabe.freedesktop.org (Postfix) with ESMTPS id 81C1C10E92C; Fri, 28 Nov 2025 21:06:53 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; t=1764364003; cv=none; d=zohomail.com; s=zohoarc; b=ZRZKyGIAohl6AiHLz+Z1Jaie2XFzIkaBqcGOMMFNsP6MEzT/ERdfTjqU3RH9uyBI/53wpkh0xDj2SObm5ea8oS+8yLlWI8hUgIgmRc94FQg846UrsQgCh5TkOALkHNaAcGnnUlYSeC81J9ALd+WmgTNvM8c1+CuLepQe7CAjvFM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764364003; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=HuuEqm/VM8Z9sKdKKwEgeX6ClWHBKU/5BuknVOHkhMU=; b=LcLzeLuW0/vmYpS5B/sUkhJijZYajuislfZLc6Uz5836uLHf8jb5UQVrJiUEu5BUXNcn058E8iwdCfCS2Aewq1Z1G6x/8Xvq7Fv98/Yv6Uf+S5k8jpHjqVKqk2jM4RmXcd8cKwa91FugFqLkiPe2eXfrkNKkKLIL5Lb/TZyTU50= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1764364003; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=HuuEqm/VM8Z9sKdKKwEgeX6ClWHBKU/5BuknVOHkhMU=; b=YRUeWAHTr0ytDCeq8Czhp2rruQDGKby5gl2vs3aCqSXmVIpfVDYjRr4YwHoILd8j 5oO6CL8EYGUDEQUO1pByPZn1BVjS1FJQdx/P5Fb25Q7KJDYPANmIPf0a3XfCMjtCt5V g6wnHeXZ9hahin9xCAnEXD2kznvIOfA3kFSNCDWA= Received: by mx.zohomail.com with SMTPS id 1764364001462814.7343165114526; Fri, 28 Nov 2025 13:06:41 -0800 (PST) From: Nicolas Frattaroli Date: Fri, 28 Nov 2025 22:05:42 +0100 Subject: [PATCH v5 06/17] drm/display: hdmi-state-helper: Try subsampling in mode_valid MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251128-color-format-v5-6-63e82f1db1e1@collabora.com> References: <20251128-color-format-v5-0-63e82f1db1e1@collabora.com> In-Reply-To: <20251128-color-format-v5-0-63e82f1db1e1@collabora.com> To: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Dmitry Baryshkov , Sascha Hauer , Rob Herring Cc: kernel@collabora.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, Nicolas Frattaroli X-Mailer: b4 0.14.3 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" drm_hdmi_connector_mode_valid assumes modes are only valid if they work with RGB. The reality is more complex however: YCbCr 4:2:0 chroma-subsampled modes only require half the pixel clock that the same mode would require in RGB. This leads to drm_hdmi_connector_mode_valid rejecting perfectly valid 420-only modes. Fix this by checking whether the mode is 420-only first. If so, then proceed by checking it with HDMI_COLORSPACE_YUV420 so long as the connector has legalized 420, otherwise error out. If the mode is not 420-only, check with RGB as was previously always the case. Fixes: 47368ab437fd ("drm/display: hdmi: add generic mode_valid helper") Signed-off-by: Nicolas Frattaroli --- drivers/gpu/drm/display/drm_hdmi_state_helper.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/display/drm_hdmi_state_helper.c b/drivers/gpu/drm/display/drm_hdmi_state_helper.c index 5da956bdd68c..1800e00b30c5 100644 --- a/drivers/gpu/drm/display/drm_hdmi_state_helper.c +++ b/drivers/gpu/drm/display/drm_hdmi_state_helper.c @@ -892,8 +892,18 @@ drm_hdmi_connector_mode_valid(struct drm_connector *connector, const struct drm_display_mode *mode) { unsigned long long clock; + enum hdmi_colorspace fmt; + + if (drm_mode_is_420_only(&connector->display_info, mode)) { + if (connector->ycbcr_420_allowed) + fmt = HDMI_COLORSPACE_YUV420; + else + return MODE_NO_420; + } else { + fmt = HDMI_COLORSPACE_RGB; + } - clock = drm_hdmi_compute_mode_clock(mode, 8, HDMI_COLORSPACE_RGB); + clock = drm_hdmi_compute_mode_clock(mode, 8, fmt); if (!clock) return MODE_ERROR; -- 2.52.0