From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9F2ED116F3 for ; Sat, 29 Nov 2025 19:53:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9895E10E213; Sat, 29 Nov 2025 19:53:09 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Vy0aS96a"; dkim-atps=neutral Received: from mail-yx1-f46.google.com (mail-yx1-f46.google.com [74.125.224.46]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2BBBB10E20F for ; Sat, 29 Nov 2025 19:53:08 +0000 (UTC) Received: by mail-yx1-f46.google.com with SMTP id 956f58d0204a3-640d43060d2so2146977d50.2 for ; Sat, 29 Nov 2025 11:53:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764445987; x=1765050787; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=T1J39AX21q7vFvdSQspB28V0qpAzX2/AVdKjbIUMHgo=; b=Vy0aS96aEvpSklYdJdHEFixXaDtGHHtXlBZQCW5m3cp1DRh80zC8nw/GJAKO55dPcc AOcmW0/2o+IUotHwky76a68rjRJV1/dq9NEAhGTTKRwQlKI9Ki2ZxPimlMgDj76lVtAc o0u4sLpX0nT7o2Wqs/jnRwBfcjGQIcdnEUcRGyUvajVY1EZpWLY04YOm8MyVjZRVMo8y tIl8TCGRQrb6RFAw4aCA+puloeCuXjsEJAgvGkqgl6oazOs3TxfSqnkcGbj60wtQCvha hxFKPkO7fTvcD8TPVQOsk67JmM50Ygb8roYSVvCsgIDRUu6tLtr8+t4+/iXTN834Qo1V q3WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764445987; x=1765050787; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=T1J39AX21q7vFvdSQspB28V0qpAzX2/AVdKjbIUMHgo=; b=McB5sdg8VPxU0H+zsd52EFyzxDXJkGlJGYEbMrKum7j1Te12U7fGTcIYdTEafQAX/2 cJB9otNY3H2RrTl8ugMA/kdHkqUd4mumoxqAISAo9YOMxss5Wghu3rSZX+bsGZvlHwbc fD0uyJA000QrLpYI3wHluuCMqH6CP/tKD6YOXZvdGYNOqkCYmcSQQCvnJo6KOXdbSONc fiQxJYmC7b+TxM8lHXrD5Uk0ib3TsFO6MzKgFpcHy5wg6RTfj/JK5iL6RYtnAPYgmsWu TpPc0rmLvwkuAAtEHk5+dJbvXBbNYJg6PTuEqOKlsT8f9u5tVgoQdrEm0USmQeJHDdMT IsIw== X-Forwarded-Encrypted: i=1; AJvYcCU6C+W8TY2jRgZIVN/z8rQnKhQ+h0+bmVSg9VvUn2SqaT4Cl4UNmQMW6TtXjCjQEYrWe97CVTm5Us0=@lists.freedesktop.org X-Gm-Message-State: AOJu0YyWvv8Quj48aQcAUBca6pEBK1+9FizypHSishWDNytEnYgdZZW4 d/Y7YlOXDVXdBm5XQx1TEs5Z7tdGAvOGtLVhTkWlnJYUEJpPVkcohXSd X-Gm-Gg: ASbGncvjzA90nVrg9cLrY95X42TjFf2WTvj/ldfWNi7SBgo5ahfHVKsEgIRjAAv859H wv3sUMHdu+xC6UkAjVQDW9KWtEMdb+U+R9abLdSufeHSpp+SLHp5nozArC+lPWaRJnnH5BDejQt inwF1G/j5l92jFko6PX99+9jps7bBEPlQkXsopyNs+qzyOVRXO4Y608i7Y9C9t96hXrNt5Cr7KI LXcmJSKlfTVlsCEvZQeQvzA7r04fpIax73SsThzs0URv4AxRYCceKeU90zoOCySUBGWN1S9CwOW z68lnkmFabx6yV/EhZ+jxsidHz1/fa0LYoYjpWMgfRh9TiPpkb7ClDVaCqw+krso/x/aGGLZaDn ZH3GoyDepJkCruhSTBKMEcKAnUqCme9F96FbTtA4wsia0oSzCIP+2L1io0vQEIsKR9iUOZbaWDc dpnUv9kTk= X-Google-Smtp-Source: AGHT+IGoe6k+HGoU1YAfc/PgjNGtkUsJD9d1pFuoEvQqZEuvaXl0b1nF4MNPaTfl/35pvJr8rQDxmg== X-Received: by 2002:a53:cd8c:0:b0:63e:1943:ce49 with SMTP id 956f58d0204a3-64302abb486mr16805469d50.39.1764445987167; Sat, 29 Nov 2025 11:53:07 -0800 (PST) Received: from localhost ([2601:346:0:79bd:353a:b6ab:d4ee:67b9]) by smtp.gmail.com with ESMTPSA id 00721157ae682-78ad1044f9esm28752057b3.56.2025.11.29.11.53.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 11:53:06 -0800 (PST) From: "Yury Norov (NVIDIA)" To: Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Andy Shevchenko , Randy Dunlap , Ingo Molnar , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Petr Pavlu , Daniel Gomez , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Andrew Morton , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-modules@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: "Yury Norov (NVIDIA)" Subject: [PATCH 2/3] kernel.h: move VERIFY_OCTAL_PERMISSIONS() to sysfs.h Date: Sat, 29 Nov 2025 14:53:01 -0500 Message-ID: <20251129195304.204082-3-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251129195304.204082-1-yury.norov@gmail.com> References: <20251129195304.204082-1-yury.norov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" The macro is related to sysfs, but is defined in kernel.h. Move it to the proper header, and unload the generic kernel.h. Signed-off-by: Yury Norov (NVIDIA) --- include/linux/kernel.h | 12 ------------ include/linux/moduleparam.h | 2 +- include/linux/sysfs.h | 13 +++++++++++++ 3 files changed, 14 insertions(+), 13 deletions(-) diff --git a/include/linux/kernel.h b/include/linux/kernel.h index 61d63c57bc2d..5b879bfea948 100644 --- a/include/linux/kernel.h +++ b/include/linux/kernel.h @@ -389,16 +389,4 @@ static inline void ftrace_dump(enum ftrace_dump_mode oops_dump_mode) { } # define REBUILD_DUE_TO_DYNAMIC_FTRACE #endif -/* Permissions on a sysfs file: you didn't miss the 0 prefix did you? */ -#define VERIFY_OCTAL_PERMISSIONS(perms) \ - (BUILD_BUG_ON_ZERO((perms) < 0) + \ - BUILD_BUG_ON_ZERO((perms) > 0777) + \ - /* USER_READABLE >= GROUP_READABLE >= OTHER_READABLE */ \ - BUILD_BUG_ON_ZERO((((perms) >> 6) & 4) < (((perms) >> 3) & 4)) + \ - BUILD_BUG_ON_ZERO((((perms) >> 3) & 4) < ((perms) & 4)) + \ - /* USER_WRITABLE >= GROUP_WRITABLE */ \ - BUILD_BUG_ON_ZERO((((perms) >> 6) & 2) < (((perms) >> 3) & 2)) + \ - /* OTHER_WRITABLE? Generally considered a bad idea. */ \ - BUILD_BUG_ON_ZERO((perms) & 2) + \ - (perms)) #endif diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h index 6907aedc4f74..4e390a84a8bc 100644 --- a/include/linux/moduleparam.h +++ b/include/linux/moduleparam.h @@ -4,7 +4,7 @@ /* (C) Copyright 2001, 2002 Rusty Russell IBM Corporation */ #include #include -#include +#include /* * The maximum module name length, including the NUL byte. diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h index 9a25a2911652..15ee3ef33991 100644 --- a/include/linux/sysfs.h +++ b/include/linux/sysfs.h @@ -798,4 +798,17 @@ static inline void sysfs_put(struct kernfs_node *kn) kernfs_put(kn); } +/* Permissions on a sysfs file: you didn't miss the 0 prefix did you? */ +#define VERIFY_OCTAL_PERMISSIONS(perms) \ + (BUILD_BUG_ON_ZERO((perms) < 0) + \ + BUILD_BUG_ON_ZERO((perms) > 0777) + \ + /* USER_READABLE >= GROUP_READABLE >= OTHER_READABLE */ \ + BUILD_BUG_ON_ZERO((((perms) >> 6) & 4) < (((perms) >> 3) & 4)) + \ + BUILD_BUG_ON_ZERO((((perms) >> 3) & 4) < ((perms) & 4)) + \ + /* USER_WRITABLE >= GROUP_WRITABLE */ \ + BUILD_BUG_ON_ZERO((((perms) >> 6) & 2) < (((perms) >> 3) & 2)) + \ + /* OTHER_WRITABLE? Generally considered a bad idea. */ \ + BUILD_BUG_ON_ZERO((perms) & 2) + \ + (perms)) + #endif /* _SYSFS_H_ */ -- 2.43.0