From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 688A6D6E2B3 for ; Thu, 18 Dec 2025 16:34:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E06A310EA7D; Thu, 18 Dec 2025 16:34:04 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=lankhorst.se header.i=@lankhorst.se header.b="DBu0v5s7"; dkim-atps=neutral Received: from lankhorst.se (lankhorst.se [141.105.120.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 18B9010EA79; Thu, 18 Dec 2025 16:34:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lankhorst.se; s=default; t=1766075640; bh=PQMDqO5G/WnOdW0HuOnCwJ3VaIaIh7SyRkwX4MHDryY=; h=From:To:Subject:Date:In-Reply-To:References:From; b=DBu0v5s7BFSUkWKnQCfUsXBCArO/NH0mMyfisO25u9DY1Eb83kxt0NEOPO3/N3sKn gFZyme/0DY0qdiCRaYBZ4HkwFXvkLIeEkd79rLn9qwfyaICCRSMFg9Tg9neF6iIUQl w86TzpFWiDUB2dLwUL4qBHQobzLHlOY5Sdx5a2h8c19POhyZl+Gibtlw6ZSB0tFeFJ ciTBcDByNpjWzgS3tsylGbRaF4+hZVvGPfAObWvab18wz7QK4Ymuazd0ruH+fTldCY RvSKDIBiM5CW8DUvzga9YeGYrI5EThsq8K3aBJb5XmtjZ3EPbZbFHexz6w20dEIIAq +NbjdDGCZMtUg== From: Maarten Lankhorst To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Subject: [i915-rt v4 19/20] drm/i915/display: Do not take uncore lock in i915_get_vblank_counter Date: Thu, 18 Dec 2025 17:34:07 +0100 Message-ID: <20251218163408.97508-20-dev@lankhorst.se> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251218163408.97508-1-dev@lankhorst.se> References: <20251218163408.97508-1-dev@lankhorst.se> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_de.h | 8 ++++++ drivers/gpu/drm/i915/display/intel_vblank.c | 4 +-- drivers/gpu/drm/i915/intel_uncore.h | 25 +++++++++++++------ .../drm/xe/compat-i915-headers/intel_uncore.h | 7 ++++++ 4 files changed, 34 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_de.h b/drivers/gpu/drm/i915/display/intel_de.h index a7ce3b875e06c..e4fda91007f0a 100644 --- a/drivers/gpu/drm/i915/display/intel_de.h +++ b/drivers/gpu/drm/i915/display/intel_de.h @@ -63,6 +63,14 @@ intel_de_read64_2x32(struct intel_display *display, return val; } +static inline u64 +intel_de_read64_2x32_fw(struct intel_display *display, + i915_reg_t lower_reg, i915_reg_t upper_reg) +{ + return intel_uncore_read64_2x32_fw(__to_uncore(display), + lower_reg, upper_reg); +} + static inline void intel_de_posting_read(struct intel_display *display, i915_reg_t reg) { diff --git a/drivers/gpu/drm/i915/display/intel_vblank.c b/drivers/gpu/drm/i915/display/intel_vblank.c index a98dd3a436c28..a66f1d8db9fc4 100644 --- a/drivers/gpu/drm/i915/display/intel_vblank.c +++ b/drivers/gpu/drm/i915/display/intel_vblank.c @@ -110,8 +110,8 @@ u32 i915_get_vblank_counter(struct drm_crtc *crtc) * we get a low value that's stable across two reads of the high * register. */ - frame = intel_de_read64_2x32(display, PIPEFRAMEPIXEL(display, pipe), - PIPEFRAME(display, pipe)); + frame = intel_de_read64_2x32_fw(display, PIPEFRAMEPIXEL(display, pipe), + PIPEFRAME(display, pipe)); pixel = frame & PIPE_PIXEL_MASK; frame = (frame >> PIPE_FRAME_LOW_SHIFT) & 0xffffff; diff --git a/drivers/gpu/drm/i915/intel_uncore.h b/drivers/gpu/drm/i915/intel_uncore.h index fafc2ca9a2376..69eb37f61b572 100644 --- a/drivers/gpu/drm/i915/intel_uncore.h +++ b/drivers/gpu/drm/i915/intel_uncore.h @@ -449,13 +449,27 @@ static inline void intel_uncore_rmw_fw(struct intel_uncore *uncore, intel_uncore_write_fw(uncore, reg, val); } +static inline u64 +intel_uncore_read64_2x32_fw(struct intel_uncore *uncore) +{ + u32 upper lower, old_upper, loop = 0; + upper = intel_uncore_read_fw(uncoree, upper_reg); + do { + old_upper = upper; + lower = intel_uncore_read_fw(uncore, lower_reg); + upper = intel_uncore_read_fw(uncore, upper_reg); + } while (upper != old_upper && loop++ < 2); + + return (u64)upper << 32 | lower; +} + static inline u64 intel_uncore_read64_2x32(struct intel_uncore *uncore, i915_reg_t lower_reg, i915_reg_t upper_reg) { - u32 upper, lower, old_upper, loop = 0; enum forcewake_domains fw_domains; unsigned long flags; + u64 ret; fw_domains = intel_uncore_forcewake_for_reg(uncore, lower_reg, FW_REG_READ); @@ -466,17 +480,12 @@ intel_uncore_read64_2x32(struct intel_uncore *uncore, spin_lock_irqsave(&uncore->lock, flags); intel_uncore_forcewake_get__locked(uncore, fw_domains); - upper = intel_uncore_read_fw(uncore, upper_reg); - do { - old_upper = upper; - lower = intel_uncore_read_fw(uncore, lower_reg); - upper = intel_uncore_read_fw(uncore, upper_reg); - } while (upper != old_upper && loop++ < 2); + ret = intel_uncore_read64_2x32_fw(uncore, lower_reg, upper_reg); intel_uncore_forcewake_put__locked(uncore, fw_domains); spin_unlock_irqrestore(&uncore->lock, flags); - return (u64)upper << 32 | lower; + return ret; } static inline int intel_uncore_write_and_verify(struct intel_uncore *uncore, diff --git a/drivers/gpu/drm/xe/compat-i915-headers/intel_uncore.h b/drivers/gpu/drm/xe/compat-i915-headers/intel_uncore.h index d93ddacdf743d..fd6271bcbe03c 100644 --- a/drivers/gpu/drm/xe/compat-i915-headers/intel_uncore.h +++ b/drivers/gpu/drm/xe/compat-i915-headers/intel_uncore.h @@ -67,6 +67,13 @@ intel_uncore_read64_2x32(struct intel_uncore *uncore, return (u64)upper << 32 | lower; } +static inline u64 +intel_uncore_read64_2x32_fw(struct intel_uncore *uncore, + i915_reg_t i915_lower_reg, i915_reg_t i915_upper_reg) +{ + return intel_uncore_read64_2x32(uncore, i915_lower_reg, i915_upper_reg); +} + static inline void intel_uncore_posting_read(struct intel_uncore *uncore, i915_reg_t i915_reg) { -- 2.51.0