From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6AE6AD6E2B1 for ; Thu, 18 Dec 2025 16:34:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DBED810EA82; Thu, 18 Dec 2025 16:34:05 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=lankhorst.se header.i=@lankhorst.se header.b="NLmTNOkc"; dkim-atps=neutral Received: from lankhorst.se (lankhorst.se [141.105.120.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9A80310EA7D; Thu, 18 Dec 2025 16:34:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lankhorst.se; s=default; t=1766075643; bh=WY2ujozm3gV2D9EYsbqrm6oxzsduMN8ZpXrwP1pnA7A=; h=From:To:Subject:Date:In-Reply-To:References:From; b=NLmTNOkc6BHMgzi9xp/jmQe35Tef9ivBk/rfmPyl/R9dnJa9zralh7a4iuOF3dTSL z647wpvCrgH4ixH4eMizkHs0BDtgI1S4lIJHR/+aO8KLTa/hbxwS1ANTnXAxXUufeZ aYbCLFPPY8rWu2AHjeSRc2fXIC/Y83WbxBq/kxwO/km7Qb7EhjtND4pKi1vR1jsups 2svY2rOxAbzx1pf3+FgquBYCuY12gbf+hl4TBWMCMg7yuiCdvplPL9UWm+JQgsJCfE O2p/uZrpNu+Y5lXhHTd+ElHVBZ5nGlYCfKCnvTrjm6Y3h3duPni5X0ORyPQHVpBUGR ZNEx3vb879yOg== From: Maarten Lankhorst To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Subject: [i915-rt v4 20/20] drm/i915/display: Remove uncore lock from vlv_atomic_update_fifo Date: Thu, 18 Dec 2025 17:34:08 +0100 Message-ID: <20251218163408.97508-21-dev@lankhorst.se> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251218163408.97508-1-dev@lankhorst.se> References: <20251218163408.97508-1-dev@lankhorst.se> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" TODO: Grab uncore lock during entire vblank evasion before disabling interrupts, and check what breaks? Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/i9xx_wm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/i9xx_wm.c b/drivers/gpu/drm/i915/display/i9xx_wm.c index 167277cd88778..f510246f8c42a 100644 --- a/drivers/gpu/drm/i915/display/i9xx_wm.c +++ b/drivers/gpu/drm/i915/display/i9xx_wm.c @@ -1893,7 +1893,6 @@ static void vlv_atomic_update_fifo(struct intel_atomic_state *state, * intel_pipe_update_start() has already disabled interrupts * for us, so a plain spin_lock() is sufficient here. */ - spin_lock(&uncore->lock); switch (crtc->pipe) { case PIPE_A: @@ -1952,8 +1951,6 @@ static void vlv_atomic_update_fifo(struct intel_atomic_state *state, } intel_de_read_fw(display, DSPARB(display)); - - spin_unlock(&uncore->lock); } #undef VLV_FIFO -- 2.51.0