From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B86CAE6748A for ; Sun, 21 Dec 2025 00:35:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D3F1B10E107; Sun, 21 Dec 2025 00:35:53 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="gkgvBmFN"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id B739F10E107; Sun, 21 Dec 2025 00:35:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1766277353; x=1797813353; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=XZkYpEqAzDY2JtKBwiPM6CpOT8slyAlLhccftPgfE8g=; b=gkgvBmFNIuhqhZ87ZeDwbdCV/fuu5fXYfuJH0rRthSL6FGg8N95CePSd 0TM/BXp/xHDG6vUq+zt5HsrdVDt/UREBB1fT2bSYFHZNycBjUE5AIAp31 LupOWVOpQ2vkh5fdk4evRqetvwAZrA6YCHeDYikQDtUeJrpZqMEh81VU3 BfKStx5hc89uxgpO37GqV+fvtQE4FJ4wPtKgt8rm4ixasQ3GlIH1FKUXc JvAnPh2IqgOdtfuXlWjk82u306ZWOw8cN1d+zzxlRHFL3rDqNOfeIhhos 58fcqQAwqwq3zjFspucK9f0zpLSRBYl4THNjjWbKI4idLEdiFY2VNeWRT w==; X-CSE-ConnectionGUID: wjXSsYPmTyKRKIFSHqONTQ== X-CSE-MsgGUID: LM+mv4LcRC2PCjcAgJIU/A== X-IronPort-AV: E=McAfee;i="6800,10657,11648"; a="79644086" X-IronPort-AV: E=Sophos;i="6.21,164,1763452800"; d="scan'208";a="79644086" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2025 16:35:52 -0800 X-CSE-ConnectionGUID: 7IjYW8o2QeO9vrel1awSPw== X-CSE-MsgGUID: hhNJ7TuWRTOONoNAdNq7kw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,164,1763452800"; d="scan'208";a="199714295" Received: from lkp-server01.sh.intel.com (HELO 0d09efa1b85f) ([10.239.97.150]) by fmviesa009.fm.intel.com with ESMTP; 20 Dec 2025 16:35:50 -0800 Received: from kbuild by 0d09efa1b85f with local (Exim 4.98.2) (envelope-from ) id 1vX7QK-000000005Dv-0b1x; Sun, 21 Dec 2025 00:35:48 +0000 Date: Sun, 21 Dec 2025 08:35:29 +0800 From: kernel test robot To: Maarten Lankhorst , intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: oe-kbuild-all@lists.linux.dev Subject: Re: [i915-rt v4 19/20] drm/i915/display: Do not take uncore lock in i915_get_vblank_counter Message-ID: <202512210805.evqwvB16-lkp@intel.com> References: <20251218163408.97508-20-dev@lankhorst.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251218163408.97508-20-dev@lankhorst.se> X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Maarten, kernel test robot noticed the following build errors: [auto build test ERROR on drm-i915/for-linux-next] [also build test ERROR on drm-i915/for-linux-next-fixes drm-xe/drm-xe-next drm-tip/drm-tip linus/master v6.19-rc1 next-20251219] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Maarten-Lankhorst/drm-i915-display-Fix-intel_lpe_audio_irq_handler-for-PREEMPT-RT/20251219-044020 base: https://gitlab.freedesktop.org/drm/i915/kernel.git for-linux-next patch link: https://lore.kernel.org/r/20251218163408.97508-20-dev%40lankhorst.se patch subject: [i915-rt v4 19/20] drm/i915/display: Do not take uncore lock in i915_get_vblank_counter config: x86_64-rhel-9.4 (https://download.01.org/0day-ci/archive/20251221/202512210805.evqwvB16-lkp@intel.com/config) compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251221/202512210805.evqwvB16-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202512210805.evqwvB16-lkp@intel.com/ All error/warnings (new ones prefixed by >>): In file included from drivers/gpu/drm/i915/gt/intel_engine_types.h:26, from drivers/gpu/drm/i915/gt/intel_context_types.h:17, from drivers/gpu/drm/i915/gem/i915_gem_context_types.h:19, from drivers/gpu/drm/i915/gem/i915_gem_context.h:9, from drivers/gpu/drm/i915/i915_driver.c:75: drivers/gpu/drm/i915/intel_uncore.h: In function 'intel_uncore_read64_2x32_fw': >> drivers/gpu/drm/i915/intel_uncore.h:455:19: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'lower' 455 | u32 upper lower, old_upper, loop = 0; | ^~~~~ >> drivers/gpu/drm/i915/intel_uncore.h:455:19: error: 'lower' undeclared (first use in this function); did you mean 'tolower'? 455 | u32 upper lower, old_upper, loop = 0; | ^~~~~ | tolower drivers/gpu/drm/i915/intel_uncore.h:455:19: note: each undeclared identifier is reported only once for each function it appears in >> drivers/gpu/drm/i915/intel_uncore.h:455:26: error: 'old_upper' undeclared (first use in this function); did you mean 'si_upper'? 455 | u32 upper lower, old_upper, loop = 0; | ^~~~~~~~~ | si_upper >> drivers/gpu/drm/i915/intel_uncore.h:455:24: warning: left-hand operand of comma expression has no effect [-Wunused-value] 455 | u32 upper lower, old_upper, loop = 0; | ^ >> drivers/gpu/drm/i915/intel_uncore.h:455:37: error: 'loop' undeclared (first use in this function) 455 | u32 upper lower, old_upper, loop = 0; | ^~~~ drivers/gpu/drm/i915/intel_uncore.h:455:35: warning: left-hand operand of comma expression has no effect [-Wunused-value] 455 | u32 upper lower, old_upper, loop = 0; | ^ >> drivers/gpu/drm/i915/intel_uncore.h:456:9: error: 'upper' undeclared (first use in this function) 456 | upper = intel_uncore_read_fw(uncoree, upper_reg); | ^~~~~ >> drivers/gpu/drm/i915/intel_uncore.h:456:38: error: 'uncoree' undeclared (first use in this function); did you mean 'uncore'? 456 | upper = intel_uncore_read_fw(uncoree, upper_reg); | ^~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:425:55: note: in definition of macro 'intel_uncore_read_fw' 425 | #define intel_uncore_read_fw(...) __raw_uncore_read32(__VA_ARGS__) | ^~~~~~~~~~~ >> drivers/gpu/drm/i915/intel_uncore.h:456:47: error: 'upper_reg' undeclared (first use in this function) 456 | upper = intel_uncore_read_fw(uncoree, upper_reg); | ^~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:425:55: note: in definition of macro 'intel_uncore_read_fw' 425 | #define intel_uncore_read_fw(...) __raw_uncore_read32(__VA_ARGS__) | ^~~~~~~~~~~ >> drivers/gpu/drm/i915/intel_uncore.h:459:54: error: 'lower_reg' undeclared (first use in this function) 459 | lower = intel_uncore_read_fw(uncore, lower_reg); | ^~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:425:55: note: in definition of macro 'intel_uncore_read_fw' 425 | #define intel_uncore_read_fw(...) __raw_uncore_read32(__VA_ARGS__) | ^~~~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h: In function 'intel_uncore_read64_2x32': >> drivers/gpu/drm/i915/intel_uncore.h:483:15: error: too many arguments to function 'intel_uncore_read64_2x32_fw' 483 | ret = intel_uncore_read64_2x32_fw(uncore, lower_reg, upper_reg); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:453:1: note: declared here 453 | intel_uncore_read64_2x32_fw(struct intel_uncore *uncore) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ -- In file included from drivers/gpu/drm/i915/gt/intel_engine_types.h:26, from drivers/gpu/drm/i915/gt/intel_context_types.h:17, from drivers/gpu/drm/i915/gem/i915_gem_context_types.h:19, from drivers/gpu/drm/i915/gem/i915_gem_context.h:9, from drivers/gpu/drm/i915/i915_drm_client.c:14: drivers/gpu/drm/i915/intel_uncore.h: In function 'intel_uncore_read64_2x32_fw': >> drivers/gpu/drm/i915/intel_uncore.h:455:19: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'lower' 455 | u32 upper lower, old_upper, loop = 0; | ^~~~~ drivers/gpu/drm/i915/intel_uncore.h:455:19: error: 'lower' undeclared (first use in this function); did you mean 'islower'? 455 | u32 upper lower, old_upper, loop = 0; | ^~~~~ | islower drivers/gpu/drm/i915/intel_uncore.h:455:19: note: each undeclared identifier is reported only once for each function it appears in >> drivers/gpu/drm/i915/intel_uncore.h:455:26: error: 'old_upper' undeclared (first use in this function); did you mean 'si_upper'? 455 | u32 upper lower, old_upper, loop = 0; | ^~~~~~~~~ | si_upper >> drivers/gpu/drm/i915/intel_uncore.h:455:24: warning: left-hand operand of comma expression has no effect [-Wunused-value] 455 | u32 upper lower, old_upper, loop = 0; | ^ >> drivers/gpu/drm/i915/intel_uncore.h:455:37: error: 'loop' undeclared (first use in this function) 455 | u32 upper lower, old_upper, loop = 0; | ^~~~ drivers/gpu/drm/i915/intel_uncore.h:455:35: warning: left-hand operand of comma expression has no effect [-Wunused-value] 455 | u32 upper lower, old_upper, loop = 0; | ^ >> drivers/gpu/drm/i915/intel_uncore.h:456:9: error: 'upper' undeclared (first use in this function) 456 | upper = intel_uncore_read_fw(uncoree, upper_reg); | ^~~~~ >> drivers/gpu/drm/i915/intel_uncore.h:456:38: error: 'uncoree' undeclared (first use in this function); did you mean 'uncore'? 456 | upper = intel_uncore_read_fw(uncoree, upper_reg); | ^~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:425:55: note: in definition of macro 'intel_uncore_read_fw' 425 | #define intel_uncore_read_fw(...) __raw_uncore_read32(__VA_ARGS__) | ^~~~~~~~~~~ >> drivers/gpu/drm/i915/intel_uncore.h:456:47: error: 'upper_reg' undeclared (first use in this function) 456 | upper = intel_uncore_read_fw(uncoree, upper_reg); | ^~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:425:55: note: in definition of macro 'intel_uncore_read_fw' 425 | #define intel_uncore_read_fw(...) __raw_uncore_read32(__VA_ARGS__) | ^~~~~~~~~~~ >> drivers/gpu/drm/i915/intel_uncore.h:459:54: error: 'lower_reg' undeclared (first use in this function) 459 | lower = intel_uncore_read_fw(uncore, lower_reg); | ^~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:425:55: note: in definition of macro 'intel_uncore_read_fw' 425 | #define intel_uncore_read_fw(...) __raw_uncore_read32(__VA_ARGS__) | ^~~~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h: In function 'intel_uncore_read64_2x32': >> drivers/gpu/drm/i915/intel_uncore.h:483:15: error: too many arguments to function 'intel_uncore_read64_2x32_fw' 483 | ret = intel_uncore_read64_2x32_fw(uncore, lower_reg, upper_reg); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:453:1: note: declared here 453 | intel_uncore_read64_2x32_fw(struct intel_uncore *uncore) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ -- In file included from drivers/gpu/drm/i915/gt/intel_engine_types.h:26, from drivers/gpu/drm/i915/gt/intel_context_types.h:17, from drivers/gpu/drm/i915/gem/i915_gem_context_types.h:19, from drivers/gpu/drm/i915/i915_drv.h:40, from drivers/gpu/drm/i915/i915_ioctl.c:8: drivers/gpu/drm/i915/intel_uncore.h: In function 'intel_uncore_read64_2x32_fw': >> drivers/gpu/drm/i915/intel_uncore.h:455:19: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'lower' 455 | u32 upper lower, old_upper, loop = 0; | ^~~~~ drivers/gpu/drm/i915/intel_uncore.h:455:19: error: 'lower' undeclared (first use in this function); did you mean 'islower'? 455 | u32 upper lower, old_upper, loop = 0; | ^~~~~ | islower drivers/gpu/drm/i915/intel_uncore.h:455:19: note: each undeclared identifier is reported only once for each function it appears in >> drivers/gpu/drm/i915/intel_uncore.h:455:26: error: 'old_upper' undeclared (first use in this function); did you mean 'si_upper'? 455 | u32 upper lower, old_upper, loop = 0; | ^~~~~~~~~ | si_upper >> drivers/gpu/drm/i915/intel_uncore.h:455:24: warning: left-hand operand of comma expression has no effect [-Wunused-value] 455 | u32 upper lower, old_upper, loop = 0; | ^ >> drivers/gpu/drm/i915/intel_uncore.h:455:37: error: 'loop' undeclared (first use in this function) 455 | u32 upper lower, old_upper, loop = 0; | ^~~~ drivers/gpu/drm/i915/intel_uncore.h:455:35: warning: left-hand operand of comma expression has no effect [-Wunused-value] 455 | u32 upper lower, old_upper, loop = 0; | ^ >> drivers/gpu/drm/i915/intel_uncore.h:456:9: error: 'upper' undeclared (first use in this function) 456 | upper = intel_uncore_read_fw(uncoree, upper_reg); | ^~~~~ >> drivers/gpu/drm/i915/intel_uncore.h:456:38: error: 'uncoree' undeclared (first use in this function); did you mean 'uncore'? 456 | upper = intel_uncore_read_fw(uncoree, upper_reg); | ^~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:425:55: note: in definition of macro 'intel_uncore_read_fw' 425 | #define intel_uncore_read_fw(...) __raw_uncore_read32(__VA_ARGS__) | ^~~~~~~~~~~ >> drivers/gpu/drm/i915/intel_uncore.h:456:47: error: 'upper_reg' undeclared (first use in this function) 456 | upper = intel_uncore_read_fw(uncoree, upper_reg); | ^~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:425:55: note: in definition of macro 'intel_uncore_read_fw' 425 | #define intel_uncore_read_fw(...) __raw_uncore_read32(__VA_ARGS__) | ^~~~~~~~~~~ >> drivers/gpu/drm/i915/intel_uncore.h:459:54: error: 'lower_reg' undeclared (first use in this function) 459 | lower = intel_uncore_read_fw(uncore, lower_reg); | ^~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:425:55: note: in definition of macro 'intel_uncore_read_fw' 425 | #define intel_uncore_read_fw(...) __raw_uncore_read32(__VA_ARGS__) | ^~~~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h: In function 'intel_uncore_read64_2x32': >> drivers/gpu/drm/i915/intel_uncore.h:483:15: error: too many arguments to function 'intel_uncore_read64_2x32_fw' 483 | ret = intel_uncore_read64_2x32_fw(uncore, lower_reg, upper_reg); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:453:1: note: declared here 453 | intel_uncore_read64_2x32_fw(struct intel_uncore *uncore) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h: In function 'intel_uncore_read64_2x32_fw': >> drivers/gpu/drm/i915/intel_uncore.h:464:1: warning: control reaches end of non-void function [-Wreturn-type] 464 | } | ^ -- In file included from drivers/gpu/drm/i915/display/intel_de.h:12, from drivers/gpu/drm/i915/display/hsw_ips.c:13: drivers/gpu/drm/i915/intel_uncore.h: In function 'intel_uncore_read64_2x32_fw': >> drivers/gpu/drm/i915/intel_uncore.h:455:19: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'lower' 455 | u32 upper lower, old_upper, loop = 0; | ^~~~~ >> drivers/gpu/drm/i915/intel_uncore.h:455:19: error: 'lower' undeclared (first use in this function); did you mean 'tolower'? 455 | u32 upper lower, old_upper, loop = 0; | ^~~~~ | tolower drivers/gpu/drm/i915/intel_uncore.h:455:19: note: each undeclared identifier is reported only once for each function it appears in >> drivers/gpu/drm/i915/intel_uncore.h:455:26: error: 'old_upper' undeclared (first use in this function); did you mean 'si_upper'? 455 | u32 upper lower, old_upper, loop = 0; | ^~~~~~~~~ | si_upper >> drivers/gpu/drm/i915/intel_uncore.h:455:24: warning: left-hand operand of comma expression has no effect [-Wunused-value] 455 | u32 upper lower, old_upper, loop = 0; | ^ >> drivers/gpu/drm/i915/intel_uncore.h:455:37: error: 'loop' undeclared (first use in this function) 455 | u32 upper lower, old_upper, loop = 0; | ^~~~ drivers/gpu/drm/i915/intel_uncore.h:455:35: warning: left-hand operand of comma expression has no effect [-Wunused-value] 455 | u32 upper lower, old_upper, loop = 0; | ^ >> drivers/gpu/drm/i915/intel_uncore.h:456:9: error: 'upper' undeclared (first use in this function) 456 | upper = intel_uncore_read_fw(uncoree, upper_reg); | ^~~~~ >> drivers/gpu/drm/i915/intel_uncore.h:456:38: error: 'uncoree' undeclared (first use in this function); did you mean 'uncore'? 456 | upper = intel_uncore_read_fw(uncoree, upper_reg); | ^~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:425:55: note: in definition of macro 'intel_uncore_read_fw' 425 | #define intel_uncore_read_fw(...) __raw_uncore_read32(__VA_ARGS__) | ^~~~~~~~~~~ >> drivers/gpu/drm/i915/intel_uncore.h:456:47: error: 'upper_reg' undeclared (first use in this function) 456 | upper = intel_uncore_read_fw(uncoree, upper_reg); | ^~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:425:55: note: in definition of macro 'intel_uncore_read_fw' 425 | #define intel_uncore_read_fw(...) __raw_uncore_read32(__VA_ARGS__) | ^~~~~~~~~~~ >> drivers/gpu/drm/i915/intel_uncore.h:459:54: error: 'lower_reg' undeclared (first use in this function) 459 | lower = intel_uncore_read_fw(uncore, lower_reg); | ^~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:425:55: note: in definition of macro 'intel_uncore_read_fw' 425 | #define intel_uncore_read_fw(...) __raw_uncore_read32(__VA_ARGS__) | ^~~~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h: In function 'intel_uncore_read64_2x32': >> drivers/gpu/drm/i915/intel_uncore.h:483:15: error: too many arguments to function 'intel_uncore_read64_2x32_fw' 483 | ret = intel_uncore_read64_2x32_fw(uncore, lower_reg, upper_reg); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:453:1: note: declared here 453 | intel_uncore_read64_2x32_fw(struct intel_uncore *uncore) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/display/intel_de.h: In function 'intel_de_read64_2x32_fw': >> drivers/gpu/drm/i915/display/intel_de.h:70:16: error: too many arguments to function 'intel_uncore_read64_2x32_fw' 70 | return intel_uncore_read64_2x32_fw(__to_uncore(display), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:453:1: note: declared here 453 | intel_uncore_read64_2x32_fw(struct intel_uncore *uncore) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ -- In file included from drivers/gpu/drm/i915/gt/intel_engine_types.h:26, from drivers/gpu/drm/i915/gt/intel_context_types.h:17, from drivers/gpu/drm/i915/gem/i915_gem_context_types.h:19, from drivers/gpu/drm/i915/i915_drv.h:40, from drivers/gpu/drm/i915/display/i9xx_wm.c:10: drivers/gpu/drm/i915/intel_uncore.h: In function 'intel_uncore_read64_2x32_fw': >> drivers/gpu/drm/i915/intel_uncore.h:455:19: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'lower' 455 | u32 upper lower, old_upper, loop = 0; | ^~~~~ drivers/gpu/drm/i915/intel_uncore.h:455:19: error: 'lower' undeclared (first use in this function); did you mean 'islower'? 455 | u32 upper lower, old_upper, loop = 0; | ^~~~~ | islower drivers/gpu/drm/i915/intel_uncore.h:455:19: note: each undeclared identifier is reported only once for each function it appears in >> drivers/gpu/drm/i915/intel_uncore.h:455:26: error: 'old_upper' undeclared (first use in this function); did you mean 'si_upper'? 455 | u32 upper lower, old_upper, loop = 0; | ^~~~~~~~~ | si_upper >> drivers/gpu/drm/i915/intel_uncore.h:455:24: warning: left-hand operand of comma expression has no effect [-Wunused-value] 455 | u32 upper lower, old_upper, loop = 0; | ^ >> drivers/gpu/drm/i915/intel_uncore.h:455:37: error: 'loop' undeclared (first use in this function) 455 | u32 upper lower, old_upper, loop = 0; | ^~~~ drivers/gpu/drm/i915/intel_uncore.h:455:35: warning: left-hand operand of comma expression has no effect [-Wunused-value] 455 | u32 upper lower, old_upper, loop = 0; | ^ >> drivers/gpu/drm/i915/intel_uncore.h:456:9: error: 'upper' undeclared (first use in this function) 456 | upper = intel_uncore_read_fw(uncoree, upper_reg); | ^~~~~ >> drivers/gpu/drm/i915/intel_uncore.h:456:38: error: 'uncoree' undeclared (first use in this function); did you mean 'uncore'? 456 | upper = intel_uncore_read_fw(uncoree, upper_reg); | ^~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:425:55: note: in definition of macro 'intel_uncore_read_fw' 425 | #define intel_uncore_read_fw(...) __raw_uncore_read32(__VA_ARGS__) | ^~~~~~~~~~~ >> drivers/gpu/drm/i915/intel_uncore.h:456:47: error: 'upper_reg' undeclared (first use in this function) 456 | upper = intel_uncore_read_fw(uncoree, upper_reg); | ^~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:425:55: note: in definition of macro 'intel_uncore_read_fw' 425 | #define intel_uncore_read_fw(...) __raw_uncore_read32(__VA_ARGS__) | ^~~~~~~~~~~ >> drivers/gpu/drm/i915/intel_uncore.h:459:54: error: 'lower_reg' undeclared (first use in this function) 459 | lower = intel_uncore_read_fw(uncore, lower_reg); | ^~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:425:55: note: in definition of macro 'intel_uncore_read_fw' 425 | #define intel_uncore_read_fw(...) __raw_uncore_read32(__VA_ARGS__) | ^~~~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h: In function 'intel_uncore_read64_2x32': >> drivers/gpu/drm/i915/intel_uncore.h:483:15: error: too many arguments to function 'intel_uncore_read64_2x32_fw' 483 | ret = intel_uncore_read64_2x32_fw(uncore, lower_reg, upper_reg); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:453:1: note: declared here 453 | intel_uncore_read64_2x32_fw(struct intel_uncore *uncore) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/gpu/drm/i915/display/i9xx_wm.c:16: drivers/gpu/drm/i915/display/intel_de.h: In function 'intel_de_read64_2x32_fw': >> drivers/gpu/drm/i915/display/intel_de.h:70:16: error: too many arguments to function 'intel_uncore_read64_2x32_fw' 70 | return intel_uncore_read64_2x32_fw(__to_uncore(display), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:453:1: note: declared here 453 | intel_uncore_read64_2x32_fw(struct intel_uncore *uncore) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ -- In file included from drivers/gpu/drm/i915/gt/intel_engine_types.h:26, from drivers/gpu/drm/i915/gt/intel_context_types.h:17, from drivers/gpu/drm/i915/gem/i915_gem_context_types.h:19, from drivers/gpu/drm/i915/i915_drv.h:40, from drivers/gpu/drm/i915/display/intel_vblank.c:11: drivers/gpu/drm/i915/intel_uncore.h: In function 'intel_uncore_read64_2x32_fw': >> drivers/gpu/drm/i915/intel_uncore.h:455:19: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'lower' 455 | u32 upper lower, old_upper, loop = 0; | ^~~~~ drivers/gpu/drm/i915/intel_uncore.h:455:19: error: 'lower' undeclared (first use in this function); did you mean 'islower'? 455 | u32 upper lower, old_upper, loop = 0; | ^~~~~ | islower drivers/gpu/drm/i915/intel_uncore.h:455:19: note: each undeclared identifier is reported only once for each function it appears in >> drivers/gpu/drm/i915/intel_uncore.h:455:26: error: 'old_upper' undeclared (first use in this function); did you mean 'si_upper'? 455 | u32 upper lower, old_upper, loop = 0; | ^~~~~~~~~ | si_upper >> drivers/gpu/drm/i915/intel_uncore.h:455:24: warning: left-hand operand of comma expression has no effect [-Wunused-value] 455 | u32 upper lower, old_upper, loop = 0; | ^ >> drivers/gpu/drm/i915/intel_uncore.h:455:37: error: 'loop' undeclared (first use in this function) 455 | u32 upper lower, old_upper, loop = 0; | ^~~~ drivers/gpu/drm/i915/intel_uncore.h:455:35: warning: left-hand operand of comma expression has no effect [-Wunused-value] 455 | u32 upper lower, old_upper, loop = 0; | ^ >> drivers/gpu/drm/i915/intel_uncore.h:456:9: error: 'upper' undeclared (first use in this function) 456 | upper = intel_uncore_read_fw(uncoree, upper_reg); | ^~~~~ >> drivers/gpu/drm/i915/intel_uncore.h:456:38: error: 'uncoree' undeclared (first use in this function); did you mean 'uncore'? 456 | upper = intel_uncore_read_fw(uncoree, upper_reg); | ^~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:425:55: note: in definition of macro 'intel_uncore_read_fw' 425 | #define intel_uncore_read_fw(...) __raw_uncore_read32(__VA_ARGS__) | ^~~~~~~~~~~ >> drivers/gpu/drm/i915/intel_uncore.h:456:47: error: 'upper_reg' undeclared (first use in this function) 456 | upper = intel_uncore_read_fw(uncoree, upper_reg); | ^~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:425:55: note: in definition of macro 'intel_uncore_read_fw' 425 | #define intel_uncore_read_fw(...) __raw_uncore_read32(__VA_ARGS__) | ^~~~~~~~~~~ >> drivers/gpu/drm/i915/intel_uncore.h:459:54: error: 'lower_reg' undeclared (first use in this function) 459 | lower = intel_uncore_read_fw(uncore, lower_reg); | ^~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:425:55: note: in definition of macro 'intel_uncore_read_fw' 425 | #define intel_uncore_read_fw(...) __raw_uncore_read32(__VA_ARGS__) | ^~~~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h: In function 'intel_uncore_read64_2x32': >> drivers/gpu/drm/i915/intel_uncore.h:483:15: error: too many arguments to function 'intel_uncore_read64_2x32_fw' 483 | ret = intel_uncore_read64_2x32_fw(uncore, lower_reg, upper_reg); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:453:1: note: declared here 453 | intel_uncore_read64_2x32_fw(struct intel_uncore *uncore) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/gpu/drm/i915/display/intel_vblank.c:14: drivers/gpu/drm/i915/display/intel_de.h: In function 'intel_de_read64_2x32_fw': >> drivers/gpu/drm/i915/display/intel_de.h:70:16: error: too many arguments to function 'intel_uncore_read64_2x32_fw' 70 | return intel_uncore_read64_2x32_fw(__to_uncore(display), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:453:1: note: declared here 453 | intel_uncore_read64_2x32_fw(struct intel_uncore *uncore) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h: In function 'intel_uncore_read64_2x32_fw': >> drivers/gpu/drm/i915/intel_uncore.h:464:1: warning: control reaches end of non-void function [-Wreturn-type] 464 | } | ^ .. vim +455 drivers/gpu/drm/i915/intel_uncore.h 398 399 /* These are untraced mmio-accessors that are only valid to be used inside 400 * critical sections, such as inside IRQ handlers, where forcewake is explicitly 401 * controlled. 402 * 403 * Think twice, and think again, before using these. 404 * 405 * As an example, these accessors can possibly be used between: 406 * 407 * spin_lock_irq(&uncore->lock); 408 * intel_uncore_forcewake_get__locked(); 409 * 410 * and 411 * 412 * intel_uncore_forcewake_put__locked(); 413 * spin_unlock_irq(&uncore->lock); 414 * 415 * 416 * Note: some registers may not need forcewake held, so 417 * intel_uncore_forcewake_{get,put} can be omitted, see 418 * intel_uncore_forcewake_for_reg(). 419 * 420 * Certain architectures will die if the same cacheline is concurrently accessed 421 * by different clients (e.g. on Ivybridge). Access to registers should 422 * therefore generally be serialised, by either the dev_priv->uncore.lock or 423 * a more localised lock guarding all access to that bank of registers. 424 */ > 425 #define intel_uncore_read_fw(...) __raw_uncore_read32(__VA_ARGS__) 426 #define intel_uncore_write_fw(...) __raw_uncore_write32(__VA_ARGS__) 427 #define intel_uncore_write64_fw(...) __raw_uncore_write64(__VA_ARGS__) 428 #define intel_uncore_posting_read_fw(...) ((void)intel_uncore_read_fw(__VA_ARGS__)) 429 430 static inline u32 intel_uncore_rmw(struct intel_uncore *uncore, 431 i915_reg_t reg, u32 clear, u32 set) 432 { 433 u32 old, val; 434 435 old = intel_uncore_read(uncore, reg); 436 val = (old & ~clear) | set; 437 intel_uncore_write(uncore, reg, val); 438 return old; 439 } 440 441 static inline void intel_uncore_rmw_fw(struct intel_uncore *uncore, 442 i915_reg_t reg, u32 clear, u32 set) 443 { 444 u32 old, val; 445 446 old = intel_uncore_read_fw(uncore, reg); 447 val = (old & ~clear) | set; 448 if (val != old) 449 intel_uncore_write_fw(uncore, reg, val); 450 } 451 452 static inline u64 453 intel_uncore_read64_2x32_fw(struct intel_uncore *uncore) 454 { > 455 u32 upper lower, old_upper, loop = 0; > 456 upper = intel_uncore_read_fw(uncoree, upper_reg); 457 do { 458 old_upper = upper; > 459 lower = intel_uncore_read_fw(uncore, lower_reg); 460 upper = intel_uncore_read_fw(uncore, upper_reg); 461 } while (upper != old_upper && loop++ < 2); 462 463 return (u64)upper << 32 | lower; > 464 } 465 466 static inline u64 467 intel_uncore_read64_2x32(struct intel_uncore *uncore, 468 i915_reg_t lower_reg, i915_reg_t upper_reg) 469 { 470 enum forcewake_domains fw_domains; 471 unsigned long flags; 472 u64 ret; 473 474 fw_domains = intel_uncore_forcewake_for_reg(uncore, lower_reg, 475 FW_REG_READ); 476 477 fw_domains |= intel_uncore_forcewake_for_reg(uncore, upper_reg, 478 FW_REG_READ); 479 480 spin_lock_irqsave(&uncore->lock, flags); 481 intel_uncore_forcewake_get__locked(uncore, fw_domains); 482 > 483 ret = intel_uncore_read64_2x32_fw(uncore, lower_reg, upper_reg); 484 485 intel_uncore_forcewake_put__locked(uncore, fw_domains); 486 spin_unlock_irqrestore(&uncore->lock, flags); 487 488 return ret; 489 } 490 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki