From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C10EE674B5 for ; Mon, 22 Dec 2025 14:00:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 45D0910E693; Mon, 22 Dec 2025 14:00:08 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="WNXZVyYM"; dkim-atps=neutral Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by gabe.freedesktop.org (Postfix) with ESMTPS id EA93610E55E for ; Mon, 22 Dec 2025 08:22:16 +0000 (UTC) Received: by mail-pf1-f193.google.com with SMTP id d2e1a72fcca58-7b6dd81e2d4so3895104b3a.0 for ; Mon, 22 Dec 2025 00:22:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766391736; x=1766996536; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HpOUBSAqvR/6qLOY5JhuGvZqZpKLgLxKB67YbPHT84s=; b=WNXZVyYMCJnMr495GarObyXtvFnj28rivxbWiqdDzAfnISPvm/yzdfxZVhQbaH/qk+ u4Wtt5ub6vsascVn49sNzTXbrFewY1ZeoLAiE2VEVjD3EukEgQqyfZRV6oH686F9UFiE mVDUq6zFDpLfA6WnuVLkU11mI+lbUTEVByZhHyBuD9apD8KMTy6JdkwvuHxUzkvfJ5bM DwS8FO3g3zAnFDFUGbDsX1eSXFe/j4e7kMNXaMx8VIl1seSR/hH3rU8rMbi/A3wqfzNN Tcuv2NPyhK4lcdtPD6JcWZ5WyqQs9fYl02d5jmhvMzKo4ARUsZkKzwEzklaHCqDLO1Li ZBiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766391736; x=1766996536; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HpOUBSAqvR/6qLOY5JhuGvZqZpKLgLxKB67YbPHT84s=; b=ODe6dWrfkvdD50lRifii7AN0P7RDJzhV/b5gZETsbI+8oXs9KpE2FRQTvaBrcFqysK 21LR7lAhXc3O5aZZanfPtCJrGWvUQ+5xmonHh0B0p2vY0rTvl6F7Pi5GO/ZNh3kxaw8q iFOZZoEbQdzF7qH53iUt8/RZJUAsasdWaMuppjfOU0hIx+ZVP2G/YnvZdfdiVpqcATah bRYKQB2+xVkF51R3408j2kl9QWk+U2uEVsuAU492eeBk/qQNT77/jGY8NGebe8Y6/t33 bB3jguNbG6mDO8gXcsSLCVmEaHe2aRO7849SAN32JiLYM5N2WmNRKydX7iFF4Y/BfM8h uNSQ== X-Forwarded-Encrypted: i=1; AJvYcCXDvW9MPOsuHngcATVjfguNplbNSLg4Q9INwaj0D9aAzFwUutOfuDkX5/NmHNFT5DkZLONIvhk1WAo=@lists.freedesktop.org X-Gm-Message-State: AOJu0YyHfS97gHxmZuyZKcCSA8b2smXKHPFdkFr+fta4waFgZ7CfyWR6 q4KjKrYULBBPqTLbX+iOiW+QNqwKNm+xIgz+nzTAELpTKXfcPwGMB3Ec X-Gm-Gg: AY/fxX4tPwNVlRu0UWBR96oK8kNf5p3eTgiOjZ0tDAZT3d4c8anWyph7V6OpY1Lmh3W a0n4xVDoLNI2JYFnxIaOTl7FiIscaYxE82jL/Nw4gmR6/rZGMwD3o3vPqM52uRNqekbWuJ7r+J7 22jIOXe61JwXg2j69TQ6XOVUMWwrn/Wte0eG80n9TjPy25qUK9YhJmZUvY7k5X2j4HIZZel1eur rI0x9+CAKZ60BjsCZbGt4T6AkJ+3W5VFCt4IAVJo+J8qRAjdTXbzIvs6pQgdzez69KVKfUGZxSy /FevEtAmDO8xQBPgFZ0Xa7RWtlkj6YtebOmxTudMB+ByLvXhkNFzwQULs/6tXAgdjKSVNZRIhfk ZRRkybD0BC80thhJf/tQILLnIEGzal5ZrCUXZnvHLnIPMyP6FbvI+LocdElDYsmvIYZXlPWlK66 AWM1aeuCxR X-Google-Smtp-Source: AGHT+IFHqnkLVdqcXm7bGw59SVF2bpwuPS776EDpm2DBSj3/f5x17l2ZGosn+Y6e7lRKYamOLqvnUw== X-Received: by 2002:a05:6a00:ac85:b0:7e8:4433:8fa3 with SMTP id d2e1a72fcca58-7ff6607e4demr9148599b3a.43.1766391735766; Mon, 22 Dec 2025 00:22:15 -0800 (PST) Received: from frodo ([2404:4400:417e:3d00:8b90:7f55:1261:772f]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-7ff7e493123sm9540699b3a.50.2025.12.22.00.22.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Dec 2025 00:22:15 -0800 (PST) From: Jim Cromie To: linux-kernel@vger.kernel.org, jbaron@akamai.com, gregkh@linuxfoundation.org, ukaszb@chromium.org, louis.chauvet@bootlin.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, daniel.vetter@ffwll.ch, tvrtko.ursulin@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com, seanpaul@chromium.org, robdclark@gmail.com, groeck@google.com, yanivt@google.com, bleung@google.com, quic_saipraka@quicinc.com, will@kernel.org, catalin.marinas@arm.com, quic_psodagud@quicinc.com, maz@kernel.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, mingo@redhat.com, jim.cromie@gmail.com Subject: [PATCH v7 05/31] test-dyndbg: fixup CLASSMAP usage error Date: Mon, 22 Dec 2025 21:20:22 +1300 Message-ID: <20251222082049.1782440-6-jim.cromie@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251222082049.1782440-3-jim.cromie@gmail.com> References: <20251222082049.1782440-3-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Mon, 22 Dec 2025 14:00:06 +0000 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" commit 6ea3bf466ac6 ("dyndbg: test DECLARE_DYNDBG_CLASSMAP, sysfs nodes") A closer look at test_dynamic_debug.ko logging output reveals a macro usage error: lib/test_dynamic_debug.c:105 [test_dynamic_debug]do_cats =p "LOW msg\n" class:MID lib/test_dynamic_debug.c:106 [test_dynamic_debug]do_cats =p "MID msg\n" class:HI lib/test_dynamic_debug.c:107 [test_dynamic_debug]do_cats =_ "HI msg\n" class unknown, _id:13 107 says: HI is unknown, and 105,106 have a LOW/MID and MID/HI skew. DECLARE_DYNDBG_CLASSMAP() _base arg must equal the enum's 1st value, in this case it was _base + 1. This leaves HI class un-selectable. NB: the macro could better validate its arguments. Reviewed-by: Louis Chauvet Tested-by: Louis Chauvet Signed-off-by: Jim Cromie --- lib/test_dynamic_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/test_dynamic_debug.c b/lib/test_dynamic_debug.c index 77c2a669b6af..396144cf351b 100644 --- a/lib/test_dynamic_debug.c +++ b/lib/test_dynamic_debug.c @@ -75,7 +75,7 @@ DD_SYS_WRAP(disjoint_bits, p); DD_SYS_WRAP(disjoint_bits, T); /* symbolic input, independent bits */ -enum cat_disjoint_names { LOW = 11, MID, HI }; +enum cat_disjoint_names { LOW = 10, MID, HI }; DECLARE_DYNDBG_CLASSMAP(map_disjoint_names, DD_CLASS_TYPE_DISJOINT_NAMES, 10, "LOW", "MID", "HI"); DD_SYS_WRAP(disjoint_names, p); -- 2.52.0