From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 330E4E674BA for ; Mon, 22 Dec 2025 14:00:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1CF2F10E677; Mon, 22 Dec 2025 14:00:08 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="eNza9X9c"; dkim-atps=neutral Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by gabe.freedesktop.org (Postfix) with ESMTPS id 60F0F10E569 for ; Mon, 22 Dec 2025 08:22:40 +0000 (UTC) Received: by mail-pf1-f194.google.com with SMTP id d2e1a72fcca58-7f121c00dedso5006489b3a.0 for ; Mon, 22 Dec 2025 00:22:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766391759; x=1766996559; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pKljsU8Xmw+/foisR3SYsx7mqK9N8s1wNDUiE0Eb/VY=; b=eNza9X9cWDOMp2GilAlg91Nzc21blG8h1Hc0U/KUi5BTUkG7ZybroPG41eRKjuhO5e A8tFirPssDMIwFgU9j306iDKiOpa4M7CUciZ5X7PGvKh7wEZRTRHsPE1oLaxhk/mhzMM EW9V35TGtd46aFBvkO42IyutYy6DrKt221sQyjWB0vlF0d0HYhFyZtCB18xoS4mFNcoA CAZrSiVTBTuK1Ay5esg2sxSt726VYJzjwyYtjguUUSDXOHVCzrZbHAz8lLkueLQ1gcqw S6o5JkDYr6JVd0s1y3RlSiEVnjgDUWglC/dDWElI5+w6qeTw4f09+SICD9/GgH/X8eAu YWZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766391759; x=1766996559; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pKljsU8Xmw+/foisR3SYsx7mqK9N8s1wNDUiE0Eb/VY=; b=GyOcmT0RFRLOEorgg0dYoq4zpjeoK2anEaZAOsK4s7bQhUTzRd6OJlGxzvk2FEnAx2 2rvno1FOnSX3UHloBvJaaW2XatmDuN3dAWBIKhwzAEa3gKOLcJPHHnGpDfCs+9svDnW4 pJnnp74uet24DscP/sh7eDXGszNqz3zAGbR5oYDdYJ/zReiNbKpKdxDGa11Hp8eHcDBt abUbDL9QD0tUa2kBwaJtTYuOpkvZ5gPFsHrAbwAdQ/CNdATLFkl9J+7JqtOE8T6+Ym6s S0XnwNzGRrUx4V8qST/Zfkz7MbbxJAwxJLPfXk7oMaM2f07NJZi9bIiLbKmoukN/cnk9 ueyA== X-Forwarded-Encrypted: i=1; AJvYcCVUXGJQuFdn6yq9MFSMryIbFup/QsVxqX3yDQzNDOCGem5TzzXSzSbo0Cv2Bl1/KC04GUJEO7cgcG8=@lists.freedesktop.org X-Gm-Message-State: AOJu0YxLXp09OFB02DFEcTHzE9iEVFJovlTstyjq4qP3TUS/NLeLVxHh soeAAVBMzhDvWh7bTdmD8blIEVtNdxHNI9JhnXylWz8kHxae3ObGmeEq X-Gm-Gg: AY/fxX5Bg6eG5j2n6Hj4skLI1j5iZWlM94RgYn6lK90AIz96MPPG/cLZO9/1wuw0yE/ Vw7SqwdWcHXIBxC99BMrV8HHumbtXih5MLvRlXMUR4zf8xrnQWfRjorrObeJekbj6IWJhEo/KCB P81ChVFefK0DbIXLlgvdc/I6/otMPSyd+ch/kUZinHAM0+xtCTeCpfOWFCkM8gmbjkhyO8hMTgl tp1Nn80adFYL7VXZajs0ebY7P9x1cEhvYJ2Q0QV/a7ez8dV6Pu1ZHHA4eiMYnbqfj7CnJqAc84x liIco7mZF4zjsjLw20d+4HC+S54EyFu+h6jrITLOygjFEv/lLxgnlgCglZBE085XTQRSXqs0C41 Pf9WN+MQ6oVsmjWR8GIqW4zm6TRAcoV8ArzxbH9wEG4ycMmylOeVf0CCVFgwPYK9r2lXLnDUZ6i 2ym6nKFGI+ X-Google-Smtp-Source: AGHT+IEbn13GAc82azOlCQBzD0kgiJPbfq4yJfKj6lNc2cko7ljpTpb+ZvesmNM1IQ0X0cprC78m6A== X-Received: by 2002:a05:6a21:3395:b0:366:2341:4980 with SMTP id adf61e73a8af0-376a81dd746mr9694106637.11.1766391759442; Mon, 22 Dec 2025 00:22:39 -0800 (PST) Received: from frodo ([2404:4400:417e:3d00:8b90:7f55:1261:772f]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-7ff7e493123sm9540699b3a.50.2025.12.22.00.22.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Dec 2025 00:22:38 -0800 (PST) From: Jim Cromie To: linux-kernel@vger.kernel.org, jbaron@akamai.com, gregkh@linuxfoundation.org, ukaszb@chromium.org, louis.chauvet@bootlin.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, daniel.vetter@ffwll.ch, tvrtko.ursulin@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com, seanpaul@chromium.org, robdclark@gmail.com, groeck@google.com, yanivt@google.com, bleung@google.com, quic_saipraka@quicinc.com, will@kernel.org, catalin.marinas@arm.com, quic_psodagud@quicinc.com, maz@kernel.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, mingo@redhat.com, jim.cromie@gmail.com Subject: [PATCH v7 07/31] dyndbg: make ddebug_class_param union members same size Date: Mon, 22 Dec 2025 21:20:24 +1300 Message-ID: <20251222082049.1782440-8-jim.cromie@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251222082049.1782440-3-jim.cromie@gmail.com> References: <20251222082049.1782440-3-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Mon, 22 Dec 2025 14:00:06 +0000 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" struct ddebug_class_param keeps a ref to the state-storage of the param; make both class-types use the same unsigned long storage type. ISTM this is simpler and safer; it avoids an irrelevant difference, and if 2 users somehow get class-type mixed up (or refer to the wrong union member), at least they will both see the same value. Reviewed-by: Louis Chauvet Signed-off-by: Jim Cromie --- include/linux/dynamic_debug.h | 2 +- lib/dynamic_debug.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h index 98a36e2f94b6..4b7c3b997657 100644 --- a/include/linux/dynamic_debug.h +++ b/include/linux/dynamic_debug.h @@ -103,7 +103,7 @@ struct _ddebug_info { struct ddebug_class_param { union { unsigned long *bits; - unsigned int *lvl; + unsigned long *lvl; }; char flags[8]; const struct ddebug_class_map *map; diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index cb171088850c..d2ff203d0873 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -810,7 +810,7 @@ int param_get_dyndbg_classes(char *buffer, const struct kernel_param *kp) case DD_CLASS_TYPE_LEVEL_NAMES: case DD_CLASS_TYPE_LEVEL_NUM: - return scnprintf(buffer, PAGE_SIZE, "%d\n", *dcp->lvl); + return scnprintf(buffer, PAGE_SIZE, "%ld\n", *dcp->lvl); default: return -1; } -- 2.52.0