From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B815C88E72 for ; Mon, 26 Jan 2026 08:00:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1E3E310E3B1; Mon, 26 Jan 2026 08:00:52 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Yd1k39qq"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id E1AFE10E3A9; Mon, 26 Jan 2026 08:00:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769414450; x=1800950450; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=H1SudnLOexAkLnmkz1kZcme7no2i0TmUI0Hi1FVtUa0=; b=Yd1k39qqooBq5pkeNja88LsyeIgJ7/LCo15GABMCesJZ2IEayZwtdcCG uMkhZgc77js5nYCDS0xkpmf8Ubwa6D61h+jt8Exe8ZRHwdLubmDxVN7tW xhZycIXTF6vtpZDuh5ta6dNQ70meN1aj1FKWfjajd16p3iEt7gGI4ZAAW J+qrfUWbxQQBvl2OEUdn6v5sIoTiBg7kqg8aVpRhwwi46hmfx8LaMrUxX GTaZSvECYnzSslVd0fmJe2ZHbt8rtNIEHq5Ac9m8LVLmIRzuwr9ZsCPr0 Pe6oAqV4fHFPw6qUhIhbumXunEUdcE5Qam3tMzQYCpQ6GzY9X4/VlmXo8 A==; X-CSE-ConnectionGUID: uWSqrwFjSBWaRXfqet9ddw== X-CSE-MsgGUID: /p42KfaNRxyxzP0V4HvcPA== X-IronPort-AV: E=McAfee;i="6800,10657,11682"; a="70682869" X-IronPort-AV: E=Sophos;i="6.21,254,1763452800"; d="scan'208";a="70682869" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2026 00:00:50 -0800 X-CSE-ConnectionGUID: +JlYpp4HRA2U64FraB13sw== X-CSE-MsgGUID: lSaEP/ctR22PEwZfH2NLxg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,254,1763452800"; d="scan'208";a="207867733" Received: from krybak-mobl1.ger.corp.intel.com (HELO jhogande-mobl3.intel.com) ([10.245.246.56]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2026 00:00:48 -0800 From: =?UTF-8?q?Jouni=20H=C3=B6gander?= To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Cc: =?UTF-8?q?Jouni=20H=C3=B6gander?= Subject: [PATCH v10 10/10] drm/i915/psr: Use TRANS_PUSH to trigger frame change event Date: Mon, 26 Jan 2026 09:59:59 +0200 Message-ID: <20260126075959.925413-11-jouni.hogander@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260126075959.925413-1-jouni.hogander@intel.com> References: <20260126075959.925413-1-jouni.hogander@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Content-Transfer-Encoding: 8bit X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Now we have everything in place for triggering PSR "frame change" event using TRANS_PUSH: use TRANS_PUSH for LunarLake and onwards. v4: - Added call to intel_vrr_psr_frame_change_enable call - added setting LNL_TRANS_PUSH_PSR_PR_EN into intel_vrr_send_push v3: use HAS_PSR_FRAME_CHANGE macro v2: use AND instead of OR in intel_psr_use_trans_push Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 8 ++++++-- drivers/gpu/drm/i915/display/intel_vrr.c | 3 +++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c index 9a4354c6bdda..4e644711c571 100644 --- a/drivers/gpu/drm/i915/display/intel_psr.c +++ b/drivers/gpu/drm/i915/display/intel_psr.c @@ -2125,6 +2125,9 @@ static void intel_psr_enable_source(struct intel_dp *intel_dp, intel_dmc_block_pkgc(display, intel_dp->psr.pipe, true); intel_alpm_configure(intel_dp, crtc_state); + + if (HAS_PSR_TRANS_PUSH_FRAME_CHANGE(display)) + intel_vrr_psr_frame_change_enable(crtc_state); } static bool psr_interrupt_error_check(struct intel_dp *intel_dp) @@ -4569,6 +4572,7 @@ int intel_psr_min_guardband(struct intel_crtc_state *crtc_state) bool intel_psr_use_trans_push(const struct intel_crtc_state *crtc_state) { - /* TODO: Enable using trans push when everything is in place */ - return false; + struct intel_display *display = to_intel_display(crtc_state); + + return HAS_PSR_TRANS_PUSH_FRAME_CHANGE(display) && crtc_state->has_psr; } diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c index 8a072f90049f..9d814cc2d608 100644 --- a/drivers/gpu/drm/i915/display/intel_vrr.c +++ b/drivers/gpu/drm/i915/display/intel_vrr.c @@ -689,6 +689,9 @@ static u32 trans_vrr_push(const struct intel_crtc_state *crtc_state, if (send_push) trans_vrr_push |= TRANS_PUSH_SEND; + if (HAS_PSR_TRANS_PUSH_FRAME_CHANGE(display)) + trans_vrr_push |= LNL_TRANS_PUSH_PSR_PR_EN; + return trans_vrr_push; } -- 2.43.0