From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD553EE20AB for ; Fri, 6 Feb 2026 14:05:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C78A010E7B3; Fri, 6 Feb 2026 14:05:14 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="IauM6qxA"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9FD0610E7AE; Fri, 6 Feb 2026 14:05:12 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id C4FEA6001A; Fri, 6 Feb 2026 14:05:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EEEE2C116C6; Fri, 6 Feb 2026 14:05:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770386711; bh=TaPvEsWxvpYYOThGeX1+fx1sD+0RPf/kwBUPBJTjDY4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IauM6qxASUz/Fo2EiCWex3fCTVey671ArIsYwK+3iWyqrXjBxzIIu0605avahH/xr bSczKKlSeMkMSaXRdtdNAm4UwaNkQISaJ4zChYTk8plrSLGlCORmAIB3y7aPZDe4W3 OMLxLp8FrcOjYrrUT+1D4xG/ZcuP8aTy+c8DrQT5CEluNQJ8y+by7nO9V4JKFd8kDf gUyBwVFXjeV1lcwrd19xHwLadFcEVKvrpaQx8sJ5EyzqWQJtC6tjjnUlX2y38QsmVO NavvJ2C/rmXxkBKX2/nuo7Rir0p9ae99WqUXRqq6JjEHoeddDS8lKaqWyY5NfewNXW EeLaCc7mQMLFw== Date: Fri, 6 Feb 2026 15:05:08 +0100 From: Maxime Ripard To: Nicolas Frattaroli Cc: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?utf-8?B?S8O2bmln?= , David Airlie , Simona Vetter , Maarten Lankhorst , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sandy Huang , Heiko =?utf-8?Q?St=C3=BCbner?= , Andy Yan , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Dmitry Baryshkov , Sascha Hauer , Rob Herring , Jonathan Corbet , kernel@collabora.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-doc@vger.kernel.org, Andri Yngvason , Werner Sembach , Marius Vlad Subject: Re: [PATCH v7 02/22] drm: Add new general DRM property "color format" Message-ID: <20260206-deft-provocative-perch-6ca9bf@houat> References: <20260121-color-format-v7-0-ef790dae780c@collabora.com> <20260121-color-format-v7-2-ef790dae780c@collabora.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha384; protocol="application/pgp-signature"; boundary="tlakrgvje6y2sbf2" Content-Disposition: inline In-Reply-To: <20260121-color-format-v7-2-ef790dae780c@collabora.com> X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" --tlakrgvje6y2sbf2 Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v7 02/22] drm: Add new general DRM property "color format" MIME-Version: 1.0 Hi, On Wed, Jan 21, 2026 at 03:45:09PM +0100, Nicolas Frattaroli wrote: > diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h > index 7eaec37ae1c7..b5604dca728a 100644 > --- a/include/drm/drm_connector.h > +++ b/include/drm/drm_connector.h > @@ -556,6 +556,16 @@ enum drm_colorspace { > DRM_MODE_COLORIMETRY_COUNT > }; > =20 > +enum drm_color_format { > + DRM_COLOR_FORMAT_AUTO =3D 0, > + DRM_COLOR_FORMAT_RGB444 =3D BIT(0), > + DRM_COLOR_FORMAT_YCBCR444 =3D BIT(1), > + DRM_COLOR_FORMAT_YCBCR422 =3D BIT(2), > + DRM_COLOR_FORMAT_YCBCR420 =3D BIT(3), > +}; > + > +#define DRM_COLOR_FORMAT_COUNT 5 > + I don't really see a reason to expose an enum, with a bunch of values that are all mutually exclusive, as a bitmask. It's pretty inconsistent with most (all?) the other similar properties we have. I appreciate you did that to avoid fixing up every driver using those values, but then maybe we don't have to? We could create a userspace facing enum, and convert to DRM_COLOR_FORMAT internally. Maxime --tlakrgvje6y2sbf2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCaYX1EAAKCRAnX84Zoj2+ dm20AYC5qAkdhJdQsWaSZelEFrrJKVRqs5zBtYWPBOAMRObg77mefUoSO3ktgK9d TYXfpzUBgPXlGrYnILXs7XVYlFu//eO6ufmogZ3qIYuVKGT1yKooE8WKx/MfpzM3 iY+f6mFzuA== =GGG7 -----END PGP SIGNATURE----- --tlakrgvje6y2sbf2--