From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C116F3ED5B for ; Sat, 11 Apr 2026 17:46:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2C73B10E27F; Sat, 11 Apr 2026 17:46:24 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="WVW5iI3Z"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id F41BD10E22A for ; Sat, 11 Apr 2026 17:46:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1775929583; x=1807465583; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=dqz3hPpzjoANPopizhJzjh1VbQ54aVk7OitCStCKjNk=; b=WVW5iI3Z8hvsnnzt0GNsMmrpcctLKXt0hdWttZ0RF1B9kkTAtRtqzU0q IU42emrFoax1minHGqbFyp48Y1g5EzRefMTbNSgKw+hiqtKJGQ90qczBu /RChg1TYIZzQTT2+o2xxMbqCJgKee0g+DWRwuxKe/ucHoY0Eus0uwlMdd fIQKOHJbRVQ9QXJ0uzptajfvuHwxfWsd0Ijjbb1Gs5NmzKU9vX7d7va+Q Uk2dbVgOfZvy0YEIzolQgklYjYIl3Xkj9Cfg2dteJteY/2HtjlsjwCIva 1pX6Dad/tQJPN3J6VbhDiBwWIdYWDqtf1ZazLJZgbCr+/afbs9W/1zfbe A==; X-CSE-ConnectionGUID: bY+6WkiqREu5ohbxdKEPKg== X-CSE-MsgGUID: w6w2gB0ORcamE0J7iR2nHQ== X-IronPort-AV: E=McAfee;i="6800,10657,11755"; a="99564236" X-IronPort-AV: E=Sophos;i="6.23,173,1770624000"; d="scan'208";a="99564236" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2026 10:46:23 -0700 X-CSE-ConnectionGUID: pEoW/RoBTByMRmXZwwIWRA== X-CSE-MsgGUID: T96wJkPqT32KyPaG1kUgUg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,173,1770624000"; d="scan'208";a="222899885" Received: from administrator-system-product-name.igk.intel.com (HELO dev-417.igk.intel.com) ([10.91.214.181]) by fmviesa009.fm.intel.com with ESMTP; 11 Apr 2026 10:46:21 -0700 From: =?UTF-8?q?Micha=C5=82=20Grzelak?= To: intel-gfx@lists.freedesktop.org Cc: =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= , Nemesa Garg , =?UTF-8?q?Micha=C5=82=20Grzelak?= Subject: [PATCH v2 08/10] drm/i915/scaler: invert loop's breaking logic Date: Sat, 11 Apr 2026 19:45:24 +0200 Message-ID: <20260411174526.2850179-9-michal.grzelak@intel.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20260411174526.2850179-1-michal.grzelak@intel.com> References: <20260411174526.2850179-1-michal.grzelak@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316 Content-Transfer-Encoding: 8bit X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" skl_scaler_get_config()'s loop is skipped when specified condition is met and broken when the condition is not met. Equivalently, invert the condition and break the loop. Cc: Nemesa Garg Suggested-by: Ville Syrjälä Signed-off-by: Michał Grzelak --- drivers/gpu/drm/i915/display/skl_scaler.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/skl_scaler.c b/drivers/gpu/drm/i915/display/skl_scaler.c index e71d9c036a1e7..4e2f4c4ffc45a 100644 --- a/drivers/gpu/drm/i915/display/skl_scaler.c +++ b/drivers/gpu/drm/i915/display/skl_scaler.c @@ -958,10 +958,8 @@ void skl_scaler_get_config(struct intel_crtc_state *crtc_state) u32 ctl; ctl = intel_de_read(display, SKL_PS_CTRL(crtc->pipe, scaler_id)); - if ((ctl & (PS_SCALER_EN | PS_BINDING_MASK)) != (PS_SCALER_EN | PS_BINDING_PIPE)) - continue; - - break; + if ((ctl & (PS_SCALER_EN | PS_BINDING_MASK)) == (PS_SCALER_EN | PS_BINDING_PIPE)) + break; } if (scaler_id == crtc->num_scalers) -- 2.45.2