Re: [PATCH v11 02/20] gpu: nova-core: gsp: Extract usable FB region from GSP

John Hubbard
2026-04-21T21:41:51Z

On 4/21/26 1:05 PM, David Airlie wrote:
...
>>>> + usable_fb_region: msg.first_usable_fb_region().ok_or(ENODEV)?,
>>>
>>> OK, failing out is correct here. But in addition, we should also
>>> log this at dev_err!() level. This is rare, surprising, and actionable,
>>> so perfect for that level of logging.
>>
>> Sure, that works for me. Will add it in for v12.
>
> Just fyi when we get to spark later this will not matter, we will have
> no usable_fb_region, though maybe it could just return 0s in that
> case.
>

Hi Dave,

The "no FB on this SKU" is a separate case, at least as I recall from
specifically looking into that during the patch review. We already have
cases like that (in Open RM) and those are not error cases.

This one here is a real error, though: "expected an FB and got nothing
useful".

thanks,
--
John Hubbard