Re: Regression on linux-next (next-20260324 )

Peter Zijlstra
2026-04-21T15:03:11Z

On Tue, Apr 21, 2026 at 03:45:02PM +0100, Matthew Wilcox wrote:
> On Tue, Apr 21, 2026 at 04:37:52PM +0200, Peter Zijlstra wrote:
> > Argh, I see... yes. Perhaps something like the below though?
>
> This is a documentation bug. I thought it was supposed to add *after*
> pos, not before. So can we clear that up too?

Sure, that comment is indeed less than clear. The comment in
__ww_mutex_add_waiter() is better.

>
> @@ -198,7 +198,7 @@ static inline void __mutex_clear_flag(struct mutex *lock, unsigned long flag)
> }
>
> /*
> - * Add @waiter to a given location in the lock wait_list and set the
> + * Add @waiter before a given location in the lock wait_list and set the
> * FLAG_WAITERS flag if it's the first waiter.
> */
> static void
>