From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E197EFC0379 for ; Fri, 24 Apr 2026 12:37:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1C77010F571; Fri, 24 Apr 2026 12:37:12 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="gmyJUbUZ"; dkim-atps=neutral Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) by gabe.freedesktop.org (Postfix) with ESMTPS id E3D8310F28B for ; Thu, 23 Apr 2026 20:54:48 +0000 (UTC) Received: by mail-oi1-f176.google.com with SMTP id 5614622812f47-479fc1fc048so1991862b6e.1 for ; Thu, 23 Apr 2026 13:54:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776977688; x=1777582488; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=zftWqWhtfgLT8BdUHmflQKmCQdRaRDCFv8UXc0/NgE8=; b=gmyJUbUZM1sTfnL3f/Tej9de2EkdSaYq2AZHYJ6Hb/Jk51sEFLEjGywHDm+lEIliRA CGNufzx2taZ//1FjY1L8/4rFvZssU7PychcbW0J4NDVeYHN0eNV2xxibBm72XPwjP8oF SMrETNpoQ/eiOkPeu0cujciEBKiSoOGk3TlwvveaiOdgXlIM8Y9cSCatjUxRtTgkD18V U3AWkQ0Hnp2dFgT81qJK5lbPl6Z/FU3OZwaQZyWlPAewbV85bGLbmwWHlcf3zdRqWlG1 3+QtGnrVc6Ab0RRzh2sVdJ4amN1Pcq3W2n6Kc0NjLxEzSYhudfNQTGdoZWsghXKYePxs 6B6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776977688; x=1777582488; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=zftWqWhtfgLT8BdUHmflQKmCQdRaRDCFv8UXc0/NgE8=; b=NVaYtN6LR62MilLZ0sJpNZFuVsTZ5EicRNPSiNOVa95QPDXGgagtYB/e8z/mqnvSFQ 9owocohb4y0CHP7QN+EuqSusCjUREfxjVm7Zr36M6gwx1VfZDju6pRzmiDnZOqZFknm5 Z8UotBN+pwkwbh2N/LmCeFUe8bjpLoy4toS3k37c2R5k9XcqoTSCs+SlKzEjDdR5Bp2y zy9YlMiqmcbcBe95G/A/RlKMhXMWOtohqGHz1J8jGwVu3LY8HR8QLp7RAKPKF8nvrQyS XoYIzGYFkAJuX4F/Ygpt0xbZ+5/yDXGjQN4mWVDycKo2PCZJHKo5h87Eo1NtBLwimbDu h35Q== X-Forwarded-Encrypted: i=1; AFNElJ8mZc2TCwIM+x5figo/NXZe3i1vLR8DTsAtzh99rjv9GRQzva/w6svIWHGgXFj1GgH3OTo9hulzP6U=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yw0RHtA5qBdjdetVnC5LP3/LvzsGHwsK5jL+bsV6Dmw+Rkfy0w9 3M3DntdxQ3scX2jDajpNcntzOXstE9E2fAA501Ba1qex69voq6mFkdHV X-Gm-Gg: AeBDiethpuLk3kaIml4FzgQeUU5FLMJtNR4P79esnv/0nwJ/sUTWrC0UC0T267kL3Vs GygzGWvpn4R0WRM/IJOmzYq/ShbwMwIZs29BeS1+/17tp8OgZSZbH9CIOJ/TJhQTpa0lR29AvyI 1hR/PA87b/qm9Z5tv62Kz/XjC7+0DoXVUMy5a2wM2w9/uiRoPFWj2xa+rsogJy7lxz6vpVW6K16 8axXw+SDkXK2MHkKjUsGTAiKrSzgl/fCJwGwI2hMeeBi7LWsBKg6kg6aK06jnalOqm7slbkqBnB vHto4ORgBm07dVOaYNa+AqFto/dR1AhdpbAVs93OboeOfVEmGCxhWDehslMB8fpsttY/2V16IhN yWH+TK4zDj07N6drAW2lilirLaRatd4IomFSdil27YDuxURnGct+DcpqLBDss3g+CZ4nPx8zk/k y0I2ssvvcQUBRHuaFdgd2Hr9PLzEhaoI4pdAqm9l/bBbkNsqN5fII1ROL4e8JBNfVeXxkDVTzo X-Received: by 2002:a05:6808:1384:b0:467:2926:1231 with SMTP id 5614622812f47-4799cabb091mr15541122b6e.33.1776977687962; Thu, 23 Apr 2026 13:54:47 -0700 (PDT) Received: from [192.168.0.245] (c-98-38-17-99.hsd1.co.comcast.net. [98.38.17.99]) by smtp.googlemail.com with ESMTPSA id 5614622812f47-4799fead505sm14329744b6e.2.2026.04.23.13.54.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 13:54:47 -0700 (PDT) From: Jim Cromie Date: Thu, 23 Apr 2026 14:53:50 -0600 Subject: [PATCH v14 09/92] test-dyndbg: fixup CLASSMAP usage error MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260423-submit-dyndbg-classmap-foundation-v14-9-2b809a8019d0@gmail.com> References: <20260423-submit-dyndbg-classmap-foundation-v14-0-2b809a8019d0@gmail.com> In-Reply-To: <20260423-submit-dyndbg-classmap-foundation-v14-0-2b809a8019d0@gmail.com> To: Arnd Bergmann , Jason Baron , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Andrew Morton , Jonathan Corbet , Shuah Khan , Shuah Khan , Greg Kroah-Hartman , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Matthew Brost , =?utf-8?q?Thomas_Hellstr=C3=B6m?= , Lyude Paul , Danilo Krummrich , Patrik Jakobsson , Zack Rusin , Broadcom internal kernel review list , Louis Chauvet , Haneen Mohammed , Melissa Wen , Sean Paul , Jocelyn Falempe , Ruben Wauters , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , Xinliang Liu , Tian Tao , Xinwei Kong , Sumit Semwal , Yongqin Liu , John Stultz , Philipp Zabel , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Matthias Brugger , AngeloGioacchino Del Regno , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Alain Volmat , Raphael Gallais-Pou , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Oded Gabbay , Maciej Falkowski , Karol Wachowski , "Rob Herring (Arm)" , Tomeu Vizoso , Liviu Dudau , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Liu Ying , Laurentiu Palcu , Lucas Stach , Paul Kocialkowski , Jianmin Lv , Qianhai Wu , Huacai Chen , Mingcong Bai , Xi Ruoyao , Icenowy Zheng , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Javier Martinez Canillas , Huang Rui , Matthew Auld , Jani Nikula , Luca Coelho , Russell King , Christian Gmeiner Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, nouveau@lists.freedesktop.org, spice-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-renesas-soc@vger.kernel.org, etnaviv@lists.freedesktop.org, Jim Cromie X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776977636; l=1492; i=jim.cromie@gmail.com; s=20260203; h=from:subject:message-id; bh=v7nXtN9RgqHdJNPNJFFsg1eD6gNLpxPo8kGjLNQhYDo=; b=VBe9Ut7lbIIOEurwbAbNeQYJD7LG7Pt57wkJQXnWBJg9CpLMfTuVjx/oiKOPJeZDCdXsgXfoN q302jYDv/rXD00pgA4KJloRhJnDOj+7pbSDUehOIPs/xW+brF00GdRj X-Developer-Key: i=jim.cromie@gmail.com; a=ed25519; pk=C6E5ODlPQo7ZBynATXH9wg7K6HxP0pIXyf4s38Qw0XE= X-Mailman-Approved-At: Fri, 24 Apr 2026 12:37:08 +0000 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" commit 6ea3bf466ac6 ("dyndbg: test DECLARE_DYNDBG_CLASSMAP, sysfs nodes") A closer look at test_dynamic_debug.ko logging output reveals a macro usage error: lib/test_dynamic_debug.c:105 [test_dynamic_debug]do_cats =p "LOW msg\n" class:MID lib/test_dynamic_debug.c:106 [test_dynamic_debug]do_cats =p "MID msg\n" class:HI lib/test_dynamic_debug.c:107 [test_dynamic_debug]do_cats =_ "HI msg\n" class unknown, _id:13 107 says: HI is unknown, and 105,106 have a LOW/MID and MID/HI skew. DECLARE_DYNDBG_CLASSMAP() _base arg must equal the enum's 1st value, in this case it was _base + 1. This leaves HI class un-selectable. NB: the macro could better validate its arguments. Reviewed-by: Louis Chauvet Tested-by: Louis Chauvet Signed-off-by: Jim Cromie --- lib/test_dynamic_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/test_dynamic_debug.c b/lib/test_dynamic_debug.c index 77c2a669b6af..396144cf351b 100644 --- a/lib/test_dynamic_debug.c +++ b/lib/test_dynamic_debug.c @@ -75,7 +75,7 @@ DD_SYS_WRAP(disjoint_bits, p); DD_SYS_WRAP(disjoint_bits, T); /* symbolic input, independent bits */ -enum cat_disjoint_names { LOW = 11, MID, HI }; +enum cat_disjoint_names { LOW = 10, MID, HI }; DECLARE_DYNDBG_CLASSMAP(map_disjoint_names, DD_CLASS_TYPE_DISJOINT_NAMES, 10, "LOW", "MID", "HI"); DD_SYS_WRAP(disjoint_names, p); -- 2.53.0