From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7ADD1CD6E6B for ; Wed, 3 Jun 2026 11:12:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F130410FC1A; Wed, 3 Jun 2026 11:12:45 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="T80GQYe3"; dkim-atps=neutral Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4486610F0B5 for ; Tue, 2 Jun 2026 13:04:57 +0000 (UTC) Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4906238c62eso93031285e9.3 for ; Tue, 02 Jun 2026 06:04:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780405496; x=1781010296; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=H/8nMdqnIqVIuE86ZCCEmz0EQ1iXOszPXfKX9VZoGH4=; b=T80GQYe3ZaG9+evHP+nQY2CKwK0R+Iq0ktCR1qwPhJtRKFUK/Nt01WBkgmSEr62OGy UNbVhHTpLRE1NnhfpXsFLRZvjLfW2FWVyK4axw2xzxKZcdN2NxNohV23Tl8M7YkqfgDZ A3nmU5DUjegLHp5lmqHpL9NLNHgLG9XiesgWvzhxWuzp96spiqDovABNtVl7MUNVWQmT mxTWU1T8ugHuMIm/nU5cBp7H6Mfn9G04UhdGCOfSP/xTCepMDUCB5ogep9dKA7iQe683 ZImY+EPM/Nklbb//QOuCRNz08PXU6rCqeoUSM2vKhRSEAE9tbrDaysDZDCUeLAcMD9zD 074g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780405496; x=1781010296; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=H/8nMdqnIqVIuE86ZCCEmz0EQ1iXOszPXfKX9VZoGH4=; b=WjqkF/xLcYifVnB3aer4xBRpEBF6NFvKGW89p0gzfnOhFKJE+uy2Se3sgoPjS7C+cZ v1VVivCux4zUtG8nzD1nfDKlByomoE2F/QPaPaHv5EyAVD8/9iMKw+Jkzndqf3K4nSHT rRk4t5V228XT4R4nTpyLFhVsUdrnI365n4pSD/mzzh22H5phjG0w4etwcvrkEW6tRD9V 7cgoxD5+zNW9ZOCQsa24b5a9MEtp/MDrjZI5ruKjWcvXOPdwW76xFZthIdZfkmr/2AuG jO22gAntNVG1VMdLOB0ctnqNfcNi7lVwAR6/1+C4nFxwX8kQmSb4mWqY+czjqMAT7DHA itbg== X-Forwarded-Encrypted: i=1; AFNElJ9hEq9Co4MluLDEmQVt9xJ/dvhJeB7BNoaIMbthkE2vQ7r68OdYCO2JRSJbRi/kpOJGspt6e0t3ZI8=@lists.freedesktop.org X-Gm-Message-State: AOJu0YyD9q9UPapfTsltv/2n9GjKWbNdjM5koYdXjuqUUk6mXmq+CfvZ XQ2jSskJrh5ICBQ3PxErE7mTe5EdIh0rZ3crg9AX35dJzyux2ksRzvG5 X-Gm-Gg: Acq92OFA0Bd4nMYLtlJuFQZtw4wbmZgd6ASf5d4svJzUZxoAtCQuE5WSWcia1KokzdV +DuOboEkw5eH5DA0kN6/fBwvNr+2JQ16OH3twOChkoFke5GXxSIOhj6W17GnGnZaG3zYAnrXW2L sORIld4e7cxYUkUwJ70Af5TahWGBP/8UH66NgC4trS94cF79K1C0n+hUNoUFxTbwPj1E2foRtyI hQzBQiuWl5NUZnAlqd6RcY5JOiJNMYgA2Zs4oUBRqqLMV9F7c15abkHGENtnaGw2Ailm2QAm0pd dKCYzoREuC8cJq0AYQehFL6WOLg30cGNvPI19mQplB3QwOdujnaR22MZyh7U28DYdQspqQT926R QBp/jVggLlyTbeb6YGlpzwywW/aOs3bMDxDGmhLA67Fc1we2lMAKjg/B40RCIIYBkSPAQmytxzG zfI9RPoKpOtJfVceuPW4cc0WwMIfcmic0/k29AW5W3UT368Ydi2fa8ET6bNvmccZYCAEqvRzW8T S2yWRd2/w== X-Received: by 2002:a05:600c:8105:b0:490:b072:1be6 with SMTP id 5b1f17b1804b1-490b0721e0amr76565325e9.25.1780405495119; Tue, 02 Jun 2026 06:04:55 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45ef34b834esm33184301f8f.11.2026.06.02.06.04.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 06:04:54 -0700 (PDT) Date: Tue, 2 Jun 2026 14:04:51 +0100 From: David Laight To: Andy Shevchenko Cc: Kees Cook , Luis Chamberlain , Pengpeng Hou , stable@vger.kernel.org, Petr Pavlu , Richard Weinberger , Anton Ivanov , Johannes Berg , "Rafael J. Wysocki" , Len Brown , Corey Minyard , Gabriel Somlo , "Michael S. Tsirkin" , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Bart Van Assche , Jason Gunthorpe , Leon Romanovsky , Laurent Pinchart , Hans de Goede , Mauro Carvalho Chehab , Bjorn Helgaas , Hannes Reinecke , "James E.J. Bottomley" , "Martin K. Petersen" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Greg Kroah-Hartman , Jiri Slaby , Alan Stern , Jason Wang , Xuan Zhuo , Eugenio =?UTF-8?B?UMOpcmV6?= , Jason Baron , Jim Cromie , Tiwei Bie , Benjamin Berg , Ilpo =?UTF-8?B?SsOkcnZpbmVu?= , "David E. Box" , "Maciej W. Rozycki" , Srinivas Pandruvada , Peter Zijlstra , Heiko Carstens , Vasily Gorbik , Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vinod Koul , Frank Li , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Alexander Potapenko , Marco Elver , Dmitry Vyukov , Andrew Morton , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Georgia Garcia , kvm@vger.kernel.org, dmaengine@vger.kernel.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-um@lists.infradead.org, linux-acpi@vger.kernel.org, openipmi-developer@lists.sourceforge.net, qemu-devel@nongnu.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 01/11] params: bound array element output to the caller's page buffer Message-ID: <20260602140451.2e3e6622@pumpkin> In-Reply-To: References: <20260521133315.work.845-kees@kernel.org> <20260521133326.2465264-1-kees@kernel.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Wed, 03 Jun 2026 11:12:41 +0000 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 2 Jun 2026 14:26:46 +0300 Andy Shevchenko wrote: > On Thu, May 21, 2026 at 06:33:14AM -0700, Kees Cook wrote: > > > > param_array_get() appends each element's string representation into the > > shared sysfs page buffer by passing buffer + off to the element getter. > > > > That works for getters that only write a small bounded string, but > > param_get_charp() and similar helpers format against PAGE_SIZE from the > > pointer they receive. Once off is non-zero, an element getter can > > therefore write past the end of the original sysfs page buffer. > > > > Collect each element into a temporary PAGE_SIZE buffer first and then > > copy only the remaining space into the caller's page buffer. > > ... > > > + elem_buf = kmalloc(PAGE_SIZE, GFP_KERNEL); > > get_free_page() (or how it is called)? The kmalloc() should be faster and I think has to be aligned. There is another patch set to replace get_free_pages() with kmalloc(). Although all these 'show' functions should really head to using a safer interface. Although, at the moment, it is really difficult to find the ones that are guaranteed to be passed a page aligned buffer. -- David > > > + if (!elem_buf) > > + return -ENOMEM; > > + > > for (i = off = 0; i < (arr->num ? *arr->num : arr->max); i++) { > > - /* Replace \n with comma */ > > - if (i) > > - buffer[off - 1] = ','; > > p.arg = arr->elem + arr->elemsize * i; > > check_kparam_locked(p.mod); > > - ret = arr->ops->get(buffer + off, &p); > > + ret = arr->ops->get(elem_buf, &p); > > if (ret < 0) > > - return ret; > > + goto out; > > + ret = min(ret, (int)(PAGE_SIZE - 1 - off)); > > It's usually discouraged to use castings in min/max/clamp. Can we make ret long > or do something different here? > > > + if (!ret) > > + break; > > > + /* Replace the previous element's trailing newline with a comma. */ > > + if (i) > > + buffer[off - 1] = ','; > > Can't we do this after with help of strreplace()? > > > + memcpy(buffer + off, elem_buf, ret); > > off += ret; > > + if (off == PAGE_SIZE - 1) > > + break; > > } > > buffer[off] = '\0'; > > - return off; > > + ret = off; > > +out: > > + kfree(elem_buf); > > + return ret; >