From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A13C6CD8C81 for ; Fri, 5 Jun 2026 16:04:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3CEDF10E50C; Fri, 5 Jun 2026 16:04:51 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="n7MsUInZ"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 94A3D10E4EB; Fri, 5 Jun 2026 16:04:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780675490; x=1812211490; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=uOvb9FNQLLPSkmOurOFMCczNwFq9mOmfW/UG5EL+xzw=; b=n7MsUInZIgBZae7VjKuVsVuBRF+9K7rb0cUScCe4p7MXIGNuXBxmfRON JFbC/ukMl7zm+SR1IzoZH0Wmqfxm6x2Ya5xFS0Mzth0e229d8G2JRdSjc AEYsf+Cr1gGCvRoSVKT4CsuEPB1hzVRS6p2sVJROo10jMaj1GTTisMQg7 eKdpqaMERoXDtzpDNWCSmgFbV+06ouI0UNqLK7Z/GEHgIwvSw5BeaUwIB IMoXRoTHiR/P0lTE1kpbR2UIzoiJ/ZWDWaB0besjFERtC8pzkhTO7bSi4 4jVGhTCmgr7LfFr/g9IMGcOwGiD478N+zfXOFdl+sj1AsHx7YQYr1hMHz Q==; X-CSE-ConnectionGUID: BsBsBcdVQTSzErFfh6MEUA== X-CSE-MsgGUID: mUKGeFXTRDK0ixP9bzCDNQ== X-IronPort-AV: E=McAfee;i="6800,10657,11808"; a="98928767" X-IronPort-AV: E=Sophos;i="6.24,189,1774335600"; d="scan'208";a="98928767" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2026 09:04:50 -0700 X-CSE-ConnectionGUID: Sfnv4seDTPauk0RtzUg0qQ== X-CSE-MsgGUID: 0WirT43YSkmlzXx2fnqICw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,189,1774335600"; d="scan'208";a="268566301" Received: from osgc-sh-dragon.sh.intel.com ([10.239.81.44]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2026 09:04:47 -0700 From: Jonathan Cavitt To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Cc: saurabhg.gupta@intel.com, alex.zuo@intel.com, jonathan.cavitt@intel.com, raag.jadav@intel.com Subject: [PATCH 0/5] drm/{i915, xe}: Refactor generic_handle_irq_safe() error messages Date: Sat, 6 Jun 2026 00:04:39 +0800 Message-ID: <20260605160444.3833295-1-jonathan.cavitt@intel.com> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Currently, all but one uses of generic_handle_irq_safe() report error messages using .*_err_ratelimited() error reporting helper functions. These helper functions declare their error messages in the following form: "error handling [COMPONENT NAME] irq: %d\n" .*_err_ratelimited() already logs "error" as a part of the error message, so declaring the error is redundant. Reword it. The last usage of generic_handle_irq_safe() is in xe_i2c_irq_present(), and it currently lacks the same error reporting as in the other cases. This is not intentional, so put some logging there. While we're here, we should also update the XE cases to use xe_err_ratelimited() instead of directly calling drm_err_ratelimited(). However, mixing drm error reporting functions with xe error reporting functions in the same file looks unprofessional, so update all drm error reporting functions in xe_heci_gsc.c and xe_i2c.c to use their xe counterparts. This includes updating drm_warn_once() to use xe_warn_once() instead. Unfortunately, xe_warn_once() does not exist, so create it. Jonathan Cavitt (5): drm/xe/printk: Add xe_warn_once() drm/xe/heci: Use xe print functions in xe_heci_gsc.c drm/xe/i2c: Use xe print functions in xe_i2c.c drm/{i915, xe}: Refactor generic_handle_irq_safe() error messages drm/xe/i2c: Report i2c irq handler issue .../gpu/drm/i915/display/intel_lpe_audio.c | 2 +- drivers/gpu/drm/i915/gt/intel_gsc.c | 2 +- drivers/gpu/drm/xe/xe_heci_gsc.c | 21 +++++++++---------- drivers/gpu/drm/xe/xe_i2c.c | 11 ++++++---- drivers/gpu/drm/xe/xe_printk.h | 3 +++ 5 files changed, 22 insertions(+), 17 deletions(-) -- 2.53.0