From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40FF4CD6E7E for ; Fri, 5 Jun 2026 21:05:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C2703112C25; Fri, 5 Jun 2026 21:05:45 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="c/nwi+Sg"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id C5367112C20; Fri, 5 Jun 2026 21:05:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780693544; x=1812229544; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=DFwEbM0UdJfjkt5Es8i/CqBZMVoUCNpKhD3XKMVNcVg=; b=c/nwi+SgxKA2czKBT3ER29+H0X0uwTod/RRnrG5YU023BDTb6jHMUww6 V60Qbkhg5V8OGWDYxgaC1kJGLEUgIxjtRyCFi7RrbTXlAgihJUMebpz5k d5wADNIeCI4K/Lz9Dmea960pCDNQbQdsVnMFpKemLNLZFu8kj32a6pjJY CdAz6NCIJH2yovconT//MNjAdxYZSz7u2iim4Yc3CMTvqekWd66YL6/Af Jmx1G21l7qpX+535SSq47DovCfnNMpyfDn4VdqHRXT24U7CtNBFwsWraY Mv+bgPc545Sqc8rJWJLqZS5t2i7xOsWjkEm1X+yt9Sps6cRCyON1OnHui g==; X-CSE-ConnectionGUID: GbO/BVz0TRSCkmGE3nQsOw== X-CSE-MsgGUID: w9st8erqRLGrNfA4BR5c/w== X-IronPort-AV: E=McAfee;i="6800,10657,11808"; a="69064558" X-IronPort-AV: E=Sophos;i="6.24,189,1774335600"; d="scan'208";a="69064558" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2026 14:05:44 -0700 X-CSE-ConnectionGUID: d1vc0PYqTeajLbpurvZcHg== X-CSE-MsgGUID: MNcRrN64RhWzYJ5Fbw8T0A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,189,1774335600"; d="scan'208";a="244994697" Received: from osgc-sh-dragon.sh.intel.com ([10.239.81.44]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2026 14:05:42 -0700 From: Jonathan Cavitt To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: saurabhg.gupta@intel.com, alex.zuo@intel.com, jonathan.cavitt@intel.com, raag.jadav@intel.com, Michal.Wajdeczko@intel.com Subject: [PATCH v3 2/5] drm/xe/heci: Use xe print functions in xe_heci_gsc.c Date: Sat, 6 Jun 2026 05:05:31 +0800 Message-ID: <20260605210534.3843211-3-jonathan.cavitt@intel.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260605210534.3843211-1-jonathan.cavitt@intel.com> References: <20260605210534.3843211-1-jonathan.cavitt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Update xe_heci_gsc.c to use the xe error reporting helper functions in xe_printk.h instead of directly calling the associated drm print functions from drm_print.h. While we're here, we should update the error messages to print the error codes in a more friendly way. v2: - Update the error messages to print the error codes in a more friendly way (Wajdeczko) Signed-off-by: Jonathan Cavitt Cc: Michal Wajdeczko --- drivers/gpu/drm/xe/xe_heci_gsc.c | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_heci_gsc.c b/drivers/gpu/drm/xe/xe_heci_gsc.c index 5af8903e10af..13123990c4e2 100644 --- a/drivers/gpu/drm/xe/xe_heci_gsc.c +++ b/drivers/gpu/drm/xe/xe_heci_gsc.c @@ -8,12 +8,11 @@ #include #include -#include - #include "xe_device_types.h" #include "xe_heci_gsc.h" #include "regs/xe_gsc_regs.h" #include "xe_platform_types.h" +#include "xe_printk.h" #include "xe_survivability_mode.h" #define GSC_BAR_LENGTH 0x00000FFC @@ -112,13 +111,13 @@ static int heci_gsc_irq_setup(struct xe_device *xe) heci_gsc->irq = irq_alloc_desc(0); if (heci_gsc->irq < 0) { - drm_err(&xe->drm, "gsc irq error %d\n", heci_gsc->irq); + xe_err(xe, "GSC: irq allocation failed (%pe)\n", ERR_PTR(heci_gsc->irq)); return heci_gsc->irq; } ret = heci_gsc_irq_init(heci_gsc->irq); if (ret < 0) - drm_err(&xe->drm, "gsc irq init failed %d\n", ret); + xe_err(xe, "GSC: irq initialization failed (%pe)\n", ERR_PTR(ret)); return ret; } @@ -151,7 +150,7 @@ static int heci_gsc_add_device(struct xe_device *xe, const struct heci_gsc_def * ret = auxiliary_device_init(aux_dev); if (ret < 0) { - drm_err(&xe->drm, "gsc aux init failed %d\n", ret); + xe_err(xe, "gsc aux init failed %d\n", ret); kfree(adev); return ret; } @@ -159,7 +158,7 @@ static int heci_gsc_add_device(struct xe_device *xe, const struct heci_gsc_def * heci_gsc->adev = adev; /* needed by the notifier */ ret = auxiliary_device_add(aux_dev); if (ret < 0) { - drm_err(&xe->drm, "gsc aux add failed %d\n", ret); + xe_err(xe, "gsc aux add failed %d\n", ret); heci_gsc->adev = NULL; /* adev will be freed with the put_device() and .release sequence */ @@ -190,7 +189,7 @@ int xe_heci_gsc_init(struct xe_device *xe) } if (!def || !def->name) { - drm_warn(&xe->drm, "HECI is not implemented!\n"); + xe_warn(xe, "HECI is not implemented!\n"); return 0; } @@ -215,7 +214,7 @@ void xe_heci_gsc_irq_handler(struct xe_device *xe, u32 iir) return; if (!xe->info.has_heci_gscfi) { - drm_warn_once(&xe->drm, "GSC irq: not supported"); + xe_warn_once(xe, "GSC: unexpected irq %#x\n", iir); return; } @@ -224,7 +223,7 @@ void xe_heci_gsc_irq_handler(struct xe_device *xe, u32 iir) ret = generic_handle_irq_safe(xe->heci_gsc.irq); if (ret) - drm_err_ratelimited(&xe->drm, "error handling GSC irq: %d\n", ret); + xe_err_ratelimited(xe, "GSC: irq handling failed (%pe)\n", ERR_PTR(ret)); } void xe_heci_csc_irq_handler(struct xe_device *xe, u32 iir) @@ -235,7 +234,7 @@ void xe_heci_csc_irq_handler(struct xe_device *xe, u32 iir) return; if (!xe->info.has_heci_cscfi) { - drm_warn_once(&xe->drm, "CSC irq: not supported"); + xe_warn_once(xe, "CSC: unexpected irq %#x\n", iir); return; } @@ -244,5 +243,5 @@ void xe_heci_csc_irq_handler(struct xe_device *xe, u32 iir) ret = generic_handle_irq_safe(xe->heci_gsc.irq); if (ret) - drm_err_ratelimited(&xe->drm, "error handling GSC irq: %d\n", ret); + xe_err_ratelimited(xe, "CSC: irq handling failed (%pe)\n", ERR_PTR(ret)); } -- 2.53.0