From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A53C5CD6E7E for ; Fri, 5 Jun 2026 21:05:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2D81D112C26; Fri, 5 Jun 2026 21:05:50 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="PJl5xoXd"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6F7C5112C24; Fri, 5 Jun 2026 21:05:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780693549; x=1812229549; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=YezZB7JsIh5BuBWPJEGraTZMw5MNQ6UUalq531g+gIQ=; b=PJl5xoXdNZGMoNJqGqELsobbluC/Zd/EpY2xs5qXdC+5rDXYY8jR/sZ4 /rHtrkbu63KcnuPMIz1ELdUBjOda6vEwVzkfUrfxczbGvdJ5E5DLUfYyb 4Qd9R3ikdR6hf91DYMBpPApOYJ2IccLdYjHHOCFV7ATy37Fu52rNjO01k pyLM26UPCf/XJijKJxsRloxjrZ7lF8mnVIrBhBc7rWrSDTdPOSmQ0r5Tj MyL3siQ+ktJN4WyzHylQDa8DcN+vXtGI6BxGipj7Ov7rclYthhAdnPrC9 YCeuBx4JG9qVyAB6t+vhU5LVYvWE5brDnZX+PDOsiCjn47OOO87lqMucW g==; X-CSE-ConnectionGUID: 5lIpHFIlS1Wr+bkZTaFpGg== X-CSE-MsgGUID: oTLUzbDhQp6/AHvVLQkJ5A== X-IronPort-AV: E=McAfee;i="6800,10657,11808"; a="69064571" X-IronPort-AV: E=Sophos;i="6.24,189,1774335600"; d="scan'208";a="69064571" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2026 14:05:49 -0700 X-CSE-ConnectionGUID: NkvYDl6aR16j4sHhX6U2Yw== X-CSE-MsgGUID: 4pu5bFNdSC2HoycsLiVysQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,189,1774335600"; d="scan'208";a="244994708" Received: from osgc-sh-dragon.sh.intel.com ([10.239.81.44]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2026 14:05:47 -0700 From: Jonathan Cavitt To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: saurabhg.gupta@intel.com, alex.zuo@intel.com, jonathan.cavitt@intel.com, raag.jadav@intel.com, Michal.Wajdeczko@intel.com Subject: [PATCH v3 4/5] drm/i915: Refactor generic_handle_irq_safe() error messages Date: Sat, 6 Jun 2026 05:05:33 +0800 Message-ID: <20260605210534.3843211-5-jonathan.cavitt@intel.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260605210534.3843211-1-jonathan.cavitt@intel.com> References: <20260605210534.3843211-1-jonathan.cavitt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Refactor all error messages resulting from generic_handle_irq_safe() failures in I915 for clarity. v2: - Use drm_err_ratelimited() correctly (jcavitt) v3: - Use xe_err_ratelimited() instead (Jadav) - Split into patch series (jcavitt) v4: - Use suggested phrasing (Wajdeczko) v5: - s/PTR_ERR/ERR_PTR (jcavitt) Suggested-by: Raag Jadav Suggested-by: Michal Wajdeczko Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/i915/display/intel_lpe_audio.c | 2 +- drivers/gpu/drm/i915/gt/intel_gsc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_lpe_audio.c b/drivers/gpu/drm/i915/display/intel_lpe_audio.c index 022ad18044bf..ff2cf479d8e1 100644 --- a/drivers/gpu/drm/i915/display/intel_lpe_audio.c +++ b/drivers/gpu/drm/i915/display/intel_lpe_audio.c @@ -265,7 +265,7 @@ void intel_lpe_audio_irq_handler(struct intel_display *display) ret = generic_handle_irq_safe(display->audio.lpe.irq); if (ret) drm_err_ratelimited(display->drm, - "error handling LPE audio irq: %d\n", ret); + "LPE audio: irq handling failed (%pe)\n", ERR_PTR(ret)); } /** diff --git a/drivers/gpu/drm/i915/gt/intel_gsc.c b/drivers/gpu/drm/i915/gt/intel_gsc.c index 050d909fb4f8..1c06bf76568a 100644 --- a/drivers/gpu/drm/i915/gt/intel_gsc.c +++ b/drivers/gpu/drm/i915/gt/intel_gsc.c @@ -286,7 +286,7 @@ static void gsc_irq_handler(struct intel_gt *gt, unsigned int intf_id) ret = generic_handle_irq_safe(gt->gsc.intf[intf_id].irq); if (ret) - gt_err_ratelimited(gt, "error handling GSC irq: %d\n", ret); + gt_err_ratelimited(gt, "GSC: irq handling failed (%pe)\n", ERR_PTR(ret)); } void intel_gsc_irq_handler(struct intel_gt *gt, u32 iir) -- 2.53.0