From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F1E7C61DD3 for ; Thu, 3 Sep 2026 10:36:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9623410F4F9; Thu, 3 Sep 2026 10:36:10 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="X0SdEkPB"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id C9F1310F4F7; Thu, 3 Sep 2026 10:36:08 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 4C374601FB; Thu, 3 Sep 2026 10:36:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9ACF1F000E9; Thu, 3 Sep 2026 10:36:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788431768; bh=J6ZdMZLfluCT5KJ0ipdvS/MsvXXZY/glu2moxZOBezc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=X0SdEkPB3Ogr+utm3DPQ5sDyLRh+hJrtZRq/Qsa7DQg2mJgclnfQjq3amSgCogFom I1kcf+JeklQ89DFh4+vqS9R/3+B56N71KQvrAsCHc15Tb+XHrihyYGfApJbuQcwTZ2 XTu9iSDC+SPe0Z1QuWTi1qRTkmgwRPuBrM/uUahP2hhVj4eOkTndbiRXhZEoppk15P Y+rPapCIzT2GmH+4c/SvPnskIGpl6WSxAgHI+F6mLM/9GbLXUGpymdenWbg0eszCui 5E/pminoFs6GMizDqD08xwc9DBpHlVomcxvpbjSWgUZ+qqXmjbkzwZ50PgKBQAkUAY MXYy9gZFoPmWg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 1/8] mm: introduce hw_pte_t for PTE table storage To: "Muhammad Usama Anjum" Cc: damon@lists.linux.dev, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, dri-devel@lists.freedesktop.org, bpf@vger.kernel.org, intel-gfx@lists.freedesktop.org In-Reply-To: <20260903103002.1091859-2-usama.anjum@arm.com> References: <20260903103002.1091859-1-usama.anjum@arm.com> <20260903103002.1091859-2-usama.anjum@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 03 Sep 2026 10:36:07 +0000 Message-Id: <20260903103607.B9ACF1F000E9@smtp.kernel.org> X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" > pte_t is used both for software PTE values and for entries stored in a PTE > table, so pte_t * does not distinguish a pointer to a software PTE > value from a pointer to table storage. >=20 > Introduce hw_pte_t as the generic name for a PTE table element. Define it > as a macro alias of pte_t by default. When an architecture selects > ARCH_HAS_HW_PTE_T, define it as a structure containing a pte_t instead. > This preserves the representation while allowing converted architectures > to enforce the distinction at compile time. >=20 > Name the generic wrapper structure __hw_pte_t so architectures can > forward-declare it when pgtable_t must be defined before the generic > hw_pte_t typedef is visible. This avoids header-order dependencies. >=20 > Keep the C type definitions behind an __ASSEMBLY__ check because > architecture assembly sources can include this header indirectly. Include > asm/page.h so consumers such as linux/vmalloc.h retain the page definitio= ns > they previously obtained from that header. >=20 > Signed-off-by: Muhammad Usama Anjum Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260903103002.1091= 859-1-usama.anjum@arm.com?part=3D1