From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08352C88E40 for ; Thu, 10 Sep 2026 14:24:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D01AC10F4BC; Thu, 10 Sep 2026 14:24:21 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="fDddcE1h"; dkim-atps=neutral Received: from mail-wr2-f12.google.com (mail-wr2-f12.google.com [74.125.225.76]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5764A10F217 for ; Wed, 9 Sep 2026 17:36:16 +0000 (UTC) Received: by mail-wr2-f12.google.com with SMTP id ffacd0b85a97d-485ac8990caso120228f8f.2 for ; Wed, 09 Sep 2026 10:36:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788975375; x=1789580175; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=EqyOJwWDc9siUyUIf9HLEiRZ/UBmYkZ2bG5NW9K2GYU=; b=fDddcE1hBH0aV7gxmYszw66V+DtDfxbheCNsiJvmvNvo45OJoLmieY0HRE8UkdnvWV 8iDq+j+lo7oW6LrXsffpwr5zH7tWQjSsaY/krOmVQ8V8VCeoFTD3D9RplDQ9IJA4eTg7 qRWkDYrwatkhcDxyzlnoxkSAWtxRbQ/WOctLaxb3T+Uej3h/3GMLMfhgWAfzV1hIJTX5 fDVAyM5kUn9pij5liMk8UIk3KvHnVU35+L+0sIr6ubz3js2beQicC7eBi2v8c4IbREpw h2zSJXPVh2h8YQP1dX7gLJwz/GCvaymOYIc2WYo9MKxsV2x9y+osA1s26wS1Hc4xpogm OUgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788975375; x=1789580175; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=EqyOJwWDc9siUyUIf9HLEiRZ/UBmYkZ2bG5NW9K2GYU=; b=IjYwijT1RFXEeTSMbs3B+/rqgvxrll1Lm/6quRKnSguABLq5Lo1genl73T3iXKo6Ak Emjij/KzhrvbyXQQlBDP4wG7CilOvzgNPp760dd0+U8SQRPfiVvNQlzigSQLpJu+08eC BPrxqERYLk56EnNNBeVMZpuxDelm4tKf+9jA4basqwj6FgSYP4bi3fulp1iwf2rK0Qkd QggHuSi9saic9oIeB93AgUG0rOQJUD5uWAgDoNXcv47T+3Nfkhgk5V8ptOFZ0ExvFaeI R1LXdpySjeZTvmq1PJRBiIF76qid0NiWFXbr3V5bekB6gkBfMxktFYiek/N7A8ijAj/O 3ZTw== X-Forwarded-Encrypted: i=1; AKwUvBzJpgmxK6AfKqgSN14Q2HLqOnqrQ0JJoDuikpC1GJMMu8sp9YkL77Ox4DZG3xqvzLodGcBriol7Uho=@lists.freedesktop.org X-Gm-Message-State: AFuF++mGMIJKzya0XagRf9dafiM5rjhcjaD3Rw/ZI5gL0JvTUGU4EBUM LK6JbLVuivLfAilUTc9Ia5mbet50r1oRr3kJoD+LcDF4Wdn6cx3i/XhG X-Gm-Gg: AYBFou01Smg1lDhiHWOzdtH8ySlHFXTYHb7exYMJK1EkEtm/FTNDyWEYI1RJFxwzOjU infglcGJMlYdan72ogX+ScBiTTnysDBaUadZUvr/XvtS2N+cDO10+n+ZnFVaNYpqG+36sIPOPoc W6JVgmnoNyGs67RyF7E52ng5lnxqrr7UjuFLa7ttXkap+kyNEjeyD6iddUvuHg/cdUilIuyD0n4 FGDE6oRaZZ0dDsqDbXBNbas3mlSlNBJdcbh4+OUpb9YNi2t/jFD3F6m7nOniI5sgtSXlvQAMJYt Xx6snSPxZjwBgFzEBNQT6MOJYidIc3njgExYskJB8LLsViLpTQy+5dUEkSLbhWVyHwivd9fcHcs m3Et/su2l2M2T00xkrDNuj+7/g2xVQQ4E+nwyefWODXYLDmDBRGXTpYY5Ea0Fc91XQ4ARV+Mrya ODpItfu2LhJ+Dudb1tTe9sTpBnDtAGmNnWODeZP5ctZJ2uydyV/3JvfYYzJtv/Yc1LSz1LjzEBv 8Of4OK5kbQfBxREN2vt58IhhgCsjT63JmkIU5Wgdl2B8Wns9+45u/cEpBrFU6vB3TmPZ3jxCbk9 7w== X-Received: by 2002:a05:600c:620f:b0:49c:eac2:ddad with SMTP id 5b1f17b1804b1-49d2570acaemr24678895e9.1.1788975374390; Wed, 09 Sep 2026 10:36:14 -0700 (PDT) Received: from OrangePi5-Plus.BB-HOME (20014C4E1B836900B0110705BF092680.dsl.pool.telekom.hu. [2001:4c4e:1b83:6900:b011:705:bf09:2680]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49d26c06f04sm6876575e9.13.2026.09.09.10.36.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2026 10:36:14 -0700 (PDT) From: Igor Paunovic To: dri-devel@lists.freedesktop.org Cc: Igor Paunovic , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Sebastian Reichel , Cristian Ciocaltea , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Baryshkov , Sandy Huang , Heiko Stuebner , Andy Yan , Jani Nikula , Rodrigo Vivi , Ville Syrjala , Imre Deak , Ankit Nautiyal Subject: [PATCH v2 3/3] drm/rockchip: dw_dp: Attach "max bpc" connector property Date: Wed, 9 Sep 2026 19:35:40 +0200 Message-ID: <20260909173542.14030-4-royalnet026@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260909163206.36409-1-royalnet026@gmail.com> References: <20260909163206.36409-1-royalnet026@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Thu, 10 Sep 2026 14:24:20 +0000 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" The dw-dp bridge already filters candidate output formats on conn_state->max_bpc in dw_dp_bridge_atomic_get_output_bus_fmts() and validates the result against the link bandwidth, but the connector never exposes the "max bpc" property, so userspace cannot limit the bit depth. Attach the property with a range of 6 to 10, matching dw_dp_output_formats[]: the smallest entry is 6 bpc RGB and the deepest entries are 10 bpc. drm_connector_attach_max_bpc_property() initializes connector->state->max_requested_bpc and therefore requires the connector to have a state. Rockchip binds its components before drm_mode_config_reset() runs, so the freshly created bridge connector does not have one yet - create the connector state before attaching the property, exactly like drmm_connector_hdmi_init() does for HDMI bridge connectors. The later drm_mode_config_reset() then re-creates the connector state, and the preceding patch makes drm_bridge_connector_create_state() restore max_requested_bpc from connector->max_bpc, so clients that never set the property (fbcon in particular) keep the full range instead of ending up with 0. With the property attached, compositors such as KWin write "max bpc" on every atomic modeset; any in-range value is handled by the existing format filter and bandwidth checks. Assisted-by: LLM checkpatch Signed-off-by: Igor Paunovic --- drivers/gpu/drm/rockchip/dw_dp-rockchip.c | 26 +++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/drivers/gpu/drm/rockchip/dw_dp-rockchip.c b/drivers/gpu/drm/rockchip/dw_dp-rockchip.c index b23efb153c9e6..8ff27353b1417 100644 --- a/drivers/gpu/drm/rockchip/dw_dp-rockchip.c +++ b/drivers/gpu/drm/rockchip/dw_dp-rockchip.c @@ -112,6 +112,32 @@ static int dw_dp_rockchip_bind(struct device *dev, struct device *master, void * "Failed to init bridge connector\n"); } + /* + * The components are bound before drm_mode_config_reset() runs, so + * the connector has no state yet, but + * drm_connector_attach_max_bpc_property() requires one. Create the + * connector state first, like drmm_connector_hdmi_init() does. + */ + if (connector->funcs->atomic_create_state) { + struct drm_connector_state *state; + + state = connector->funcs->atomic_create_state(connector); + if (IS_ERR(state)) { + dw_dp_unbind(dp->base); + return PTR_ERR(state); + } + + connector->state = state; + } else if (connector->funcs->reset) { + connector->funcs->reset(connector); + } + + ret = drm_connector_attach_max_bpc_property(connector, 6, 10); + if (ret) { + dw_dp_unbind(dp->base); + return ret; + } + return 0; } -- 2.43.0