From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7569C88E48 for ; Thu, 10 Sep 2026 14:24:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6A7AB10F4C1; Thu, 10 Sep 2026 14:24:22 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="pZcE0QJ/"; dkim-atps=neutral Received: from mail-wm2-f12.google.com (mail-wm2-f12.google.com [74.125.225.140]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2C0D310F343 for ; Thu, 10 Sep 2026 07:52:03 +0000 (UTC) Received: by mail-wm2-f12.google.com with SMTP id 5b1f17b1804b1-49b0dd3e1d0so2366285e9.0 for ; Thu, 10 Sep 2026 00:52:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789026721; x=1789631521; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hSvkvCa4QalyG2BNxJcMEEX0DpoCO16400N3JfxMgjQ=; b=pZcE0QJ/Bfd32reE+IVYJ0CkME3JCB/JSb8N6SS0ZNMqsC8/WJQSMFFzj0GOCWex/J Bsdge9YyICVEdtfj3xmR3OetQxHpbcglg4nWUfC9ksHr9wfs0ED0GHbCpLIKTFvIaA94 MitcYxDS3ZG67tuz+MHPpefjLSXv/JgOKdpXeaElMJLLWhK7pHnGD0UYA5JmLb78GbbM 1YT9v4aRu98zPYEBp9Ucf/a+AUdYkPN9sYyqkdhEOSJ8mg/pkNAvfuboawIKnhbZ+tj9 rzMmZfobTWBv2DblpghFW/yU+4ceQCu5a2VZ9GPj4nQPc1ygDkg2kV1TlXPkrHcEgbXP LyNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789026721; x=1789631521; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=hSvkvCa4QalyG2BNxJcMEEX0DpoCO16400N3JfxMgjQ=; b=Axj2BtUzArcPzw5GchdyEl62zVeSEva0g2TAjyC412LODJtUKKoB+p8UwoI02aT3A4 pgV7ykUsZujwzMo4h3qVl7gr/Pg5xJ9tLUnNpUIMW+0oXIjPUI8DdnXg5pbB4z4dziCG j6/FGPayro6YunPfSFKrtpwucyNRFh/HQTp3sIn3EhFCnyMkPqAQ6npeMacFY9I3FTir E1Gv+258Y+qlYZ0W3fipv9Ruux6X8nPmvYCHxx/aFEiwxB3UWa/P+VPX2XyJ3daiN+iS O1jhbxhOYLpyggkriJ6aJUg3tYxrpPlwAVggz6nlIajuPDRtoqRgetKUhqVS4B13AixO iL1g== X-Forwarded-Encrypted: i=1; AKwUvByFO+JabPlhF1UN3bZ6NBS3mgRvu76erXUHxBVlbjb+CwVSXOhdX0hi6KIgDACgP312jJXlg9qpfN0=@lists.freedesktop.org X-Gm-Message-State: AFuF++mw995cBvJPn0o7JtuhaSqnpwlVumREKjsUXkXuxrAbhS/lnzB8 bxp/4uSa6zieofn+jffXJB1XJtJQ6giYIDZ0QIQAg5VSMI1LVKNSEo8l X-Gm-Gg: AYBFou3h1yQP9MNZ0LCKJFEeXmECJmVHUrfyWHEHWqO5aDNJElNh9AGf5M9EuP7YOhq eht9ogd6wdCVZmYeFbBzCxcBshKj3IggiXUsu3cfULaOKUBXGLPJaq43dtQ/P7264cO1baEApC1 UJoBl5jFQ+A1fhah3G7Y7ZS0eBiWbadKa1nBXh09kNweh5yI2+79WpFwq3y1sGNE0zEHL869ert gYAQojwosytqKyfC3TLvJIR5N51b6klkwAM+WE24tondg1TYiHf/kDhFYMoeAobnA/fe0SJIE5t OvlRkXQGLn0Yq+Y7moMvWCTVt+wWJfy71y3sAsLcO0asJlUNugRSh8zxervIjIMEvUFrmedzKmq goZ+a2adYHsCJY8HTvaXwQyURR63Pa+VrYh/yk/NzLd9CCe0Vu11ec0xpANZqQCU8pCh5f5uKbe CGV15SmONOLIkwNNgyIClPrr0IbxX5zTKeoAMEKa87wScwU3LsNzQ2UIfoL2UsSpoTXU6ujzBXW S36VYFqjYn4RDvDdIt6DcqCZ0C2gHEtxqQBwktRrMgiPMIgP/a6Uh4tQ5VCVxfjVA7eur4upmpI 1ANS X-Received: by 2002:a05:600c:530d:b0:49c:e363:c66e with SMTP id 5b1f17b1804b1-49d01dce86fmr291744635e9.1.1789026720937; Thu, 10 Sep 2026 00:52:00 -0700 (PDT) Received: from OrangePi5-Plus.BB-HOME (20014C4E1B9146001C92980EE71198AB.dsl.pool.telekom.hu. [2001:4c4e:1b91:4600:1c92:980e:e711:98ab]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49d20fce7a7sm251593715e9.4.2026.09.10.00.51.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2026 00:52:00 -0700 (PDT) From: Igor Paunovic To: Chaoyi Chen Cc: Igor Paunovic , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Maxime Ripard , Dmitry Baryshkov , Laurent Pinchart , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Sandy Huang , Heiko Stuebner , Andy Yan , Sebastian Reichel , Cristian Ciocaltea , Jani Nikula , Rodrigo Vivi , Ville Syrjala , Imre Deak , Ankit Nautiyal Subject: Re: [PATCH v2 3/3] drm/rockchip: dw_dp: Attach "max bpc" connector property Date: Thu, 10 Sep 2026 09:51:40 +0200 Message-ID: <20260910075141.48803-1-royalnet026@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <9e77b5c5-f1d9-484b-ae02-846fae1b3642@rock-chips.com> References: <9e77b5c5-f1d9-484b-ae02-846fae1b3642@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Thu, 10 Sep 2026 14:24:20 +0000 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Chaoyi, On 9/10/26 09:16, Chaoyi Chen wrote: > I don't think this is the correct way to go. > > I believe max_bpc should be handled in drm_bridge_connector_init(). > Take a look at its implementation. HDMI already does max_bpc there, > so DP should probably do something similar. Agreed - that is the question I left open in my reply to the bot. v3 moves it into drm_bridge_connector_init() and drops this glue patch. Three points I would rather ask than guess, since it is shared code: 1. How the bridge advertises it. drm_bridge.max_bpc is documented as "only relevant if DRM_BRIDGE_OP_HDMI is set" and the helper only reads it inside the OP_HDMI block. I intend to honour it on the non-HDMI path too, relax that doc sentence, and have dw-dp set bridge->max_bpc = 10. If you prefer to keep the field HDMI-only, a separate field is easy - I just did not want to add one unasked. 2. The range. HDMI attaches 8..max_bpc. dw-dp's format table goes down to 6 bpc RGB and i915 attaches 6..N on its DP connectors, so I intend 6..max_bpc when connector_type is DisplayPort, 8..max_bpc otherwise - the same gate Dmitry used for the DP subconnector property in his msm series [1]. Nothing is attached unless a bridge declared max_bpc, so existing non-HDMI bridge connectors are unchanged. 3. Where the default lives. 2/3 restores max_requested_bpc from connector->max_bpc after drm_mode_config_reset(), but Cristian's v11 71/74 removes that field [2] (HDMI keeps it in hdmi.funcs). I intend to keep the value in struct drm_bridge_connector and restore it from there in drm_bridge_connector_create_state(), which folds 2/3 into the same patch. 1/3 is unaffected. The state still has to exist before the property is attached, so the non-HDMI path gets the same create-state block drmm_connector_hdmi_init() has. If you would rather see that block factored into a helper for both callers, say so and I will do that instead. [1] https://lore.kernel.org/all/20260722-drm-msm-display-interface-v1-24-368c10fe62fd@oss.qualcomm.com/ [2] https://lore.kernel.org/all/20260901-dw-hdmi-qp-scramb-v11-71-bc12954a0688@collabora.com/ Thanks, Igor