From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29B71C98307 for ; Wed, 23 Sep 2026 11:15:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 94C6B10EFC4; Wed, 23 Sep 2026 11:15:22 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=lankhorst.se header.i=@lankhorst.se header.b="agqPy1U7"; dkim-atps=neutral Received: from lankhorst.se (unknown [141.105.120.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id E4DDC10EF97 for ; Wed, 23 Sep 2026 11:15:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lankhorst.se; s=default; t=1790162115; bh=AnpwaZZE8DXIN+LgUiO5Lf1V8n7HZEOLNXhTYCfLNLA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=agqPy1U7w8noNW26ifCIYobH3pO4euy/btj5MLRtfd7feb5ePmpBtT3g1YeToNFnV XIyXTeGJgZQ+kDXxgZYV2v5H+uhJk6TznSbvMDP0S43tOaZ1x3qaU5ED1/McN9XiN+ ElPvso5zpDWpTFSoGiwkun3HRgxsCeqIQRJ0R3+H5rSraEuxXcpbwMgsfdrQZfvpfz sVqFywug+bnLwsp5HJg1vNH5ssaL/kbIj+Ta2wL+sPcqC6G7XDXTSZvRlFxxMZdckZ 6bgfrzYPLzquRkxsdoVapazWNmf2mpRxRFN6k/q3guEeog57JZjo3mMjnB6DMm2aLS H9Jb47i6c+Vcw== From: Maarten Lankhorst To: Sebastian Andrzej Siewior , Joonas Lahtinen , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org Cc: Maarten Lankhorst , Tvrtko Ursulin , Rodrigo Vivi , Maarten Lankhorst Subject: [PATCH v5 2/6] drm/i915: Drop the irqs_disabled() check Date: Wed, 23 Sep 2026 13:15:21 +0200 Message-ID: <20260923111518.310430-10-dev@lankhorst.se> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260923111518.310430-8-dev@lankhorst.se> References: <20260923111518.310430-8-dev@lankhorst.se> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" From: Sebastian Andrzej Siewior The !irqs_disabled() check triggers on PREEMPT_RT even with i915_sched_engine::lock acquired. The reason is the lock is transformed into a sleeping lock on PREEMPT_RT and does not disable interrupts. There is no need to check for disabled interrupts. The lockdep annotation below already check if the lock has been acquired by the caller and will yell if the interrupts are not disabled. Remove the !irqs_disabled() check. Reported-by: Maarten Lankhorst Acked-by: Tvrtko Ursulin Signed-off-by: Sebastian Andrzej Siewior Reviewed-by: Rodrigo Vivi Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/i915_request.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c index d2c7b1090df08..f66f8efc70629 100644 --- a/drivers/gpu/drm/i915/i915_request.c +++ b/drivers/gpu/drm/i915/i915_request.c @@ -610,7 +610,6 @@ bool __i915_request_submit(struct i915_request *request) RQ_TRACE(request, "\n"); - GEM_BUG_ON(!irqs_disabled()); lockdep_assert_held(&engine->sched_engine->lock); /* @@ -719,7 +718,6 @@ void __i915_request_unsubmit(struct i915_request *request) */ RQ_TRACE(request, "\n"); - GEM_BUG_ON(!irqs_disabled()); lockdep_assert_held(&engine->sched_engine->lock); /* -- 2.55.0