From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66A71606A338 for ; Sun, 22 Nov 2026 17:55:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=fnQSCvxH Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C1D5010E718; Sun, 22 Nov 2026 17:55:46 +0000 (UTC) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7C6E110E718; Sun, 22 Nov 2026 17:55:40 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 5CF80408F8; Sun, 22 Nov 2026 17:55:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C0B71F000CA; Sun, 22 Nov 2026 17:55:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795370139; bh=UAlvlm6XIkjF3CVGuekihGQ4derGbHtU5YfuFOl41qQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=fnQSCvxHNo6ERlskR5pyD0RirUHJHoMwYscn8zEwfhOm9qyM/LS5q0it778nXObyH SFAoOYjlOjFY5vXKOdLIVVvhXhoGFLbxI9dKLWclz9Y+vELX6BSItyyKQCjZEhh73b 10FztGFeJtlA7TjtRykt5PquRo8ffQfsvW8vgg5YPWh1gTjYgtRk/9zBWoMaOYQyYK +EWwSmhu5H9+l5Ov8IJ+BxLNt/hV2vqgTdn9JMlKNSM85QVslyyH4cAPWwT/+J4LZO 8VjJz3ZemsMNeHxwk3c/4OJET3WCmIek09eFjsE5DOZpRMzhb6ZRllFEB3+qtHYI5V pz0ICmqsjK+7A== From: "David Hildenbrand (Arm)" Date: Sun, 22 Nov 2026 18:55:18 +0100 Subject: [PATCH v2 1/4] mm: do not call vm_ops->access with FOLL_ANON X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261122-access_shite-v2-1-808d8d2aa700@kernel.org> References: <20261122-access_shite-v2-0-808d8d2aa700@kernel.org> In-Reply-To: <20261122-access_shite-v2-0-808d8d2aa700@kernel.org> To: Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Andrew Morton , Willy Tarreau , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Chris Wilson , Matthew Auld , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , "Ritesh Harjani (IBM)" , Shrikanth Hegde , Rik van Riel , Benjamin Herrenschmidt Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linuxppc-dev@lists.ozlabs.org, "David Hildenbrand (Arm)" , Chris Mason , stable@vger.kernel.org X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1410; i=david@kernel.org; h=from:subject:message-id; bh=lBTEaJm0bEVMUkiJfmMuzjRSMI6nwi0rCciXc1cDdUU=; b=owGbwMvMwCF2/OVpCdfQ3ZWMp9WSGLKZdToqLJWbiudm15yqnu0Qrr+968s6pakJN3untk3iS p1okT6to5SFQYyDQVZMkSUo+L7By5fraqvd+Jhh5rAygQxh4OIUgIn4hDP8FTc+nBUYp1uw+alk Y2JYAP/y+/9uzzzC9WG/Zv2nxLKg4wz/65dyaF1cE7M41Uy+dOqfLXMCLrAu2vmRMTRvgXD485Z 0TgA= X-Developer-Key: i=david@kernel.org; a=openpgp; fpr=1BD9CAAD735C4C3A460DFCCA4DDE10F700FF835A X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Intel-gfx" X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 From: Chris Mason Reading /proc//cmdline or /proc//environ can block in a device driver, or read device memory, if the virtual addresses point at a device mapping. Ever since commit 7f7ccc2ccc2e ("proc: do not access cmdline nor environ from file-backed areas") we use FOLL_ANON to only read from anonymous memory. While GUP properly handles FOLL_ANON, __access_remote_vm() will fall back on GUP errors to vma->vm_ops->access() without similarly considering the flag. Fix it by not calling vm_ops->access if FOLL_ANON was specified, to truly limit it to anonymous memory only. Fixes: 7f7ccc2ccc2e ("proc: do not access cmdline nor environ from file-backed areas") Signed-off-by: Chris Mason Cc: stable@vger.kernel.org [ david: simplify description; slightly rework implementation ] Reviewed-by: Lorenzo Stoakes (ARM) Signed-off-by: David Hildenbrand (Arm) --- mm/memory.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/memory.c b/mm/memory.c index 6a23198c1c67f..5d0d58aeff3cb 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -7448,6 +7448,9 @@ static int __access_remote_vm(struct mm_struct *mm, unsigned long addr, continue; } + if (gup_flags & FOLL_ANON) + break; + /* * Check if this is a VM_IO | VM_PFNMAP VMA, which * we can access using slightly different code. -- 2.56.1