From mboxrd@z Thu Jan 1 00:00:00 1970 From: Egbert Eich Subject: Re: [PATCH 04/24] drm/i915: s/hotplug_irq_storm_detect/intel_hpd_irq_handler/ Date: Wed, 12 Jun 2013 16:22:07 +0200 Message-ID: <20920.33807.704187.135227@linux-qknr.site> References: <1371037046-3732-1-git-send-email-daniel.vetter@ffwll.ch> <1371037046-3732-5-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTP id 955C9E5C26 for ; Wed, 12 Jun 2013 07:22:11 -0700 (PDT) In-Reply-To: daniel.vetter@ffwll.ch wrote on Wednesday, 12 June 2013 at 13:37:06 +0200 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Egbert Eich , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org Daniel Vetter writes: > The combination of Paulo's fifo underrun detection code and Egbert's > hpd storm handling code unfortunately made the hpd storm handling code > racy. > > To avoid duplicating tricky interrupt locking code over all platforms > start with a bit of refactoring. This patch is the very first step > since in the end the irq storm handling code will handle all hotplug > logic (and so also encapsulate the locking nicely). > > Cc: Egbert Eich > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/i915_irq.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > [reviewed code deleted] Reviewed-by: Egbert Eich