From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DC63CCF9E5 for ; Mon, 27 Oct 2025 12:04:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E6D8410E450; Mon, 27 Oct 2025 12:04:23 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="jhAqckHa"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 99A0610E442; Mon, 27 Oct 2025 12:04:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1761566663; x=1793102663; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=z6PtE3johW5vJLX1vTiHKPTlmGotYrgMC5atz+ScftI=; b=jhAqckHalrn2ahnYkUMhyXwRP22AA9udAVBqZ9utg8cMzB3aSZ4hLF19 neSyQ3StWK1V5/8lZsk62yVZ3fMNECXKUx+7LMuPC0QTW2403lazCHAEr Qm7ce5fEWOKFMB672FZdNxBR9Tde0S3QztIbEt09GvCMR8yO8ejFyBkN/ 4glDicYFI8Lpzh7oMXSLbH6LmpZtlHlaJV6BiscpRuA4VbwUrM8+/j5VS D/dNvRDmYZLOMcnMHNcrckIShWWNkVawGWmdivmZlC70qOttMbVdKySc6 iOm01SipzErsak75xdbPLEyN05ezAmEh8VY9GfwVRqAlxuCd9nVrmj28i A==; X-CSE-ConnectionGUID: stlQk41fSjiqWTwi0spcWg== X-CSE-MsgGUID: cnZ5yRCRRuWwrDHv0BgYww== X-IronPort-AV: E=McAfee;i="6800,10657,11586"; a="74985868" X-IronPort-AV: E=Sophos;i="6.19,258,1754982000"; d="scan'208";a="74985868" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2025 05:04:22 -0700 X-CSE-ConnectionGUID: oZDx2a3CT4a3Fy6UrTapYw== X-CSE-MsgGUID: kYy+eSPuSvK3QOGrkYCSAA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,258,1754982000"; d="scan'208";a="190239263" Received: from slindbla-desk.ger.corp.intel.com (HELO localhost) ([10.245.246.35]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2025 05:04:20 -0700 From: Jani Nikula To: Thomas Zimmermann , dri-devel@lists.freedesktop.org, maarten.lankhorst@linux.intel.com, Maxime Ripard , David Airlie , simona.vetter@ffwll.ch Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Subject: Re: [PATCH v2 0/3] drm: replace drm_print.h includes from headers with a forward declaration In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: Date: Mon, 27 Oct 2025 14:04:17 +0200 Message-ID: <2266c3955cd1153aabc909fd3b7a4f019a549989@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 27 Oct 2025, Thomas Zimmermann wrote: > Hi, > > for the series > > Reviewed-by: Thomas Zimmermann Thanks! > Some thoughts: Consider merging patches 1 and 2 OR split off the change=20 > to ttm_resource.h from patch 3.=C2=A0 Doing the latter would make a rever= t of=20 > the forward declaration easier in case some trees stop building. Feel=20 > free to put everything into drm-misc-next if that still compiles then. I'm sorry, I don't understand what you're getting at. The series is bisectable, and in the first patch the indirect source of drm_print.h is drm_mm.h, and in the third patch it's ttm_resource.h. BR, Jani. --=20 Jani Nikula, Intel