From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA9B3C433F5 for ; Wed, 27 Apr 2022 09:15:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 183DF10E095; Wed, 27 Apr 2022 09:15:40 +0000 (UTC) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3C3AB10E095 for ; Wed, 27 Apr 2022 09:15:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651050939; x=1682586939; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=jZ6uAFWDqeUNdA4al3xrmpmT7zLHnepGYu+nOr9NJeM=; b=nxPgMNmEM9b87qtd6/I2HAm1TvEcuhtmtyYPF7syOyc/OImSx8Q/QdKO tXihrWXOJyJJZi5eeUgKPmTLsY0qhLwcMHy79IKia9dRUcbGcBVgCLkiV uyVDlB1h0LJod6XP3rZfVboBrPB9PNx0f0pog2CiNGjsNS9Oiq2EgkLpy 7RhyVDdfkv+zkkUtrgZiZecLY0prNiKPEIBq99zaW5ShpZyikaRlS/x9e 86OKaL3w0Dp+fjvgUpa6Zhm/AgyYiBfiWIIu457ddhIdWmH7zo7ygWfhS efcrAM/jn37XTG/RfjEO1aZO17Q3TSSnXdk4V7Ym5izWCG6ctkAaYtsUw g==; X-IronPort-AV: E=McAfee;i="6400,9594,10329"; a="326360966" X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; d="scan'208";a="326360966" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2022 02:15:38 -0700 X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; d="scan'208";a="580488252" Received: from jmwalsh-mobl.amr.corp.intel.com (HELO [10.213.205.227]) ([10.213.205.227]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2022 02:15:37 -0700 Message-ID: <22e84175-eef3-5ef3-14f0-8a19bbdab70e@linux.intel.com> Date: Wed, 27 Apr 2022 10:15:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: Ashutosh Dixit , intel-gfx@lists.freedesktop.org References: <20220413225732.34943-1-ashutosh.dixit@intel.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH v3] drm/i915: Don't show engine information in fdinfo with GuC submission X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 15/04/2022 01:25, Ashutosh Dixit wrote: > At present i915 does not fetch busyness information from GuC, resulting in > incorrect busyness values in fdinfo. Because engine information is coupled > with busyness in fdinfo, skip showing client engine information in fdinfo > with GuC submission till fetching busyness is supported in the i915 GuC > submission backend. > > v2 (Daniele): > Make commit title and description more precise > Add FIXME with brief description at code change > s/intel_guc_submission_is_used/intel_uc_uses_guc_submission/ > > v3 (Daniele): > Drop FIXME in comment > > Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/5564 > Fixes: 055634e4b62f ("drm/i915: Expose client engine utilisation via fdinfo") > Cc: Daniele Ceraolo Spurio Cc: Umesh Nerlige Ramappa > Signed-off-by: Ashutosh Dixit > Reviewed-by: Daniele Ceraolo Spurio > --- > drivers/gpu/drm/i915/i915_drm_client.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_drm_client.c b/drivers/gpu/drm/i915/i915_drm_client.c > index e539f6b23060..475a6f824cad 100644 > --- a/drivers/gpu/drm/i915/i915_drm_client.c > +++ b/drivers/gpu/drm/i915/i915_drm_client.c > @@ -145,7 +145,11 @@ void i915_drm_client_fdinfo(struct seq_file *m, struct file *f) > PCI_SLOT(pdev->devfn), PCI_FUNC(pdev->devfn)); > seq_printf(m, "drm-client-id:\t%u\n", client->id); > > - if (GRAPHICS_VER(i915) < 8) > + /* > + * Temporarily skip showing client engine information with GuC submission till > + * fetching engine busyness is implemented in the GuC submission backend > + */ > + if (GRAPHICS_VER(i915) < 8 || intel_uc_uses_guc_submission(&i915->gt0.uc)) > return; > > for (i = 0; i < ARRAY_SIZE(uabi_class_names); i++) Thanks for fixing this while I was away. It was a simple miss, nothing sinister. In terms of mention of "garbage" numbers being reported - were they actually garbage or simply always zero? Regards, Tvrtko