From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 14/15] drm/i915/guc: Keep the execbuf client allocated across reset Date: Mon, 28 Nov 2016 15:44:41 +0000 Message-ID: <23456f84-9292-9f84-95c8-9da3128ae873@linux.intel.com> References: <20161125093057.18491-1-chris@chris-wilson.co.uk> <20161125093057.18491-15-chris@chris-wilson.co.uk> <374f5898-6f14-00a7-2af3-3fdc2d06ac7a@linux.intel.com> <20161128141146.GD17384@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1BE9C6E3E4 for ; Mon, 28 Nov 2016 15:45:02 +0000 (UTC) In-Reply-To: <20161128141146.GD17384@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI4LzExLzIwMTYgMTQ6MTEsIENocmlzIFdpbHNvbiB3cm90ZToKPiBPbiBNb24sIE5vdiAy OCwgMjAxNiBhdCAwMTo0OTowM1BNICswMDAwLCBUdnJ0a28gVXJzdWxpbiB3cm90ZToKPj4KPj4g T24gMjUvMTEvMjAxNiAwOTozMCwgQ2hyaXMgV2lsc29uIHdyb3RlOgo+Pj4gSW4gb3JkZXIgdG8g YXZvaWQgc29tZSBjb21wbGV4aXR5IGluIHRyeWluZyB0byByZWNvbnN0cnVjdCB0aGUKPj4+IHdv cmtxdWV1ZXMgYWNyb3NzIHJlc2V0LCByZW1lbWJlciB0aGVtIGluc3RlYWQuIFRoZSBpc3N1ZSBj b21lcyB3aGVuIHdlCj4+PiBoYXZlIHRvIGhhbmRsZSBhIHJlc2V0IGJldHdlZW4gcmVxdWVzdCBh bGxvY2F0aW9uIGFuZCBzdWJtaXNzaW9uLCB0aGUKPj4+IHJlcXVlc3QgaGFzIHJlc2VydmVkIHNw YWNlIGluIHRoZSB3cSwgYnV0IGlzIG5vdCBpbiBhbnkgbGlzdCBzbyB3ZSBmYWlsCj4+PiB0byBy ZXN0b3JlIHRoZSByZXNlcnZlZCBzcGFjZS4gQnkga2VlcGluZyB0aGUgZXhlY2J1ZiBjbGllbnQg aW50YWN0Cj4+PiBhY3Jvc3MgdGhlIHJlc2V0LCB3ZSBhbHNvIGtlZXAgdGhlIHJlc2VydmF0aW9u cy4KPj4KPj4gSSBsb3N0IHRyYWNrIGEgYml0IG9uIHdoeSBkbyB3ZSBuZWVkIHRvIHJlc2VydmUg dGhlIHNwYWNlIGF0IHJlcXVlc3QKPj4gY3JlYXRpb24gdGltZT8gSXMgaXQgbm90IGJlY29taW5n IGEgYml0IGN1bWJlcnNvbWU/Cj4KPiBJdCBpcyB2ZXJ5LCB2ZXJ5IGhhcmQgdG8gaGFuZGxlIGEg ZmFpbHVyZS4gV2UgaGF2ZSB0byBiZSBjYXJlZnVsIG5vdCB0bwo+IGFsdGVyIGdsb2JhbCBzdGF0 ZSBwcmlvciB0byBleGVjdXRpbmcgdGhlIHJlcXVlc3QsIG9yIGF0IGxlYXN0Cj4gc3VibWl0dGlu ZyB0aGUgcmVxdWVzdCwgd2hpY2ggd2UgYXJlIGN1cnJlbnRseSBub3QuIFNpbmNlIHdlIGNhbid0 Cj4gdW53aW5kIHRoZSBnbG9iYWwgc3RhdGUgY2hhbmdlcywgdGhhdCBpbXBvc2VzIGEgcG9pbnQt b2Ytbm8tcmV0dXJuIG9uCj4gcmVxdWVzdCBjb25zdHJ1Y3Rpb24gYWZ0ZXIgd2hpY2gsIHRoZSBy ZXF1ZXN0IG11c3QgYmUgc3VibWl0dGVkLiAoSXQgaXMKPiBwb3NzaWJsZSB0aG91Z2ggdG8gZGV0 ZWN0IHdoZW4gYSByZXF1ZXN0IGRvZXNuJ3QgbWFrZSBhbnkgZ2xvYmFsIHN0YXRlCj4gY2hhbmdl cyBhbmQgZHJvcCB0aGUgcmVxdWVzdCBvbiBhZGQuKSBBcyB0aGUgcmVzZXJ2YXRpb24gbWF5IGZh aWwsIHdlCj4gaGF2ZSB0byBkbyB0aGF0IGVhcmx5LgoKV2UgY291bGRuJ3QganVzdCBub3QgZG8g YW55IG9mIHRoZSByaW5nIGJ1ZmZlciB3cml0aW5nIGF0IGV4ZWNidWYgdGltZSwgCmp1c3QgYWRk IGl0IHRvIHRoZSBhcHByb3ByaWF0ZSB0aW1lbGluZSBhbmQgZG8gYWxsIG9mIHRoYXQgbGF0ZXIs IHdoZW4gCnRoZSBzY2hlZHVsZXIgZGVjaWRlcyBpdCBpcyB0aW1lIHRvIGFjdHVhbGx5IHN1Ym1p dCBpdD8KCj4+PiBAQCAtODgzLDggKzg3NywxMyBAQCBndWNfY2xpZW50X2FsbG9jKHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4+Cj4+PiAJZ3VjX3Byb2NfZGVzY19pbml0KGd1 YywgY2xpZW50KTsKPj4+IAlndWNfY3R4X2Rlc2NfaW5pdChndWMsIGNsaWVudCk7Cj4+PiAtCWlm IChndWNfaW5pdF9kb29yYmVsbChndWMsIGNsaWVudCwgZGJfaWQpKQo+Pj4gLQkJZ290byBlcnI7 Cj4+PiArCj4+PiArCS8qIEZvciBydW50aW1lIGNsaWVudCBhbGxvY2F0aW9uIHdlIG5lZWQgdG8g ZW5hYmxlIHRoZSBkb29yYmVsbC4gTm90Cj4+PiArCSAqIHJlcXVpcmVkIHlldCBmb3IgdGhlIHN0 YXRpYyBleGVjYnVmX2NsaWVudCBhcyB0aGlzIHNwZWNpYWwga2VybmVsCj4+PiArCSAqIGNsaWVu dCBpcyBlbmFibGVkIGZyb20gaTkxNV9ndWNfc3VibWlzc2lvbl9lbmFibGUoKS4KPj4+ICsJICoK Pj4+ICsJICogZ3VjX3VwZGF0ZV9kb29yYmVsbF9pZChndWMsIGNsaWVudCwgZGJfaWQpOwo+Pj4g KwkgKi8KPj4KPj4gV2hhdCBmdXR1cmUgaXMgdGhlICJub3QgeWV0IiBwYXJ0IHJlZmVycmluZyB0 bz8gV2hhdCBhcmUgdGhlIG90aGVyIGNsaWVudHM/Cj4KPiBObyBpZGVhLiBUaGUgY29kZSBpcyBk ZXNpZ25lZCBhcm91bmQgdGhlIHByZW1pc2UgdGhhdCB1c2VycyBjb3VsZAo+IGFsbG9jYXRlIGd1 YyBjb250ZXh0cyBhbmQgZG8gZGlyZWN0IHN1Ym1pc3Npb24gb24gdGhlaXIgcHJpdmF0ZQo+IGNo YW5uZWxzLiBUaGF0IG1heSBiZSBtb3JlIGFwcHJvcHJpYXRlIGluIGEgYnVmZmVybGVzcyB3b3Js ZCwgYnV0IG5vdAo+IHlldC4KPgo+Pj4gCURSTV9ERUJVR19EUklWRVIoIm5ldyBwcmlvcml0eSAl dSBjbGllbnQgJXAgZm9yIGVuZ2luZShzKSAweCV4OiBjdHhfaW5kZXggJXVcbiIsCj4+PiAJCXBy aW9yaXR5LCBjbGllbnQsIGNsaWVudC0+ZW5naW5lcywgY2xpZW50LT5jdHhfaW5kZXgpOwo+Pj4g QEAgLTE0ODQsNiArMTQ4Myw5IEBAIGludCBpOTE1X2d1Y19zdWJtaXNzaW9uX2luaXQoc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+Pj4gCXN0cnVjdCBpbnRlbF9ndWMgKmd1YyA9 ICZkZXZfcHJpdi0+Z3VjOwo+Pj4gCXN0cnVjdCBpOTE1X3ZtYSAqdm1hOwo+Pj4KPj4+ICsJaWYg KCFIQVNfR1VDX1NDSEVEKGRldl9wcml2KSkKPj4+ICsJCXJldHVybiAwOwo+Pgo+PiBXaHkgZGlk IHlvdSBoYXZlIHRvIGFkZCB0aGlzIGh1bms/IEkgdGhpbmsgdGhpcyBmdW5jdGlvbiBkb2VzIG5v dAo+PiBnZXQgY2FsbGVkIHVubGVzcyB0aGVyZSBpcyBhIEd1Qy4KPgo+IEkgdG9vIHRob3VnaHQg dGhhdCBpdCB3b3VsZCBub3QgY2FsbGVkIHdpdGhvdXQgYSBndWMuCgpCdXQgaXQgaXMgb3Igd2hh dD8KCj4+PiBpbnQgaTkxNV9ndWNfc3VibWlzc2lvbl9lbmFibGUoc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2KQo+Pj4gewo+Pj4gCXN0cnVjdCBpbnRlbF9ndWMgKmd1YyA9ICZkZXZf cHJpdi0+Z3VjOwo+Pj4gLQlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcXVlc3Q7Cj4+ PiAtCXN0cnVjdCBpOTE1X2d1Y19jbGllbnQgKmNsaWVudDsKPj4+ICsJc3RydWN0IGk5MTVfZ3Vj X2NsaWVudCAqY2xpZW50ID0gZ3VjLT5leGVjYnVmX2NsaWVudDsKPj4+IAlzdHJ1Y3QgaW50ZWxf ZW5naW5lX2NzICplbmdpbmU7Cj4+PiAJZW51bSBpbnRlbF9lbmdpbmVfaWQgaWQ7Cj4+Pgo+Pj4g LQkvKiBjbGllbnQgZm9yIGV4ZWNidWYgc3VibWlzc2lvbiAqLwo+Pj4gLQljbGllbnQgPSBndWNf Y2xpZW50X2FsbG9jKGRldl9wcml2LAo+Pj4gLQkJCQkgIElOVEVMX0lORk8oZGV2X3ByaXYpLT5y aW5nX21hc2ssCj4+PiAtCQkJCSAgR1VDX0NUWF9QUklPUklUWV9LTURfTk9STUFMLAo+Pj4gLQkJ CQkgIGRldl9wcml2LT5rZXJuZWxfY29udGV4dCk7Cj4+PiAtCWlmICghY2xpZW50KSB7Cj4+PiAt CQlEUk1fRVJST1IoIkZhaWxlZCB0byBjcmVhdGUgbm9ybWFsIEd1QyBjbGllbnQhXG4iKTsKPj4+ IC0JCXJldHVybiAtRU5PTUVNOwo+Pj4gLQl9Cj4+PiArCWlmICghY2xpZW50KQo+Pj4gKwkJcmV0 dXJuIC1FTk9ERVY7Cj4+Pgo+Pj4gLQlndWMtPmV4ZWNidWZfY2xpZW50ID0gY2xpZW50Owo+Pj4g KwlndWNfcmVzZXRfd3EoY2xpZW50KTsKPj4+IAlob3N0Mmd1Y19zYW1wbGVfZm9yY2V3YWtlKGd1 YywgY2xpZW50KTsKPj4+IAlndWNfaW5pdF9kb29yYmVsbF9odyhndWMpOwo+Pj4KPj4+IAkvKiBU YWtlIG92ZXIgZnJvbSBtYW51YWwgY29udHJvbCBvZiBFTFNQIChleGVjbGlzdHMpICovCj4+PiAJ Zm9yX2VhY2hfZW5naW5lKGVuZ2luZSwgZGV2X3ByaXYsIGlkKSB7Cj4+PiArCQlzdHJ1Y3QgZHJt X2k5MTVfZ2VtX3JlcXVlc3QgKnJxOwo+Pj4gKwo+Pj4gCQllbmdpbmUtPnN1Ym1pdF9yZXF1ZXN0 ID0gaTkxNV9ndWNfc3VibWl0Owo+Pj4gCQllbmdpbmUtPnNjaGVkdWxlID0gTlVMTDsKPj4+Cj4+ PiAJCS8qIFJlcGxheSB0aGUgY3VycmVudCBzZXQgb2YgcHJldmlvdXNseSBzdWJtaXR0ZWQgcmVx dWVzdHMgKi8KPj4+IC0JCWxpc3RfZm9yX2VhY2hfZW50cnkocmVxdWVzdCwKPj4+IC0JCQkJICAg ICZlbmdpbmUtPnRpbWVsaW5lLT5yZXF1ZXN0cywgbGluaykgewo+Pj4gKwkJbGlzdF9mb3JfZWFj aF9lbnRyeShycSwgJmVuZ2luZS0+dGltZWxpbmUtPnJlcXVlc3RzLCBsaW5rKSB7Cj4+PiAJCQlj bGllbnQtPndxX3JzdmQgKz0gc2l6ZW9mKHN0cnVjdCBndWNfd3FfaXRlbSk7Cj4+PiAtCQkJaWYg KGk5MTVfc3dfZmVuY2VfZG9uZSgmcmVxdWVzdC0+c3VibWl0KSkKPj4+IC0JCQkJaTkxNV9ndWNf c3VibWl0KHJlcXVlc3QpOwo+Pgo+PiBpOTE1X3N3X2ZlbmNlX2RvbmUgY2hlY2sgaXMgbm90IG5l ZWRlZCBiZWNhdXNlIG9ubHkgc3VibWl0LXJlYWR5Cj4+IHJlcXVlc3RzIGNhbiBiZSBvbiB0aGUg ZW5naW5lIHRpbWVsaW5lPwo+Cj4gTW9yZSBzbywgb25seSByZXF1ZXN0cyB0aGF0IGhhdmUgbm90 IG9ubHkgcGFzc2VkIHRoZSBzdWJtaXQgZmVuY2UgYnV0Cj4gYWxzbyBoYXZlIHRoZSBleGVjdXRl IGZlbmNlIHNpZ25hbGVkIGNhbiBiZSBvbiB0aGUgZW5naW5lL2V4ZWN1dGlvbgo+IHRpbWVsaW5l LiAoRGlzdGluY3Rpb24gaXMgbW9yZSBpbnRlcmVzdGluZyB3aGVuIHRoZSBzdyBzY2hlZHVsZXIg ZGVsYXlzCj4gdGhlIGV4ZWN1dGUuKQoKSG0geWVzLCB0aGF0IGlzIGNvcnJlY3QuCgpQYXRjaCBp dHNlbGYgbG9va2VkIGZpbmUgdG8gbWUuIEl0IHdhcyBqdXN0IGNvbXBsZXhpdHkgd2hpY2ggbWFk ZSBtZSAKd29uZGVyIGlmIHdlIGNvdWxkbid0IGhhdmUgdGFrZW4gYSBkaWZmZXJlbnQgcm91dGUu IEJ1dCB0aGF0IHdhcyBsb25nIAp0aW1lIGFnbyBzbyBub3QgcmVsZXZhbnQgdG8gdGhpcyBwYXRj aCBhbnl3YXkuCgpSZXZpZXdlZC1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGlu dGVsLmNvbT4KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==