From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [Intel-gfx] [PATCH 4/5] drm/atomic: Fix freeing connector/plane state too early by tracking commits, v2. Date: Wed, 30 Aug 2017 17:44:41 +0300 Message-ID: <2349256.7VF7E026Rs@avalon> References: <20170830121752.31291-1-maarten.lankhorst@linux.intel.com> <1874864.FOqojDSi1Q@avalon> <20170830141736.j5gm537b5xwg5o3n@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170830141736.j5gm537b5xwg5o3n@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkbmVzZGF5LCAzMCBBdWd1c3QgMjAxNyAxNzoxNzozNiBFRVNUIERhbmllbCBWZXR0ZXIg d3JvdGU6Cj4gT24gV2VkLCBBdWcgMzAsIDIwMTcgYXQgMDU6MTA6NDNQTSArMDMwMCwgTGF1cmVu dCBQaW5jaGFydCB3cm90ZToKPiA+IEhpIE1hYXJ0ZW4sCj4gPiAKPiA+IFRoYW5rIHlvdSBmb3Ig dGhlIHBhdGNoLgo+ID4gCj4gPiBPbiBXZWRuZXNkYXksIDMwIEF1Z3VzdCAyMDE3IDE1OjE3OjUx IEVFU1QgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6Cj4gPiA+IEN1cnJlbnRseSB3ZSBuZWF0bHkg dHJhY2sgdGhlIGNydGMgc3RhdGUsIGJ1dCBmb3JnZXQgdG8gbG9vayBhdAo+ID4gPiBwbGFuZS9j b25uZWN0b3Igc3RhdGUuCj4gPiA+IAo+ID4gPiBXaGVuIGRvaW5nIGEgbm9uYmxvY2tpbmcgbW9k ZXNldCwgaW1tZWRpYXRlbHkgZm9sbG93ZWQgYnkgYSBzZXRwcm9wCj4gPiA+IGJlZm9yZSB0aGUg bW9kZXNldCBjb21wbGV0ZXMsIHRoZSBzZXRwcm9wIHdpbGwgc2VlIHRoZSBtb2Rlc2V0cyBuZXcK PiA+ID4gc3RhdGUgYXMgdGhlIG9sZCBzdGF0ZSBhbmQgZnJlZSBpdC4KPiA+ID4gCj4gPiA+IFRo aXMgaGFzIHRvIGJlIHNvbHZlZCBieSB3YWl0aW5nIGZvciBod19kb25lIG9uIHRoZSBjb25uZWN0 b3IsIGV2ZW4KPiA+ID4gaWYgaXQncyBub3QgYXNzaWduZWQgdG8gYSBjcnRjLiBXaGVuIGEgY29u bmVjdG9yIGlzIHVuYm91bmQgd2UgdGFrZQo+ID4gPiB0aGUgbGFzdCBjcnRjIGNvbW1pdCwgYW5k IHdoZW4gaXQgc3RheXMgdW5ib3VuZCB3ZSBjcmVhdGUgYSBuZXcKPiA+ID4gZmFrZSBjcnRjIGNv bW1pdCBmb3IgdGhhdCBnZXRzIHNpZ25hbGVkIG9uIGh3X2RvbmUgZm9yIGFsbCB0aGUKPiA+ID4g cGxhbmVzL2Nvbm5lY3RvcnMuCj4gPiA+IAo+ID4gPiBXZSB3YWl0IGZvciBpdCB0aGUgc2FtZSB3 YXkgYXMgd2UgZG8gZm9yIGNydGMncywgd2hpY2ggd2lsbCBtYWtlCj4gPiA+IHN1cmUgd2UgbmV2 ZXIgcnVuIGludG8gYSB1c2UtYWZ0ZXItZnJlZSBzaXR1YXRpb24uCj4gPiA+IAo+ID4gPiBDaGFu Z2VzIHNpbmNlIHYxOgo+ID4gPiAtIE9ubHkgY3JlYXRlIGEgc2luZ2xlIGRpc2FibGUgY29tbWl0 LiAoZGFudmV0KQo+ID4gPiAtIEZpeCBsZWFrIGluIGludGVsX2xlZ2FjeV9jdXJzb3JfdXBkYXRl Lgo+ID4gPiAKPiA+ID4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4u bGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiA+ID4gVGVzdGNhc2U6IGttc19hdG9taWNfdHJh bnNpdGlvbi5wbGFuZS11c2UtYWZ0ZXItbm9uYmxvY2tpbmctdW5iaW5kKgo+ID4gPiBDYzogTGF1 cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgo+ID4gPiAt LS0KPiA+ID4gCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jICAgICAgICAgfCAg IDQgKwo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMgIHwgMTU2Cj4g PiA+ICArKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLQo+ID4gPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgICAyICsKPiA+ID4gIGluY2x1ZGUvZHJtL2RybV9h dG9taWMuaCAgICAgICAgICAgICB8ICAxMiArKysKPiA+ID4gIGluY2x1ZGUvZHJtL2RybV9jb25u ZWN0b3IuaCAgICAgICAgICB8ICAgNyArKwo+ID4gPiAgaW5jbHVkZS9kcm0vZHJtX3BsYW5lLmgg ICAgICAgICAgICAgIHwgICA3ICsrCj4gPiA+ICA2IGZpbGVzIGNoYW5nZWQsIDE4MiBpbnNlcnRp b25zKCspLCA2IGRlbGV0aW9ucygtKQo+ID4gPiAKPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9kcm1fYXRvbWljLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jCj4gPiA+ IGluZGV4IDJjY2U0OGYyMDNlMC4uNzVmNWY3NGRlOWJmIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1f YXRvbWljLmMKPiA+ID4gQEAgLTE5Miw2ICsxOTIsMTAgQEAgdm9pZCBkcm1fYXRvbWljX3N0YXRl X2RlZmF1bHRfY2xlYXIoc3RydWN0Cj4gPiA+IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlKSB9Cj4g PiA+IAo+ID4gPiAgCXN0YXRlLT5udW1fcHJpdmF0ZV9vYmpzID0gMDsKPiA+ID4gCj4gPiA+ICsJ aWYgKHN0YXRlLT5mYWtlX2NvbW1pdCkgewo+ID4gPiArCQlkcm1fY3J0Y19jb21taXRfcHV0KHN0 YXRlLT5mYWtlX2NvbW1pdCk7Cj4gPiA+ICsJCXN0YXRlLT5mYWtlX2NvbW1pdCA9IE5VTEw7Cj4g PiA+ICsJfQo+ID4gPiAKPiA+ID4gIH0KPiA+ID4gIEVYUE9SVF9TWU1CT0woZHJtX2F0b21pY19z dGF0ZV9kZWZhdWx0X2NsZWFyKTsKPiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+ID4gPiBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRv bWljX2hlbHBlci5jIGluZGV4IDhjY2I4YjY1MzZjMC4uMDM0ZjU2M2ZiMTMwCj4gPiA+IDEwMDY0 NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+ID4gPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+ID4gPiBAQCAtMTY0NCw2 ICsxNjQ0LDQwIEBAIHN0YXRpYyB2b2lkIHJlbGVhc2VfY3J0Y19jb21taXQoc3RydWN0IGNvbXBs ZXRpb24KPiA+ID4gKmNvbXBsZXRpb24pIGRybV9jcnRjX2NvbW1pdF9wdXQoY29tbWl0KTsKPiA+ ID4gCj4gPiA+ICB9Cj4gPiA+IAo+ID4gPiArc3RhdGljIHZvaWQgaW5pdF9jb21taXQoc3RydWN0 IGRybV9jcnRjX2NvbW1pdCAqY29tbWl0LCBzdHJ1Y3QgZHJtX2NydGMKPiA+ID4gKmNydGMpCj4g PiA+ICt7Cj4gPiAKPiA+IFlvdSBjb3VsZCBhbGxvY2F0ZSB0aGUgY29tbWl0IGluIHRoaXMgZnVu Y3Rpb24gdG9vLCB0aGUga3phbGxvYygpIGlzCj4gPiBjdXJyZW50bHkgZHVwbGljYXRlZC4gVGhl IGZ1bmN0aW9uIHNob3VsZCBwcm9iYWJseSBiZSBjYWxsZWQKPiA+IGFsbG9jX2NvbW1pdCgpIHRo ZW4uPiAKPiA+ID4gKwlpbml0X2NvbXBsZXRpb24oJmNvbW1pdC0+ZmxpcF9kb25lKTsKPiA+ID4g Kwlpbml0X2NvbXBsZXRpb24oJmNvbW1pdC0+aHdfZG9uZSk7Cj4gPiA+ICsJaW5pdF9jb21wbGV0 aW9uKCZjb21taXQtPmNsZWFudXBfZG9uZSk7Cj4gPiA+ICsJSU5JVF9MSVNUX0hFQUQoJmNvbW1p dC0+Y29tbWl0X2VudHJ5KTsKPiA+ID4gKwlrcmVmX2luaXQoJmNvbW1pdC0+cmVmKTsKPiA+ID4g Kwljb21taXQtPmNydGMgPSBjcnRjOwo+ID4gPiArfQo+ID4gPiArCj4gPiA+ICtzdGF0aWMgc3Ry dWN0IGRybV9jcnRjX2NvbW1pdCAqCj4gPiA+ICtmYWtlX29yX2NydGNfY29tbWl0KHN0cnVjdCBk cm1fYXRvbWljX3N0YXRlICpzdGF0ZSwgc3RydWN0IGRybV9jcnRjCj4gPiA+ICpjcnRjKQo+ID4g PiArewo+ID4gPiArCXN0cnVjdCBkcm1fY3J0Y19jb21taXQgKmNvbW1pdDsKPiA+ID4gKwo+ID4g PiArCWlmIChjcnRjKSB7Cj4gPiA+ICsJCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqbmV3X2NydGNf c3RhdGU7Cj4gPiA+ICsKPiA+ID4gKwkJbmV3X2NydGNfc3RhdGUgPSBkcm1fYXRvbWljX2dldF9u ZXdfY3J0Y19zdGF0ZShzdGF0ZSwgY3J0Yyk7Cj4gPiA+ICsKPiA+ID4gKwkJY29tbWl0ID0gbmV3 X2NydGNfc3RhdGUtPmNvbW1pdDsKPiA+ID4gKwl9IGVsc2UgaWYgKCFzdGF0ZS0+ZmFrZV9jb21t aXQpIHsKPiA+ID4gKwkJc3RhdGUtPmZha2VfY29tbWl0ID0gY29tbWl0ID0ga3phbGxvYyhzaXpl b2YoKmNvbW1pdCksIApHRlBfS0VSTkVMKTsKPiA+ID4gKwkJaWYgKCFjb21taXQpCj4gPiA+ICsJ CQlyZXR1cm4gTlVMTDsKPiA+ID4gKwo+ID4gPiArCQlpbml0X2NvbW1pdChjb21taXQsIE5VTEwp Owo+ID4gPiArCX0gZWxzZQo+ID4gPiArCQljb21taXQgPSBzdGF0ZS0+ZmFrZV9jb21taXQ7Cj4g PiA+ICsKPiA+ID4gKwlkcm1fY3J0Y19jb21taXRfZ2V0KGNvbW1pdCk7Cj4gPiAKPiA+IEkgYmVs aWV2ZSB0aGUgcmVmZXJlbmNlIGNvdW50aW5nIGlzIHJpZ2h0LiBUaGUgZG91YmxlIHJlZmVyZW5j ZSBpbiB0aGUKPiA+IHNlY29uZCBjYXNlIChrcmVmX2luaXQoKSB3aGVuIGluaXRpYWxpemluZyB0 aGUgY29tbWl0IGFuZAo+ID4gZHJtX2NydGNfY29tbWl0X2dldCgpKSBzaG91bGQgbm90IGNhdXNl IGEgbGVhay4gVGhlIGtyZWZfaW5pdCgpIHRha2VzIGEKPiA+IHJlZmVyZW5jZSB0byBzdG9yZSB0 aGUgY29tbWl0IGluIHN0YXRlLT5mYWtlX2NvbW1pdCwgcmVsZWFzZWQgaW4KPiA+IGRybV9hdG9t aWNfc3RhdGVfZGVmYXVsdF9jbGVhcigpLCBhbmQgdGhlIGRybV9jcnRjX2NvbW1pdF9nZXQoKSB0 YWtlcyBhCj4gPiByZWZlcmVuY2UgcmV0dXJuZWQgYnkgdGhlIGZ1bmN0aW9uLCBzdG9yZWQgaW4g bmV3Xypfc3RhdGUtPmNvbW1pdCBieSB0aGUKPiA+IGNhbGxlci4KPiA+IAo+ID4gVGhpcyBiZWlu ZyBzYWlkLCBJIHRoaW5rIHRoZSByZWZlcmVuY2UgY291bnRpbmcgaXMgY29uZnVzaW5nLCBhcyBw cm92ZWQgYnkKPiA+IERhbmllbCB0aGlua2luZyB0aGVyZSB3YXMgYSBsZWFrIGhlcmUgKG9yIGJ5 IG1lIHRoaW5raW5nIHRoZXJlJ3Mgbm8gbGVhawo+ID4gd2hpbGUgdGhlcmUncyBvbmUgOi0pKS4g VG8gbWFrZSB0aGUgaW1wbGVtZW50YXRpb24gY2xlYXJlciwgSSBwcm9wb3NlCj4gPiB0dXJuaW5n IHRoZSBkZWZpbml0aW9uIG9mIGRybV9jcnRjX2NvbW1pdF9nZXQoKSB0bwo+ID4gCj4gPiBzdGF0 aWMgaW5saW5lIHN0cnVjdCBkcm1fY3J0Y19jb21taXQgKgo+ID4gZHJtX2NydGNfY29tbWl0X2dl dChzdHJ1Y3QgZHJtX2NydGNfY29tbWl0ICpjb21taXQpCj4gPiB7Cj4gPiAKPiA+IAlrcmVmX2dl dCgmY29tbWl0LT5yZWYpOwo+ID4gCXJldHVybiBjb21taXQ7Cj4gPiAKPiA+IH0KPiA+IAo+ID4g YW5kIHdyaXRpbmcgdGhpcyBmdW5jdGlvbiBhcwo+ID4gCj4gPiAvKiBSZXR1cm4gYSBuZXcgcmVm ZXJlbmNlIHRvIHRoZSBjb21taXQgb2JqZWN0ICovCj4gPiBzdGF0aWMgc3RydWN0IGRybV9jcnRj X2NvbW1pdCAqCj4gPiBmYWtlX29yX2NydGNfY29tbWl0KHN0cnVjdCBkcm1fYXRvbWljX3N0YXRl ICpzdGF0ZSwgc3RydWN0IGRybV9jcnRjICpjcnRjKQo+ID4gewo+ID4gCj4gPiAJc3RydWN0IGRy bV9jcnRjX2NvbW1pdCAqY29tbWl0Owo+ID4gCQo+ID4gCWlmIChjcnRjKSB7Cj4gPiAJCj4gPiAJ CXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqbmV3X2NydGNfc3RhdGU7Cj4gPiAJCQo+ID4gCQluZXdf Y3J0Y19zdGF0ZSA9IGRybV9hdG9taWNfZ2V0X25ld19jcnRjX3N0YXRlKHN0YXRlLCBjcnRjKTsK PiA+IAkJCj4gPiAJCWNvbW1pdCA9IG5ld19jcnRjX3N0YXRlLT5jb21taXQ7Cj4gPiAJCj4gPiAJ fSBlbHNlIHsKPiA+IAkKPiA+IAkJaWYgKCFzdGF0ZS0+ZmFrZV9jb21taXQpCj4gPiAJCQo+ID4g CQkJc3RhdGUtPmZha2VfY29tbWl0ID0gYWxsb2NfY29tbWl0KE5VTEwpOwo+ID4gCQkKPiA+IAkJ Y29tbWl0ID0gc3RhdGUtPmZha2VfY29tbWl0Owo+ID4gCQo+ID4gCX0KPiA+IAkKPiA+IAlyZXR1 cm4gZHJtX2NydGNfY29tbWl0X2dldChjb21taXQpOwo+ID4gCj4gPiB9Cj4gCj4gKzEgb24gc29t ZXRoaW5nIGxpa2UgdGhpcywgdGhlIGNvbXByZXNzZWQgbGF5b3V0IHdpdGggYXNzaWduaW5nIGJv dGgKPiBjb21taXQgYW5kIC0+ZmFrZV9jb21taXQgaXMgd2hhdCB0cmlja2VkIG1lIGludG8gc2Vl aW5nIGEgbGVhay4KCldoYXQgSSB0aGluayBtYWtlcyBpdCBjbGVhcmVyIGlzIHRvIHN0b3JlIHRo ZSByZXR1cm4gdmFsdWUgb2YgZnVuY3Rpb25zIApyZXR1cm5pbmcgYSByZWZlcmVuY2UgZGlyZWN0 bHkgaW4gdGhlIHBvaW50ZXIgdGhhdCBzdG9yZXMgdGhlIHJlZmVyZW5jZS4gClRoYXQncyB3aHkg SSBwcmVmZXIKCjEuCQlpZiAoIXN0YXRlLT5mYWtlX2NvbW1pdCkKMi4JCQlzdGF0ZS0+ZmFrZV9j b21taXQgPSBhbGxvY19jb21taXQoTlVMTCk7CjMuCjQuCQljb21taXQgPSBzdGF0ZS0+ZmFrZV9j b21taXQ7CgpMaW5lIDIgc3RvcmVzIHRoZSBwb2ludGVyIGluIGFuIG9iamVjdCB0aGF0IHRodXMg cmVxdWlyZXMgYSByZWZlcmVuY2UsIHdoaWNoIAppcyByZXR1cm5lZCBieSBhbGxvY19jb21taXQo KS4gTGluZSA0IHN0b3JlcyB0aGUgcG9pbnRlciBpbiBhIGxvY2FsIHZhcmlhYmxlLCAKYW5kIHRo dXMgZG9lc24ndCByZXF1aXJlIGEgcmVmZXJlbmNlLgoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBp bmNoYXJ0CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK