From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ted Phelps <phelps@gnusto.com>
Subject: Re: [PATCH 10/15] drm/i915: Invalidate fenced read
	domains upon flush
Date: Thu, 24 Mar 2011 23:52:43 +1000
Message-ID: <2363.1300974763@orpheus.gnusto.com>
References: <1300611539-24791-1-git-send-email-chris@chris-wilson.co.uk>
	<1300611539-24791-11-git-send-email-chris@chris-wilson.co.uk>
	<2231.1300974478@orpheus.gnusto.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from laika.gnusto.com (laika.gnusto.com [207.44.178.75])
	by gabe.freedesktop.org (Postfix) with ESMTP id AFDFD9E7E6
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 24 Mar 2011 06:57:58 -0700 (PDT)
Received: from gnusto.com (orpheus.ipv6.gnusto.com
	[IPv6:2001:44b8:72d8:1a0:201:2ff:fe8f:d6a4])
	by laika.gnusto.com (8.14.3/8.14.3) with ESMTP id p2ODqiLY026463
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
	for <intel-gfx@lists.freedesktop.org>; Thu, 24 Mar 2011 08:52:46 -0500
Received: from orpheus.gnusto.com (localhost [127.0.0.1])
	by gnusto.com (8.14.4/8.14.4) with ESMTP id p2ODqhfH002364
	for <intel-gfx@lists.freedesktop.org>; Thu, 24 Mar 2011 23:52:43 +1000
In-reply-to: Your message of Thu, 24 Mar 2011 23:47:58 +1000.
	<2231.1300974478@orpheus.gnusto.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Ted Phelps writes:
> Chris Wilson writes:
> > Whenever we finish reading an object through a fence, for safety we
> > clear any GPU read domain and so invalidate any TLBs associated with
> > the fenced region upon its next use.
> 
> This change is causing a regression on my Sandybridge CPU (i7 2600K).
> The colours all look right, but the pixels aren't in the right order.
> I'll try to get a screen shot for you.

Grr...  Sorry, I've replied to the wrong patch.  That one is fine.  This
is the problematic one:

    commit fc8cf546f12a353bfd344bf922649c0d064fc3f0
    Author: Chris Wilson <chris@chris-wilson.co.uk>
    Date:   Fri Mar 18 19:39:59 2011 +0000

        drm/i915: Cleanup handling of last_fenced_seqno
    
        Cc: Andy Whitcroft <apw@canonical.com>
        Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
        Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

>>From drm-intel-staging.

-Ted