From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C6FEC433E0 for ; Fri, 19 Feb 2021 06:06:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C2B7664EB2 for ; Fri, 19 Feb 2021 06:06:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C2B7664EB2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DA4036E30D; Fri, 19 Feb 2021 06:06:15 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2309B6E30D for ; Fri, 19 Feb 2021 06:06:13 +0000 (UTC) IronPort-SDR: W9zYnaRhPqzGaGi5aZtgrkzoQDkwO34GMZrnKHP0EsMYHG5I0P7ioPAP8YQECD31yMXKahGjCF /sxbowZrZlEg== X-IronPort-AV: E=McAfee;i="6000,8403,9899"; a="245198615" X-IronPort-AV: E=Sophos;i="5.81,189,1610438400"; d="scan'208";a="245198615" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2021 22:06:12 -0800 IronPort-SDR: llnJFfyEqocWfcNAMxYYZ5cN66L+Fpki96CW5085hOOAah9Q2j4iECLIdyBn62w5BWQAGjSeg8 n5Iri5ePGS0g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,189,1610438400"; d="scan'208";a="581571758" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga005.jf.intel.com with ESMTP; 18 Feb 2021 22:06:12 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 18 Feb 2021 22:06:11 -0800 Received: from hasmsx602.ger.corp.intel.com (10.184.107.142) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 18 Feb 2021 22:06:10 -0800 Received: from hasmsx602.ger.corp.intel.com ([10.184.107.142]) by HASMSX602.ger.corp.intel.com ([10.184.107.142]) with mapi id 15.01.2106.002; Fri, 19 Feb 2021 08:06:08 +0200 From: "Winkler, Tomas" To: "De Marchi, Lucas" Thread-Topic: [Intel-gfx] [RFC PATCH 3/9] drm/i915/spi: add driver for on-die spi device Thread-Index: AQHXBJBcj4Goi4XIwEe9K9Ji08dc+apcDHIAgADGOPCAALlRAIAAJMVw Date: Fri, 19 Feb 2021 06:06:08 +0000 Message-ID: <23876b68716b4c5085145b54029b90bc@intel.com> References: <20210216181925.650082-1-tomas.winkler@intel.com> <20210216181925.650082-4-tomas.winkler@intel.com> <87blcjarof.fsf@intel.com> <20210218094916.brm7j62if573xu5c@ldmartin-desk1> In-Reply-To: <20210218094916.brm7j62if573xu5c@ldmartin-desk1> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [10.22.254.132] MIME-Version: 1.0 Subject: Re: [Intel-gfx] [RFC PATCH 3/9] drm/i915/spi: add driver for on-die spi device X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Miquel Raynal , Richard Weinberger , "intel-gfx@lists.freedesktop.org" , "Usyskin, Alexander" , "linux-mtd@lists.infradead.org" , "Lubart, Vitaly" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" > > On Wed, Feb 17, 2021 at 08:58:12PM +0000, Winkler, Tomas wrote: > >> > >> On Tue, 16 Feb 2021, Tomas Winkler wrote: > >> > Add the platform driver for i915 on-die spi device, exposed via mfd > >> > framework. > >> > > >> > Cc: Rodrigo Vivi > >> > Cc: Lucas De Marchi > >> > Signed-off-by: Tomas Winkler > >> > --- > >> > drivers/gpu/drm/i915/Kconfig | 2 + > >> > drivers/gpu/drm/i915/Makefile | 3 + > >> > drivers/gpu/drm/i915/spi/intel_spi_drv.c | 116 > >> > +++++++++++++++++++++++ > >> > 3 files changed, 121 insertions(+) create mode 100644 > >> > drivers/gpu/drm/i915/spi/intel_spi_drv.c > >> > > >> > diff --git a/drivers/gpu/drm/i915/Kconfig > >> > b/drivers/gpu/drm/i915/Kconfig index abcaa8da45ac..13c870e5878e > >> > 100644 > >> > --- a/drivers/gpu/drm/i915/Kconfig > >> > +++ b/drivers/gpu/drm/i915/Kconfig > >> > @@ -27,6 +27,8 @@ config DRM_I915 > >> > select CEC_CORE if CEC_NOTIFIER > >> > select VMAP_PFN > >> > select MFD_CORE > >> > + select MTD > >> > >> Selecting MTD does not seem to be a popular thing to do, which is > >> usually a clue it's probably the wrong thing to do. > >Depends, if it is not selected you'll end with wrongly configured system. > > no. I believe the idea is that having a CONFIG_I915_SPI, you could do > > depends on MTD > > like the other drivers doing similar thing: > > git grep MTD -- ':(exclude)drivers/mtd' ':(exclude)arch/' '*Kconfig' I know the pattern and it can be done, the issue is that mtd is used mostly in embedded systems so it is not selected by the desktop distros. The intel spi both on PCH and in GFX takes this into different direction and usage. Thanks Tomas _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx