Re: [PATCH 18/24] drm/etnaviv: switch to postclose

Daniel Vetter
2017-03-08T18:15:42Z

On Wed, Mar 08, 2017 at 05:09:45PM +0100, Lucas Stach wrote:
> Am Mittwoch, den 08.03.2017, 15:12 +0100 schrieb Daniel Vetter:
> > I didn't spot anything that would require ordering here (well not
> > anywhere else either), and I'm trying to unify at least modern
> > drivers
> > on one close hook.
> >
> > Cc: Lucas Stach <l.stach@pengutronix.de>
> > Cc: Russell King <linux+etnaviv@armlinux.org.uk>
> > Cc: Christian Gmeiner <christian.gmeiner@gmail.com>
> > Cc: etnaviv@lists.freedesktop.org
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
>
> Acked-by: Lucas Stach <l.stach@pengutronix.de>
>
> for merging through drm-misc

t-b would be great, this entire area is rather wonky and full of decades
of cargo-culting. I'm not sure I missed something important, so really
want each patch to see some testing before we merge it, if possible.
-Daniel

>
> > ---
> >  drivers/gpu/drm/etnaviv/etnaviv_drv.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> > b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> > index 587e45043542..289a9f8c6671 100644
> > --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> > +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> > @@ -111,7 +111,7 @@ static int etnaviv_open(struct drm_device *dev,
> > struct drm_file *file)
> >   return 0;
> >  }
> >
> > -static void etnaviv_preclose(struct drm_device *dev, struct drm_file
> > *file)
> > +static void etnaviv_postclose(struct drm_device *dev, struct
> > drm_file *file)
> >  {
> >   struct etnaviv_drm_private *priv = dev->dev_private;
> >   struct etnaviv_file_private *ctx = file->driver_priv;
> > @@ -488,7 +488,7 @@ static struct drm_driver etnaviv_drm_driver = {
> >   DRIVER_PRIME |
> >   DRIVER_RENDER,
> >   .open               = etnaviv_open,
> > - .preclose           = etnaviv_preclose,
> > + .postclose           = etnaviv_postclose,
> >   .gem_free_object_unlocked = etnaviv_gem_free_object,
> >   .gem_vm_ops         = &vm_ops,
> >   .prime_handle_to_fd = drm_gem_prime_handle_to_fd,

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org