Re: [PATCH 20/24] drm/exynos: Merge pre/postclose hooks

Inki Dae
2017-03-15T00:54:45Z

2017년 03월 14일 22:28에 Daniel Vetter 이(가) 쓴 글:
> On Mon, Mar 13, 2017 at 03:18:05PM -0400, Sean Paul wrote:
>> On Wed, Mar 08, 2017 at 03:12:53PM +0100, Daniel Vetter wrote:
>>> Again no apparent explanation for the split except hysterical raisins.
>>> Merging them also makes it a bit more obviuos what's going on wrt the
>>> runtime pm refdancing.
>>
>> Commit message copypasta.
>
> Hm, yeah. Inki, can you pls adjust that when merging to exynos-next? Just
> drop the last sentence that talks about pm refdancing.
> -Daniel

No problem. :)

Thanks,
Inki Dae

>
>>
>> The code is
>>
>> Reviewed-by: Sean Paul <seanpaul@chromium.org>
>>
>>>
>>> Cc: Inki Dae <inki.dae@samsung.com>
>>> Cc: Joonyoung Shim <jy0922.shim@samsung.com>
>>> Cc: Seung-Woo Kim <sw0312.kim@samsung.com>
>>> Cc: Kyungmin Park <kyungmin.park@samsung.com>
>>> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
>>> ---
>>> drivers/gpu/drm/exynos/exynos_drm_drv.c | 8 +-------
>>> 1 file changed, 1 insertion(+), 7 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c
>>> index b4522f67b3cb..180e3c9884e5 100644
>>> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
>>> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
>>> @@ -194,14 +194,9 @@ static int exynos_drm_open(struct drm_device *dev, struct drm_file *file)
>>> return ret;
>>> }
>>>
>>> -static void exynos_drm_preclose(struct drm_device *dev,
>>> - struct drm_file *file)
>>> -{
>>> - exynos_drm_subdrv_close(dev, file);
>>> -}
>>> -
>>> static void exynos_drm_postclose(struct drm_device *dev, struct drm_file *file)
>>> {
>>> + exynos_drm_subdrv_close(dev, file);
>>> kfree(file->driver_priv);
>>> file->driver_priv = NULL;
>>> }
>>> @@ -259,7 +254,6 @@ static struct drm_driver exynos_drm_driver = {
>>> .load = exynos_drm_load,
>>> .unload = exynos_drm_unload,
>>> .open = exynos_drm_open,
>>> - .preclose = exynos_drm_preclose,
>>> .lastclose = exynos_drm_lastclose,
>>> .postclose = exynos_drm_postclose,
>>> .gem_free_object_unlocked = exynos_drm_gem_free_object,
>>> --
>>> 2.11.0
>>>
>>> _______________________________________________
>>> Intel-gfx mailing list
>>> Intel-gfx@lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org