Re: [PATCH intel-gpu-tools] tools: Added intel_dpio_read and intel_dpio_write

Ben Widawsky
2012-08-06T21:21:17Z

On 2012-08-06 00:16, Daniel Vetter wrote:
> On Thu, Aug 02, 2012 at 09:06:48AM -0700, Ben Widawsky wrote:
>> On 2012-08-02 05:07, Vijay Purushothaman wrote:
>> >In Valleyview the DPLL and lane control registers are accessible
>> only
>> >through side band fabric called DPIO. Added two tools to read and
>> >write
>> >registers residing in this space.
>>
>> Could I convince you to use the centralized read/write mmio
>> functions?
>> Otherwise, everything seems fine to me here.
>
> I wonder whether we need some kernel interface for this, after all if
> the
> kernel touches this, too, things will blow up. Otoh the kernel only
> uses
> the dpio sideband regs at modeset time, so I guess the risk is
> minimal.
> -Daniel

It's the same as any register. As long as it's root only, bullets, gun,
and
target for foot are provided for free. Though I would like to converge
on
central API for register read and right.

--
Ben Widawsky, Intel Open Source Technology Center