From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v4 2/5] drm/i915: Watchdog timeout: IRQ handler for gen8+ Date: Tue, 19 Mar 2019 12:39:53 +0000 Message-ID: <25e7c81e-18fc-0676-dd27-d0a7823aaa41@linux.intel.com> References: <20190221025820.28447-1-carlos.santa@intel.com> <20190221025820.28447-3-carlos.santa@intel.com> <155143298308.5847.17161978101892410437@skylake-alporthouse-com> <62d65486-a45a-7cf9-1574-1c961be2ee9a@linux.intel.com> <1271220339df25098eb6305051972c80c125bc52.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8BF9589B12 for ; Tue, 19 Mar 2019 12:39:56 +0000 (UTC) In-Reply-To: <1271220339df25098eb6305051972c80c125bc52.camel@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Carlos Santa , Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Michel Thierry List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE4LzAzLzIwMTkgMDA6MTUsIENhcmxvcyBTYW50YSB3cm90ZToKPiBPbiBNb24sIDIwMTkt MDMtMTEgYXQgMTA6MzkgKzAwMDAsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+PiBPbiAwOC8wMy8y MDE5IDAzOjE2LCBDYXJsb3MgU2FudGEgd3JvdGU6Cj4+PiBPbiBGcmksIDIwMTktMDMtMDEgYXQg MDk6MzYgKzAwMDAsIENocmlzIFdpbHNvbiB3cm90ZToKPj4+Pj4KPj4+Pgo+Pj4+IFF1b3Rpbmcg Q2FybG9zIFNhbnRhICgyMDE5LTAyLTIxIDAyOjU4OjE2KQo+Pj4+PiArI2RlZmluZSBHRU44X1dB VENIRE9HXzEwMDBVUyhkZXZfcHJpdikKPj4+Pj4gd2F0Y2hkb2dfdG9fY2xvY2tfY291bnRzKGRl dl9wcml2LCAxMDAwKQo+Pj4+PiArc3RhdGljIHZvaWQgZ2VuOF93YXRjaGRvZ19pcnFfaGFuZGxl cih1bnNpZ25lZCBsb25nIGRhdGEpCj4+Pj4+ICt7Cj4+Pj4+ICsgICAgICAgc3RydWN0IGludGVs X2VuZ2luZV9jcyAqZW5naW5lID0gKHN0cnVjdAo+Pj4+PiBpbnRlbF9lbmdpbmVfY3MKPj4+Pj4g KilkYXRhOwo+Pj4+PiArICAgICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9 IGVuZ2luZS0+aTkxNTsKPj4+Pj4gKyAgICAgICB1bnNpZ25lZCBpbnQgaHVuZyA9IDA7Cj4+Pj4+ ICsgICAgICAgdTMyIGN1cnJlbnRfc2Vxbm89MDsKPj4+Pj4gKyAgICAgICBjaGFyIG1zZ1s4MF07 Cj4+Pj4+ICsgICAgICAgdW5zaWduZWQgaW50IHRtcDsKPj4+Pj4gKyAgICAgICBpbnQgbGVuOwo+ Pj4+PiArCj4+Pj4+ICsgICAgICAgLyogU3RvcCB0aGUgY291bnRlciB0byBwcmV2ZW50IGZ1cnRo ZXIgdGltZW91dAo+Pj4+PiBpbnRlcnJ1cHRzCj4+Pj4+ICovCj4+Pj4+ICsgICAgICAgSTkxNV9X UklURV9GVyhSSU5HX0NOVFIoZW5naW5lLT5tbWlvX2Jhc2UpLAo+Pj4+PiBnZXRfd2F0Y2hkb2df ZGlzYWJsZShlbmdpbmUpKTsKPj4+Pj4gKwo+Pj4+PiArICAgICAgIC8qIFJlYWQgdGhlIGhlYXJ0 YmVhdCBzZXFubyBvbmNlIGFnYWluIHRvIGNoZWNrIGlmIHdlCj4+Pj4+IGFyZQo+Pj4+PiBzdHVj az8gKi8KPj4+Pj4gKyAgICAgICBjdXJyZW50X3NlcW5vID0KPj4+Pj4gaW50ZWxfZW5naW5lX2dl dF9oYW5nY2hlY2tfc2Vxbm8oZW5naW5lKTsKPj4+Pgo+Pj4+IEkgaGF2ZSBzYWlkIHRoaXMgYmVm b3JlLCBidXQgdGhpcyBkb2Vzbid0IGV4aXN0IGVpdGhlciwgaXQncyBqdXN0Cj4+Pj4gYQo+Pj4+ IHRlbXBvcmFyeSBnbGl0Y2ggaW4gdGhlIG1hdHJpeC4KPj4+Pgo+Pj4KPj4+IENocmlzLCBUdnJ0 a28sIEkgbmVlZCBzb21lIGd1aWRhbmNlIG9uIGhvdyB0byBmaW5kIHRoZSBxdWlsdHkgc2Vxbm8K Pj4+IGR1cmluZyBhIGhhbmcsIGNhbiB5b3UgcGxlYXNlIGFkdmljZSBoZXJlIHdoYXQgdG8gZG8/ Cj4+Cj4+IFdoZW4gYW4gaW50ZXJydXB0IGZpcmVzIHlvdSBuZWVkIHRvIGFzY2VydGFpbiB3aGV0 aGVyIHRoZSBzYW1lCj4+IHJlcXVlc3QKPj4gd2hpY2ggZW5hYmxlZCB0aGUgd2F0Y2hkb2cgaXMg cnVubmluZywgY29ycmVjdD8KPj4KPj4gU28gSSB0aGluayB5b3Ugd291bGQgbmVlZCB0aGlzLCB3 aXRoIGEgZGlzY2xhaW1lciB0aGF0IEkgaGF2ZW4ndAo+PiB0aG91Z2h0Cj4+IGFib3V0IHRoZSBk ZXRhaWxzIHJlYWxseToKPj4KPj4gMS4gVGFrZSBhIHJlZmVyZW5jZSB0byB0aW1lbGluZSBod3Nw IHdoZW4gc2V0dGluZyB1cCB0aGUgd2F0Y2hkb2cgZm9yCj4+IGEKPj4gcmVxdWVzdC4KPj4KPj4g Mi4gU3RvcmUgdGhlIGluaXRpYWwgc2Vxbm8gYXNzb2NpYXRlZCB3aXRoIHRoaXMgcmVxdWVzdC4K Pj4KPj4gMy4gRm9yY2UgZW5hYmxlIHVzZXIgaW50ZXJydXB0cy4KPj4KPj4gNC4gV2hlbiB0aW1l b3V0IGZpcmVzLCBpbnNwZWN0IHRoZSBIV1NQIHNlcW5vIHRvIHNlZSBpZiB0aGUgcmVxdWVzdAo+ PiBjb21wbGV0ZWQgb3Igbm90Lgo+Pgo+PiA1LiBSZXNldCB0aGUgZW5naW5lIGlmIG5vdCBjb21w bGV0ZWQuCj4+Cj4+IDYuIFB1dCB0aGUgdGltZWxpbmUvaHdzcCByZWZlcmVuY2UuCj4gCj4gCj4g c3RhdGljIGludCBnZW44X2VtaXRfYmJfc3RhcnQoc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEsCj4g CQkJCQkJCXU2NCBvZmZzZXQsIHUzMgo+IGxlbiwKPiAJCQkJCQkJY29uc3QgdW5zaWduZWQKPiBp bnQgZmxhZ3MpCj4gewo+IAlzdHJ1Y3QgaTkxNV90aW1lbGluZSAqdGw7Cj4gCXUzMiBzZXFubzsK PiAKPiAJaWYgKGVuYWJsZV93YXRjaGRvZykgewo+IAkJLyogU3RhcnQgd2F0Y2hkb2cgdGltZXIg Ki8KPiAJCWNzID0gZ2VuOF9lbWl0X3N0YXJ0X3dhdGNoZG9nKHJxLCBjcyk7Cj4gCQl0bCA9IGNl LT5yaW5nLT50aW1lbGluZTsKPiAJCWk5MTVfdGltZWxpbmVfZ2V0X3NlcW5vKHRsLCBycSwgJnNl cW5vKTsKPiAJCS8qU3RvcmUgaW5pdGlhbCBod3NwIHNlcW5vIGFzc29jaWF0ZWQgd2l0aCB0aGlz IHJlcXVlc3QKPiAJCWVuZ2luZS0+d2F0Y2hkb2dfaHdzcF9zZXFubyA9IHRsLT5od3NwX3NlcW5v OwoKWW91IHNob3VsZCBub3QgbmVlZCB0byBhbGxvY2F0ZSBhIG5ldyBzZXFubyBhbmQgYWxzbyBo YXZpbmcgc29tZXRoaW5nIApzdG9yZWQgcGVyIGVuZ2luZSBkb2VzIG5vdCBtYWtlIGNsZWFyIGhv dyB3aWxsIHlvdSBzb2x2ZSBvdXQgb2Ygb3JkZXIuCgpNYXliZSB5b3UganVzdCBzZXQgdXAgdGhl IHRpbWVyLCB0aGVuIGxldHMgc2VlIGJlbG93Li4KCkFsc28sIGFyZSB5b3Ugbm90IHRyeWluZyB0 byBkbyB0aGUgc29mdHdhcmUgaW1wbGVtZW50YXRpb24gdG8gc3RhcnQgd2l0aD8KCj4gCX0KPiAK PiB9Cj4gCj4gc3RhdGljIHZvaWQgZ2VuOF93YXRjaGRvZ190YXNrbGV0KHVuc2lnbmVkIGxvbmcg ZGF0YSkKPiB7Cj4gCQlzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpycTsKPiAKPiAJCXJxID0gaW50ZWxf ZW5naW5lX2ZpbmRfYWN0aXZlX3JlcXVlc3QoZW5naW5lKTsKPiAKPiAJCS8qIEluc3BlY3QgdGhl IHdhdGNoZG9nIHNlcW5vIG9uY2UgYWdhaW4gZm9yCj4gY29tcGxldGlvbj8gKi8KPiAJCWlmICgh aTkxNV9zZXFub19wYXNzZWQoZW5naW5lLT53YXRjaGRvZ19od3NwX3NlcW5vLCBycS0KPj4gZmVu Y2Uuc2Vxbm8pKSB7Cj4gCQkJLy9SZXNldCBFbmdpbmUKPiAJCX0KPiB9CgpXaGF0IGhhcHBlbnMg aWYgeW91IHNpbXBseSByZXNldCB3aXRob3V0IGNoZWNraW5nIGFueXRoaW5nPyBZb3Uga25vdyBo dyAKdGltZXIgd291bGRuJ3QgaGF2ZSBmaXJlZCBpZiB0aGUgY29udGV4dCB3YXNuJ3QgcnVubmlu ZywgY29ycmVjdD8KCihJZ25vcmluZyB0aGUgcmFjZSBjb25kaXRpb24gYmV0d2VlbiBpbnRlcnJ1 cHQgcmFpc2VkIC0+IGh3IGludGVycnVwdCAKZGVsaXZlcmVkIC0+IHNlcnZpY2VkIC0+IHRhc2ts ZXQgc2NoZWR1bGVkIC0+IHRhc2tsZXQgcnVubmluZy4gV2hpY2ggbWF5IAptZWFuIHJlcXVlc3Qg aGFzIGNvbXBsZXRlZCBpbiB0aGUgbWVhbnRpbWUgYW5kIHlvdSByZXNldCB0aGUgZW5naW5lIGZv ciAKbm90aGluZy4gQnV0IHRoaXMgaXMgcHJvYmFibHkgbm90IDEwMCUgc29sdmFibGUuKQoKUmVn YXJkcywKClR2cnRrbwoKPiBUdnJ0a28sIGlzIHRoZSBhYm92ZSBhY2NlcHRhYmxlIHRvIGluc3Bl Y3Qgd2hldGhlciB0aGUgc2Vxbm8gaGFzCj4gY29tcGxldGVkPwo+IAo+IEkgbm90aWNlZCB0aGVy ZSdzIGEgaGVscGVyIGZ1bmN0aW9uIGk5MTVfcmVxdWVzdF9jb21wbGV0ZWQoc3RydWN0Cj4gaTkx NV9yZXF1ZXN0ICpycSkgYnV0IGl0IHdpbGwgcmVxdWlyZSBtZSB0byBtb2RpZnkgaXQgaW4gb3Jk ZXIgdG8gcGFzcwo+IDIgZGlmZmVyZW50IHNlcW5vcy4KPiAKPiBSZWdhcmRzLAo+IENhcmxvcwo+ IAo+Pgo+PiBJZiB0aGUgdXNlciBpbnRlcnJ1cHQgZmlyZXMgd2l0aCB0aGUgcmVxdWVzdCBjb21w bGV0ZWQgY2FuY2VsIHRoZQo+PiBhYm92ZQo+PiBvcGVyYXRpb25zLgo+Pgo+PiBUaGVyZSBjb3Vs ZCBiZSBhbiBpbmhlcmVudCByYWNlIGJldHdlZW4gaW5zcGVjdGluZyB0aGUgc2Vxbm8gYW5kCj4+ IGRlY2lkaW5nIHRvIHJlc2V0LiBOb3Qgc3VyZSBhdCB0aGUgbW9tZW50IHdoYXQgdG8gZG8uIE1h eWJlIGp1c3QgY2FsbAo+PiBpdAo+PiBiYWQgbHVjaz8KPj4KPj4gSSBhbHNvIHRoaW5rIGZvciB0 aGUgc29mdHdhcmUgaW1wbGVtZW50YXRpb24geW91IG5lZWQgdG8gZm9yY2Ugbm8KPj4gcmVxdWVz dCBjb2FsZXNjaW5nIGZvciBjb250ZXh0cyB3aXRoIHRpbWVvdXQgc2V0LiBCZWNhdXNlIHlvdSB3 YW50Cj4+IHRvCj4+IGhhdmUgMTAwJSBkZWZpbmVkIGJvcmRlcnMgZm9yIHJlcXVlc3QgaW4gYW5k IG91dCAtIHNpbmNlIHRoZSB0aW1lb3V0Cj4+IGlzCj4+IGRlZmluZWQgcGVyIHJlcXVlc3QuCj4+ Cj4+IEluIHRoaXMgY2FzZSB5b3UgZG9uJ3QgbmVlZCB0aGUgdXNlciBpbnRlcnJ1cHQgZm9yIHRo ZSB0cmFpbGluZyBlZGdlCj4+IHNpZ25hbCBidXQgY2FuIHVzZSBjb250ZXh0IGNvbXBsZXRlLiBN YXliZSBwdXR0aW5nIGhvb2tzIGludG8KPj4gY29udGV4dF9pbi9vdXQgaW4gaW50ZWxfbHJjLmMg d291bGQgd29yayB1bmRlciB0aGVzZSBjaXJjdW1zdGFuY2VzLgo+Pgo+PiBBbHNvIGlmIHByZWVt cHRlZCB5b3UgbmVlZCB0byBjYW5jZWwgdGhlIHRpbWVyIHNldHVwIGFuZCBzdG9yZQo+PiBlbGFw c2VkCj4+IGV4ZWN1dGlvbiB0aW1lLgo+Pgo+PiBPciBpdCBtYXkgbWFrZSBzZW5zZSB0byBqdXN0 IGRpc2FibGUgcHJlZW1wdGlvbiBmb3IgdGhlc2UgY29udGV4dHMuCj4+IE90aGVyd2lzZSB0aGVy ZSBpcyBubyBwb2ludCBpbiB0cnlpbmcgdG8gbWFuZGF0ZSB0aGUgdGltZW91dD8KPj4KPj4gQnV0 IGl0IGlzIGFsc28ga2luZCBvZiBiYWQgc2luY2Ugbm9uLXByaXZpbGVnZWQgY29udGV4dHMgY2Fu IG1ha2UKPj4gdGhlbXNlbHZlcyBub24tcHJlZW1wdGFibGUgYnkgc2V0dGluZyB0aGUgd2F0Y2hk b2cgdGltZW91dC4KPj4KPj4gTWF5YmUgYXMgYSBjb21wcm9taXNlIHdlIG5lZWQgdG8gYXV0b21h dGljYWxseSBhcHBseSBhbiBlbGV2YXRlZAo+PiBwcmlvcml0eSBsZXZlbCwgYnV0IG5vdCBhcyBo aWdoIHRvIGJlIGNvbXBsZXRlbHkgbm9uLXByZWVtcHRhYmxlLgo+PiBTb3VuZHMKPj4gbGlrZSBh IGhhcmQgcXVlc3Rpb24uCj4+Cj4+IFJlZ2FyZHMsCj4+Cj4+IFR2cnRrbwo+IAo+IApfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=