From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57462C6FD1D for ; Thu, 30 Mar 2023 17:22:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BCF6C10EF3A; Thu, 30 Mar 2023 17:22:53 +0000 (UTC) X-Greylist: delayed 2624 seconds by postgrey-1.36 at gabe; Thu, 30 Mar 2023 17:22:51 UTC Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3809610EF55 for ; Thu, 30 Mar 2023 17:22:51 +0000 (UTC) Received: from ip4d1634d3.dynamic.kabel-deutschland.de ([77.22.52.211] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1phvIu-0005Pe-NM; Thu, 30 Mar 2023 18:39:12 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: dri-devel@lists.freedesktop.org, Jani Nikula Date: Thu, 30 Mar 2023 18:39:12 +0200 Message-ID: <2628105.X9hSmTKtgW@diego> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [Intel-gfx] [PATCH 11/12] drm/rockchip: convert to using has_audio from display_info X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jani.nikula@intel.com, intel-gfx@lists.freedesktop.org, Sandy Huang Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Am Donnerstag, 30. M=E4rz 2023, 17:39:48 CEST schrieb Jani Nikula: > Prefer the parsed results for has_audio in display info over calling > drm_detect_monitor_audio(). >=20 > Cc: Sandy Huang > Cc: Heiko St=FCbner > Signed-off-by: Jani Nikula Acked-by: Heiko Stuebner > --- > drivers/gpu/drm/rockchip/cdn-dp-core.c | 4 ++-- > drivers/gpu/drm/rockchip/inno_hdmi.c | 3 ++- > 2 files changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/roc= kchip/cdn-dp-core.c > index b6afe3786b74..4a4cf4354e27 100644 > --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c > +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c > @@ -272,10 +272,10 @@ static int cdn_dp_connector_get_modes(struct drm_co= nnector *connector) > DRM_DEV_DEBUG_KMS(dp->dev, "got edid: width[%d] x height[%d]\n", > edid->width_cm, edid->height_cm); > =20 > - dp->sink_has_audio =3D drm_detect_monitor_audio(edid); > - > drm_connector_update_edid_property(connector, edid); > ret =3D drm_add_edid_modes(connector, edid); > + > + dp->sink_has_audio =3D connector->display_info.has_audio; > } > mutex_unlock(&dp->lock); > =20 > diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockc= hip/inno_hdmi.c > index f51774866f41..98691aef1be5 100644 > --- a/drivers/gpu/drm/rockchip/inno_hdmi.c > +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c > @@ -564,10 +564,11 @@ static int inno_hdmi_connector_get_modes(struct drm= _connector *connector) > =20 > edid =3D drm_get_edid(connector, hdmi->ddc); > if (edid) { > - hdmi->hdmi_data.sink_has_audio =3D drm_detect_monitor_audio(edid); > drm_connector_update_edid_property(connector, edid); > ret =3D drm_add_edid_modes(connector, edid); > kfree(edid); > + > + hdmi->hdmi_data.sink_has_audio =3D connector->display_info.has_audio; > } > =20 > return ret; >=20