From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v3 5/7] drm/atomic: Add macros to access existing old/new state Date: Tue, 17 Jan 2017 03:05:43 +0200 Message-ID: <26519530.TOnBCJ1hTR@avalon> References: <1484559464-27107-1-git-send-email-maarten.lankhorst@linux.intel.com> <1484559464-27107-6-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1484559464-27107-6-git-send-email-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org SGkgTWFhcnRlbiwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgoKT24gTW9uZGF5IDE2IEphbiAy MDE3IDEwOjM3OjQyIE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+IEFmdGVyIGF0b21pYyBjb21t aXQsIHRoZXNlIG1hY3JvcyBzaG91bGQgYmUgdXNlZCBpbiBwbGFjZSBvZgo+IGdldF9leGlzdGlu Z19zdGF0ZS4gQWxzbyBhZnRlciBjb21taXQgZ2V0X3h4X3N0YXRlIHNob3VsZCBubyBsb25nZXIK PiBiZSB1c2VkIGJlY2F1c2UgaXQgbWF5IG5vdCBoYXZlIHRoZSByZXF1aXJlZCBsb2Nrcy4KClNo b3VsZCB0aGlzIGJlIGNhcHR1cmVkIGluIHRoZSBmdW5jdGlvbnMnIGRvY3VtZW50YXRpb24gPyBJ biBwYXJ0aWN1bGFyLCAKc2hvdWxkIHRoZSBkcm1fYXRvbWljX2dldF9leGlzdGluZ18qX3N0YXRl KCkgZnVuY3Rpb25zIGJlIG1hcmtlZCBhcyBkZXByZWNhdGVkIAo/Cgo+IFNpZ25lZC1vZmYtYnk6 IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4g LS0tCj4gIGluY2x1ZGUvZHJtL2RybV9hdG9taWMuaCB8IDk5ICsrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCA5OSBpbnNlcnRpb25z KCspCj4gCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2RybV9hdG9taWMuaCBiL2luY2x1ZGUv ZHJtL2RybV9hdG9taWMuaAo+IGluZGV4IDYwNjJlN2YyNzMyNS4uMmU2YmI3YWNjODM3IDEwMDY0 NAo+IC0tLSBhL2luY2x1ZGUvZHJtL2RybV9hdG9taWMuaAo+ICsrKyBiL2luY2x1ZGUvZHJtL2Ry bV9hdG9taWMuaAo+IEBAIC0yODUsNiArMjg1LDM1IEBAIGRybV9hdG9taWNfZ2V0X2V4aXN0aW5n X2NydGNfc3RhdGUoc3RydWN0Cj4gZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUsIH0KPiAKPiAgLyoq Cj4gKyAqIGRybV9hdG9taWNfZ2V0X29sZF9jcnRjX3N0YXRlIC0gZ2V0IG9sZCBjcnRjIHN0YXRl LCBpZiBpdCBleGlzdHMKPiArICogQHN0YXRlOiBnbG9iYWwgYXRvbWljIHN0YXRlIG9iamVjdAo+ ICsgKiBAY3J0YzogY3J0YyB0byBncmFiCj4gKyAqCj4gKyAqIFRoaXMgZnVuY3Rpb24gcmV0dXJu cyB0aGUgb2xkIGNydGMgc3RhdGUgZm9yIHRoZSBnaXZlbiBjcnRjLCBvcgo+ICsgKiBOVUxMIGlm IHRoZSBjcnRjIGlzIG5vdCBwYXJ0IG9mIHRoZSBnbG9iYWwgYXRvbWljIHN0YXRlLgo+ICsgKi8K PiArc3RhdGljIGlubGluZSBzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKgo+ICtkcm1fYXRvbWljX2dl dF9vbGRfY3J0Y19zdGF0ZShzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4gKwkJCSAg ICAgIHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiArewo+ICsJcmV0dXJuIHN0YXRlLT5jcnRjc1tk cm1fY3J0Y19pbmRleChjcnRjKV0ub2xkX3N0YXRlOwo+ICt9Cj4gKy8qKgo+ICsgKiBkcm1fYXRv bWljX2dldF9uZXdfY3J0Y19zdGF0ZSAtIGdldCBuZXcgY3J0YyBzdGF0ZSwgaWYgaXQgZXhpc3Rz Cj4gKyAqIEBzdGF0ZTogZ2xvYmFsIGF0b21pYyBzdGF0ZSBvYmplY3QKPiArICogQGNydGM6IGNy dGMgdG8gZ3JhYgo+ICsgKgo+ICsgKiBUaGlzIGZ1bmN0aW9uIHJldHVybnMgdGhlIG5ldyBjcnRj IHN0YXRlIGZvciB0aGUgZ2l2ZW4gY3J0Yywgb3IKPiArICogTlVMTCBpZiB0aGUgY3J0YyBpcyBu b3QgcGFydCBvZiB0aGUgZ2xvYmFsIGF0b21pYyBzdGF0ZS4KPiArICovCj4gK3N0YXRpYyBpbmxp bmUgc3RydWN0IGRybV9jcnRjX3N0YXRlICoKPiArZHJtX2F0b21pY19nZXRfbmV3X2NydGNfc3Rh dGUoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ICsJCQkgICAgICBzdHJ1Y3QgZHJt X2NydGMgKmNydGMpCj4gK3sKPiArCXJldHVybiBzdGF0ZS0+Y3J0Y3NbZHJtX2NydGNfaW5kZXgo Y3J0YyldLm5ld19zdGF0ZTsKPiArfQo+ICsKPiArLyoqCj4gICAqIGRybV9hdG9taWNfZ2V0X2V4 aXN0aW5nX3BsYW5lX3N0YXRlIC0gZ2V0IHBsYW5lIHN0YXRlLCBpZiBpdCBleGlzdHMKPiAgICog QHN0YXRlOiBnbG9iYWwgYXRvbWljIHN0YXRlIG9iamVjdAo+ICAgKiBAcGxhbmU6IHBsYW5lIHRv IGdyYWIKPiBAQCAtMzAwLDYgKzMyOSwzNiBAQCBkcm1fYXRvbWljX2dldF9leGlzdGluZ19wbGFu ZV9zdGF0ZShzdHJ1Y3QKPiBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwgfQo+IAo+ICAvKioKPiAr ICogZHJtX2F0b21pY19nZXRfb2xkX3BsYW5lX3N0YXRlIC0gZ2V0IHBsYW5lIHN0YXRlLCBpZiBp dCBleGlzdHMKPiArICogQHN0YXRlOiBnbG9iYWwgYXRvbWljIHN0YXRlIG9iamVjdAo+ICsgKiBA cGxhbmU6IHBsYW5lIHRvIGdyYWIKPiArICoKPiArICogVGhpcyBmdW5jdGlvbiByZXR1cm5zIHRo ZSBvbGQgcGxhbmUgc3RhdGUgZm9yIHRoZSBnaXZlbiBwbGFuZSwgb3IKPiArICogTlVMTCBpZiB0 aGUgcGxhbmUgaXMgbm90IHBhcnQgb2YgdGhlIGdsb2JhbCBhdG9taWMgc3RhdGUuCj4gKyAqLwo+ ICtzdGF0aWMgaW5saW5lIHN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKgo+ICtkcm1fYXRvbWljX2dl dF9vbGRfcGxhbmVfc3RhdGUoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ICsJCQkg ICAgICAgc3RydWN0IGRybV9wbGFuZSAqcGxhbmUpCj4gK3sKPiArCXJldHVybiBzdGF0ZS0+cGxh bmVzW2RybV9wbGFuZV9pbmRleChwbGFuZSldLm9sZF9zdGF0ZTsKPiArfQo+ICsKPiArLyoqCj4g KyAqIGRybV9hdG9taWNfZ2V0X25ld19wbGFuZV9zdGF0ZSAtIGdldCBwbGFuZSBzdGF0ZSwgaWYg aXQgZXhpc3RzCj4gKyAqIEBzdGF0ZTogZ2xvYmFsIGF0b21pYyBzdGF0ZSBvYmplY3QKPiArICog QHBsYW5lOiBwbGFuZSB0byBncmFiCj4gKyAqCj4gKyAqIFRoaXMgZnVuY3Rpb24gcmV0dXJucyB0 aGUgbmV3IHBsYW5lIHN0YXRlIGZvciB0aGUgZ2l2ZW4gcGxhbmUsIG9yCj4gKyAqIE5VTEwgaWYg dGhlIHBsYW5lIGlzIG5vdCBwYXJ0IG9mIHRoZSBnbG9iYWwgYXRvbWljIHN0YXRlLgo+ICsgKi8K PiArc3RhdGljIGlubGluZSBzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICoKPiArZHJtX2F0b21pY19n ZXRfbmV3X3BsYW5lX3N0YXRlKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKPiArCQkJ ICAgICAgIHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lKQo+ICt7Cj4gKwlyZXR1cm4gc3RhdGUtPnBs YW5lc1tkcm1fcGxhbmVfaW5kZXgocGxhbmUpXS5uZXdfc3RhdGU7Cj4gK30KPiArCj4gKy8qKgo+ ICAgKiBkcm1fYXRvbWljX2dldF9leGlzdGluZ19jb25uZWN0b3Jfc3RhdGUgLSBnZXQgY29ubmVj dG9yIHN0YXRlLCBpZiBpdAo+IGV4aXN0cyAqIEBzdGF0ZTogZ2xvYmFsIGF0b21pYyBzdGF0ZSBv YmplY3QKPiAgICogQGNvbm5lY3RvcjogY29ubmVjdG9yIHRvIGdyYWIKPiBAQCAtMzIwLDYgKzM3 OSw0NiBAQCBkcm1fYXRvbWljX2dldF9leGlzdGluZ19jb25uZWN0b3Jfc3RhdGUoc3RydWN0Cj4g ZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUsIH0KPiAKPiAgLyoqCj4gKyAqIGRybV9hdG9taWNfZ2V0 X29sZF9jb25uZWN0b3Jfc3RhdGUgLSBnZXQgY29ubmVjdG9yIHN0YXRlLCBpZiBpdCBleGlzdHMK PiArICogQHN0YXRlOiBnbG9iYWwgYXRvbWljIHN0YXRlIG9iamVjdAo+ICsgKiBAY29ubmVjdG9y OiBjb25uZWN0b3IgdG8gZ3JhYgo+ICsgKgo+ICsgKiBUaGlzIGZ1bmN0aW9uIHJldHVybnMgdGhl IG9sZCBjb25uZWN0b3Igc3RhdGUgZm9yIHRoZSBnaXZlbiBjb25uZWN0b3IsCj4gKyAqIG9yIE5V TEwgaWYgdGhlIGNvbm5lY3RvciBpcyBub3QgcGFydCBvZiB0aGUgZ2xvYmFsIGF0b21pYyBzdGF0 ZS4KPiArICovCj4gK3N0YXRpYyBpbmxpbmUgc3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKgo+ ICtkcm1fYXRvbWljX2dldF9vbGRfY29ubmVjdG9yX3N0YXRlKHN0cnVjdCBkcm1fYXRvbWljX3N0 YXRlICpzdGF0ZSwKPiArCQkJCSAgIHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IpCj4g K3sKPiArCWludCBpbmRleCA9IGRybV9jb25uZWN0b3JfaW5kZXgoY29ubmVjdG9yKTsKPiArCj4g KwlpZiAoaW5kZXggPj0gc3RhdGUtPm51bV9jb25uZWN0b3IpCj4gKwkJcmV0dXJuIE5VTEw7Cj4g Kwo+ICsJcmV0dXJuIHN0YXRlLT5jb25uZWN0b3JzW2luZGV4XS5vbGRfc3RhdGU7Cj4gK30KPiAr Cj4gKy8qKgo+ICsgKiBkcm1fYXRvbWljX2dldF9uZXdfY29ubmVjdG9yX3N0YXRlIC0gZ2V0IGNv bm5lY3RvciBzdGF0ZSwgaWYgaXQgZXhpc3RzCj4gKyAqIEBzdGF0ZTogZ2xvYmFsIGF0b21pYyBz dGF0ZSBvYmplY3QKPiArICogQGNvbm5lY3RvcjogY29ubmVjdG9yIHRvIGdyYWIKPiArICoKPiAr ICogVGhpcyBmdW5jdGlvbiByZXR1cm5zIHRoZSBuZXcgY29ubmVjdG9yIHN0YXRlIGZvciB0aGUg Z2l2ZW4gY29ubmVjdG9yLAo+ICsgKiBvciBOVUxMIGlmIHRoZSBjb25uZWN0b3IgaXMgbm90IHBh cnQgb2YgdGhlIGdsb2JhbCBhdG9taWMgc3RhdGUuCj4gKyAqLwo+ICtzdGF0aWMgaW5saW5lIHN0 cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlICoKPiArZHJtX2F0b21pY19nZXRfbmV3X2Nvbm5lY3Rv cl9zdGF0ZShzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4gKwkJCQkgICBzdHJ1Y3Qg ZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ICt7Cj4gKwlpbnQgaW5kZXggPSBkcm1fY29ubmVj dG9yX2luZGV4KGNvbm5lY3Rvcik7Cj4gKwo+ICsJaWYgKGluZGV4ID49IHN0YXRlLT5udW1fY29u bmVjdG9yKQo+ICsJCXJldHVybiBOVUxMOwo+ICsKPiArCXJldHVybiBzdGF0ZS0+Y29ubmVjdG9y c1tpbmRleF0ubmV3X3N0YXRlOwo+ICt9Cj4gKwo+ICsvKioKPiAgICogX19kcm1fYXRvbWljX2dl dF9jdXJyZW50X3BsYW5lX3N0YXRlIC0gZ2V0IGN1cnJlbnQgcGxhbmUgc3RhdGUKPiAgICogQHN0 YXRlOiBnbG9iYWwgYXRvbWljIHN0YXRlIG9iamVjdAo+ICAgKiBAcGxhbmU6IHBsYW5lIHRvIGdy YWIKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==