Re: [PATCH 3/5] drm/i915: WaInsertNoopAfterBatchEndCommand

Chris Wilson
2012-10-18T11:25:12Z

On Thu, 18 Oct 2012 11:49:52 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Comment says that this applies to earlier gens, too. Since two more
> MI_NOOP's can't hurt that much, I've figured I'll apply this w/a down
> to gen2.
>
> v2: Correct the ringbuffer dword count for gen3, spotted by Chris
> Wilson.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

I'm just not sold on this one, surely we would have spotted a need
before now? 12 extra cycles after every batch! :-p

Can you please fix up the cut'n'paste comments to not refer to
generations that never call the function?
-Chris

--
Chris Wilson, Intel Open Source Technology Centre