From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 3/5] drm/i915: WaInsertNoopAfterBatchEndCommand Date: Thu, 18 Oct 2012 12:24:50 +0100 Message-ID: <275ffc$71tsso@fmsmga002.fm.intel.com> References: <1350553794-5534-1-git-send-email-daniel.vetter@ffwll.ch> <1350553794-5534-4-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 505D99E860 for ; Thu, 18 Oct 2012 04:25:12 -0700 (PDT) In-Reply-To: <1350553794-5534-4-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Thu, 18 Oct 2012 11:49:52 +0200, Daniel Vetter wrote: > Comment says that this applies to earlier gens, too. Since two more > MI_NOOP's can't hurt that much, I've figured I'll apply this w/a down > to gen2. > > v2: Correct the ringbuffer dword count for gen3, spotted by Chris > Wilson. > > Signed-off-by: Daniel Vetter I'm just not sold on this one, surely we would have spotted a need before now? 12 extra cycles after every batch! :-p Can you please fix up the cut'n'paste comments to not refer to generations that never call the function? -Chris -- Chris Wilson, Intel Open Source Technology Centre