From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 157F2C433ED for ; Wed, 14 Apr 2021 15:16:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D26A6613BB for ; Wed, 14 Apr 2021 15:16:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D26A6613BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 775846E948; Wed, 14 Apr 2021 15:16:17 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 91D166E948; Wed, 14 Apr 2021 15:16:16 +0000 (UTC) IronPort-SDR: OoGK8f9WeS5SgbZ6zlfNPQI4oaDiJOYs7zzYjuLbgUJrTeArbVmRRBPQWWHiGrZusagUtdvVeB oRVnLKTL0LiQ== X-IronPort-AV: E=McAfee;i="6200,9189,9954"; a="279972501" X-IronPort-AV: E=Sophos;i="5.82,222,1613462400"; d="scan'208";a="279972501" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 08:16:13 -0700 IronPort-SDR: DLCFbRb2L37VZ+fcE8tXkCv1U2DDcRFnbmSZIB7dDszJKf54pFzWc4VfuAWQEnDHNIO2TQ7XMe ta7HWLvUH9yA== X-IronPort-AV: E=Sophos;i="5.82,222,1613462400"; d="scan'208";a="418359124" Received: from bdebhal-mobl.ger.corp.intel.com (HELO [10.213.205.119]) ([10.213.205.119]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 08:16:12 -0700 To: Matthew Auld , intel-gfx@lists.freedesktop.org References: <20210412090526.30547-1-matthew.auld@intel.com> <20210412090526.30547-9-matthew.auld@intel.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: <28227924-447c-6ceb-eaec-7c55be29b1b1@linux.intel.com> Date: Wed, 14 Apr 2021 16:16:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210412090526.30547-9-matthew.auld@intel.com> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH 08/19] drm/i915: Return error value when bo not in LMEM for discrete X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mohammed Khajapasha , dri-devel@lists.freedesktop.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 12/04/2021 10:05, Matthew Auld wrote: > From: Mohammed Khajapasha > > Return EREMOTE value when frame buffer object is not backed by LMEM > for discrete. If Local memory is supported by hardware the framebuffer > backing gem objects should be from local memory. > > Signed-off-by: Mohammed Khajapasha > --- > drivers/gpu/drm/i915/display/intel_display.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c > index 411b46c012f8..57b06d8728af 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -63,6 +63,7 @@ > #include "display/intel_vdsc.h" > #include "display/intel_vrr.h" > > +#include "gem/i915_gem_lmem.h" > #include "gem/i915_gem_object.h" > > #include "gt/intel_rps.h" > @@ -11279,11 +11280,20 @@ intel_user_framebuffer_create(struct drm_device *dev, > struct drm_framebuffer *fb; > struct drm_i915_gem_object *obj; > struct drm_mode_fb_cmd2 mode_cmd = *user_mode_cmd; > + struct drm_i915_private *i915; > > obj = i915_gem_object_lookup(filp, mode_cmd.handles[0]); > if (!obj) > return ERR_PTR(-ENOENT); > > + /* object is backed with LMEM for discrete */ > + i915 = to_i915(obj->base.dev); > + if (HAS_LMEM(i915) && !i915_gem_object_is_lmem(obj)) { > + /* object is "remote", not in local memory */ > + i915_gem_object_put(obj); > + return ERR_PTR(-EREMOTE); I am a fan of rich errnos and this one feels appropriately descriptive, but please get an ack from Daniel or so. Reviewed-by: Tvrtko Ursulin Regards, Tvrtko > + } > + > fb = intel_framebuffer_create(obj, &mode_cmd); > i915_gem_object_put(obj); > > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx