From mboxrd@z Thu Jan  1 00:00:00 1970
From: John Harrison <John.C.Harrison@Intel.com>
Subject: Re: [PATCH 08/34] drm/i915: Make all GPU resets atomic
Date: Tue, 22 Jan 2019 14:19:04 -0800
Message-ID: <2943ee42-b094-8977-a4fa-fac111d5604d@Intel.com>
References: <20190121222117.23305-1-chris@chris-wilson.co.uk>
 <20190121222117.23305-9-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 8E2406EDD5
 for <intel-gfx@lists.freedesktop.org>; Tue, 22 Jan 2019 22:19:05 +0000 (UTC)
In-Reply-To: <20190121222117.23305-9-chris@chris-wilson.co.uk>
Content-Language: en-US
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gMS8yMS8yMDE5IDE0OjIwLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gSW4gcHJlcGFyYXRpb24g
Zm9yIHRoZSBuZXh0IGZldyBjb21taXRzLCBtYWtlIHJlc2V0dGluZyB0aGUgR1BVIGF0b21pYy4K
PiBDdXJyZW50bHksIHdlIGhhdmUgcHJlcGFyZWQgZ2VuNisgZm9yIGF0b21pYyByZXNldHRpbmcg
b2YgaW5kaXZpZHVhbAo+IGVuZ2luZXMsIGJ1dCBub3cgdGhlcmUgaXMgYSByZXF1aXJlbWVudCB0
byBwZXJmb3JtIHRoZSB3aG9sZSBkZXZpY2UKPiBsZXZlbCByZXNldCAoanVzdCB0aGUgcmVnaXN0
ZXIgcG9raW5nKSBmcm9tIGluc2lkZSBhbiBhdG9taWMgY29udGV4dC4KPgo+IFNpZ25lZC1vZmYt
Ynk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IFJldmlld2VkLWJ5
OiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAg
IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVzZXQuYyB8IDUwICsrKysrKysrKysrKysrKysr
LS0tLS0tLS0tLS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAyNyBpbnNlcnRpb25zKCspLCAyMyBk
ZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Jl
c2V0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Jlc2V0LmMKPiBpbmRleCAzNDJkOWVl
NDI2MDEuLmI5ZDBlYTcwMzYxYyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
OTE1X3Jlc2V0LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Jlc2V0LmMKPiBA
QCAtMTQ0LDE0ICsxNDQsMTQgQEAgc3RhdGljIGludCBpOTE1X2RvX3Jlc2V0KHN0cnVjdCBkcm1f
aTkxNV9wcml2YXRlICppOTE1LAo+ICAgCj4gICAJLyogQXNzZXJ0IHJlc2V0IGZvciBhdCBsZWFz
dCAyMCB1c2VjLCBhbmQgd2FpdCBmb3IgYWNrbm93bGVkZ2VtZW50LiAqLwo+ICAgCXBjaV93cml0
ZV9jb25maWdfYnl0ZShwZGV2LCBJOTE1X0dEUlNULCBHUkRPTV9SRVNFVF9FTkFCTEUpOwo+IC0J
dXNsZWVwX3JhbmdlKDUwLCAyMDApOwo+IC0JZXJyID0gd2FpdF9mb3IoaTkxNV9pbl9yZXNldChw
ZGV2KSwgNTAwKTsKPiArCXVkZWxheSg1MCk7Cj4gKwllcnIgPSB3YWl0X2Zvcl9hdG9taWMoaTkx
NV9pbl9yZXNldChwZGV2KSwgNTApOwpJcyBpdCBrbm93biB0byBiZSBzYWZlIHRvIHJlZHVjZSBh
bGwgb2YgdGhlc2UgdGltZSBvdXQgdmFsdWVzPyBXaGVyZSBkaWQgCnRoZSBvcmlnaW5hbGx5IDUw
MG1zIHZhbHVlIGNvbWUgZnJvbT8gSXMgdGhlcmUgYW55IGNoYW5jZSBvZiBnZXR0aW5nIApzcG9y
YWRpYyBmYWlsdXJlcyBiZWNhdXNlIDUwbXMgaXMgYm9yZGVybGluZSBpbiB0aGUgd29yc3QgY2Fz
ZSBzY2VuYXJpbz8gCkl0IHN0aWxsIHNvdW5kcyBodWdlIGJ1dCBhbiBvcmRlciBvZiBtYWduaXR1
ZGUgY2hhbmdlIGluIGEgdGltZW91dCAKYWx3YXlzIHNlZW1zIHdvcnJ5aW5nIQoKPiAgIAo+ICAg
CS8qIENsZWFyIHRoZSByZXNldCByZXF1ZXN0LiAqLwo+ICAgCXBjaV93cml0ZV9jb25maWdfYnl0
ZShwZGV2LCBJOTE1X0dEUlNULCAwKTsKPiAtCXVzbGVlcF9yYW5nZSg1MCwgMjAwKTsKPiArCXVk
ZWxheSg1MCk7Cj4gICAJaWYgKCFlcnIpCj4gLQkJZXJyID0gd2FpdF9mb3IoIWk5MTVfaW5fcmVz
ZXQocGRldiksIDUwMCk7Cj4gKwkJZXJyID0gd2FpdF9mb3JfYXRvbWljKCFpOTE1X2luX3Jlc2V0
KHBkZXYpLCA1MCk7Cj4gICAKPiAgIAlyZXR1cm4gZXJyOwo+ICAgfQo+IEBAIC0xNzEsNyArMTcx
LDcgQEAgc3RhdGljIGludCBnMzNfZG9fcmVzZXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5
MTUsCj4gICAJc3RydWN0IHBjaV9kZXYgKnBkZXYgPSBpOTE1LT5kcm0ucGRldjsKPiAgIAo+ICAg
CXBjaV93cml0ZV9jb25maWdfYnl0ZShwZGV2LCBJOTE1X0dEUlNULCBHUkRPTV9SRVNFVF9FTkFC
TEUpOwo+IC0JcmV0dXJuIHdhaXRfZm9yKGc0eF9yZXNldF9jb21wbGV0ZShwZGV2KSwgNTAwKTsK
PiArCXJldHVybiB3YWl0X2Zvcl9hdG9taWMoZzR4X3Jlc2V0X2NvbXBsZXRlKHBkZXYpLCA1MCk7
Cj4gICB9Cj4gICAKPiAgIHN0YXRpYyBpbnQgZzR4X2RvX3Jlc2V0KHN0cnVjdCBkcm1faTkxNV9w
cml2YXRlICpkZXZfcHJpdiwKPiBAQCAtMTgyLDEzICsxODIsMTMgQEAgc3RhdGljIGludCBnNHhf
ZG9fcmVzZXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAgCWludCByZXQ7
Cj4gICAKPiAgIAkvKiBXYVZjcENsa0dhdGVEaXNhYmxlRm9yTWVkaWFSZXNldDpjdGcsZWxrICov
Cj4gLQlJOTE1X1dSSVRFKFZERUNDTEtfR0FURV9ELAo+IC0JCSAgIEk5MTVfUkVBRChWREVDQ0xL
X0dBVEVfRCkgfCBWQ1BfVU5JVF9DTE9DS19HQVRFX0RJU0FCTEUpOwo+IC0JUE9TVElOR19SRUFE
KFZERUNDTEtfR0FURV9EKTsKPiArCUk5MTVfV1JJVEVfRlcoVkRFQ0NMS19HQVRFX0QsCj4gKwkJ
ICAgICAgSTkxNV9SRUFEKFZERUNDTEtfR0FURV9EKSB8IFZDUF9VTklUX0NMT0NLX0dBVEVfRElT
QUJMRSk7Cj4gKwlQT1NUSU5HX1JFQURfRlcoVkRFQ0NMS19HQVRFX0QpOwo+ICAgCj4gICAJcGNp
X3dyaXRlX2NvbmZpZ19ieXRlKHBkZXYsIEk5MTVfR0RSU1QsCj4gICAJCQkgICAgICBHUkRPTV9N
RURJQSB8IEdSRE9NX1JFU0VUX0VOQUJMRSk7Cj4gLQlyZXQgPSAgd2FpdF9mb3IoZzR4X3Jlc2V0
X2NvbXBsZXRlKHBkZXYpLCA1MDApOwo+ICsJcmV0ID0gIHdhaXRfZm9yX2F0b21pYyhnNHhfcmVz
ZXRfY29tcGxldGUocGRldiksIDUwKTsKPiAgIAlpZiAocmV0KSB7Cj4gICAJCURSTV9ERUJVR19E
UklWRVIoIldhaXQgZm9yIG1lZGlhIHJlc2V0IGZhaWxlZFxuIik7Cj4gICAJCWdvdG8gb3V0Owo+
IEBAIC0xOTYsNyArMTk2LDcgQEAgc3RhdGljIGludCBnNHhfZG9fcmVzZXQoc3RydWN0IGRybV9p
OTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAgCj4gICAJcGNpX3dyaXRlX2NvbmZpZ19ieXRlKHBk
ZXYsIEk5MTVfR0RSU1QsCj4gICAJCQkgICAgICBHUkRPTV9SRU5ERVIgfCBHUkRPTV9SRVNFVF9F
TkFCTEUpOwo+IC0JcmV0ID0gIHdhaXRfZm9yKGc0eF9yZXNldF9jb21wbGV0ZShwZGV2KSwgNTAw
KTsKPiArCXJldCA9ICB3YWl0X2Zvcl9hdG9taWMoZzR4X3Jlc2V0X2NvbXBsZXRlKHBkZXYpLCA1
MCk7Cj4gICAJaWYgKHJldCkgewo+ICAgCQlEUk1fREVCVUdfRFJJVkVSKCJXYWl0IGZvciByZW5k
ZXIgcmVzZXQgZmFpbGVkXG4iKTsKPiAgIAkJZ290byBvdXQ7Cj4gQEAgLTIwNSw5ICsyMDUsOSBA
QCBzdGF0aWMgaW50IGc0eF9kb19yZXNldChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By
aXYsCj4gICBvdXQ6Cj4gICAJcGNpX3dyaXRlX2NvbmZpZ19ieXRlKHBkZXYsIEk5MTVfR0RSU1Qs
IDApOwo+ICAgCj4gLQlJOTE1X1dSSVRFKFZERUNDTEtfR0FURV9ELAo+IC0JCSAgIEk5MTVfUkVB
RChWREVDQ0xLX0dBVEVfRCkgJiB+VkNQX1VOSVRfQ0xPQ0tfR0FURV9ESVNBQkxFKTsKPiAtCVBP
U1RJTkdfUkVBRChWREVDQ0xLX0dBVEVfRCk7Cj4gKwlJOTE1X1dSSVRFX0ZXKFZERUNDTEtfR0FU
RV9ELAo+ICsJCSAgICAgIEk5MTVfUkVBRChWREVDQ0xLX0dBVEVfRCkgJiB+VkNQX1VOSVRfQ0xP
Q0tfR0FURV9ESVNBQkxFKTsKPiArCVBPU1RJTkdfUkVBRF9GVyhWREVDQ0xLX0dBVEVfRCk7Cj4g
ICAKPiAgIAlyZXR1cm4gcmV0Owo+ICAgfQo+IEBAIC0yMTgsMjcgKzIxOCwyOSBAQCBzdGF0aWMg
aW50IGlyb25sYWtlX2RvX3Jlc2V0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwK
PiAgIHsKPiAgIAlpbnQgcmV0Owo+ICAgCj4gLQlJOTE1X1dSSVRFKElMS19HRFNSLCBJTEtfR1JE
T01fUkVOREVSIHwgSUxLX0dSRE9NX1JFU0VUX0VOQUJMRSk7Cj4gLQlyZXQgPSBpbnRlbF93YWl0
X2Zvcl9yZWdpc3RlcihkZXZfcHJpdiwKPiAtCQkJCSAgICAgIElMS19HRFNSLCBJTEtfR1JET01f
UkVTRVRfRU5BQkxFLCAwLAo+IC0JCQkJICAgICAgNTAwKTsKPiArCUk5MTVfV1JJVEVfRlcoSUxL
X0dEU1IsIElMS19HUkRPTV9SRU5ERVIgfCBJTEtfR1JET01fUkVTRVRfRU5BQkxFKTsKPiArCXJl
dCA9IF9faW50ZWxfd2FpdF9mb3JfcmVnaXN0ZXJfZncoZGV2X3ByaXYsIElMS19HRFNSLAo+ICsJ
CQkJCSAgIElMS19HUkRPTV9SRVNFVF9FTkFCTEUsIDAsCj4gKwkJCQkJICAgNTAwMCwgMCwKPiAr
CQkJCQkgICBOVUxMKTsKVGhlc2UgdHdvIHRpbWVvdXRzIGFyZSBub3cgdHdvIG9yZGVycyBvZiBt
YWduaXR1ZGUgc21hbGxlcj8gSXQgd2FzIDUwMG1zIApidXQgaXMgbm93IDUwMDB1cyAoPTVtcyk/
CgpKb2huLgoKCj4gICAJaWYgKHJldCkgewo+ICAgCQlEUk1fREVCVUdfRFJJVkVSKCJXYWl0IGZv
ciByZW5kZXIgcmVzZXQgZmFpbGVkXG4iKTsKPiAgIAkJZ290byBvdXQ7Cj4gICAJfQo+ICAgCj4g
LQlJOTE1X1dSSVRFKElMS19HRFNSLCBJTEtfR1JET01fTUVESUEgfCBJTEtfR1JET01fUkVTRVRf
RU5BQkxFKTsKPiAtCXJldCA9IGludGVsX3dhaXRfZm9yX3JlZ2lzdGVyKGRldl9wcml2LAo+IC0J
CQkJICAgICAgSUxLX0dEU1IsIElMS19HUkRPTV9SRVNFVF9FTkFCTEUsIDAsCj4gLQkJCQkgICAg
ICA1MDApOwo+ICsJSTkxNV9XUklURV9GVyhJTEtfR0RTUiwgSUxLX0dSRE9NX01FRElBIHwgSUxL
X0dSRE9NX1JFU0VUX0VOQUJMRSk7Cj4gKwlyZXQgPSBfX2ludGVsX3dhaXRfZm9yX3JlZ2lzdGVy
X2Z3KGRldl9wcml2LCBJTEtfR0RTUiwKPiArCQkJCQkgICBJTEtfR1JET01fUkVTRVRfRU5BQkxF
LCAwLAo+ICsJCQkJCSAgIDUwMDAsIDAsCj4gKwkJCQkJICAgTlVMTCk7Cj4gICAJaWYgKHJldCkg
ewo+ICAgCQlEUk1fREVCVUdfRFJJVkVSKCJXYWl0IGZvciBtZWRpYSByZXNldCBmYWlsZWRcbiIp
Owo+ICAgCQlnb3RvIG91dDsKPiAgIAl9Cj4gICAKPiAgIG91dDoKPiAtCUk5MTVfV1JJVEUoSUxL
X0dEU1IsIDApOwo+IC0JUE9TVElOR19SRUFEKElMS19HRFNSKTsKPiArCUk5MTVfV1JJVEVfRlco
SUxLX0dEU1IsIDApOwo+ICsJUE9TVElOR19SRUFEX0ZXKElMS19HRFNSKTsKPiAgIAlyZXR1cm4g
cmV0Owo+ICAgfQo+ICAgCj4gQEAgLTU3Miw3ICs1NzQsOSBAQCBpbnQgaW50ZWxfZ3B1X3Jlc2V0
KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1LCB1bnNpZ25lZCBpbnQgZW5naW5lX21hc2sp
Cj4gICAJCXJldCA9IC1FTk9ERVY7Cj4gICAJCWlmIChyZXNldCkgewo+ICAgCQkJR0VNX1RSQUNF
KCJlbmdpbmVfbWFzaz0leFxuIiwgZW5naW5lX21hc2spOwo+ICsJCQlwcmVlbXB0X2Rpc2FibGUo
KTsKPiAgIAkJCXJldCA9IHJlc2V0KGk5MTUsIGVuZ2luZV9tYXNrLCByZXRyeSk7Cj4gKwkJCXBy
ZWVtcHRfZW5hYmxlKCk7Cj4gICAJCX0KPiAgIAkJaWYgKHJldCAhPSAtRVRJTUVET1VUIHx8IGVu
Z2luZV9tYXNrICE9IEFMTF9FTkdJTkVTKQo+ICAgCQkJYnJlYWs7CgpfX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu
dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v
cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK