From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Souza, Jose" Subject: Re: [PATCH v2 6/6] drm/i915/dp: Fix duplication of DEVICE_SERVICE_IRQ handling Date: Tue, 25 Sep 2018 21:01:20 +0000 Message-ID: <2af9869d50ac18d4542fbd2fe240314c852f1a88.camel@intel.com> References: <20180924224528.4744-1-dhinakaran.pandiyan@intel.com> <20180924224528.4744-6-dhinakaran.pandiyan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id D2A676E1B8 for ; Tue, 25 Sep 2018 21:01:34 +0000 (UTC) In-Reply-To: <20180924224528.4744-6-dhinakaran.pandiyan@intel.com> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "intel-gfx@lists.freedesktop.org" , "Pandiyan, Dhinakaran" List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAyMDE4LTA5LTI0IGF0IDE1OjQ1IC0wNzAwLCBEaGluYWthcmFuIFBhbmRpeWFuIHdy b3RlOg0KPiBUaGVyZSBhcmUgdHdvIGNvcGllcyBvZiB0aGUgc2FtZSBjb2RlIGNhbGxlZCBmcm9t IGxvbmcgYW5kIHNob3J0DQo+IHB1bHNlIGhhbmRsZXJzLg0KDQoNClJldmlld2VkLWJ5OiBKb3PD qSBSb2JlcnRvIGRlIFNvdXphIDxqb3NlLnNvdXphQGludGVsLmNvbT4NCg0KPiANCj4gU2lnbmVk LW9mZi1ieTogRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5j b20+DQo+IC0tLQ0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyB8IDU5ICsrKysr KysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0NCj4gLS0NCj4gIDEgZmlsZSBjaGFuZ2VkLCAyMiBp bnNlcnRpb25zKCspLCAzNyBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jDQo+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHAuYw0KPiBpbmRleCBkNmVhOTNlNDUzYTIuLjY0YzYxNThmZWIwYiAxMDA2NDQNCj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYw0KPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kcC5jDQo+IEBAIC00MDM4LDEzICs0MDM4LDYgQEAgaW50ZWxfZHBfY29uZmln dXJlX21zdChzdHJ1Y3QgaW50ZWxfZHANCj4gKmludGVsX2RwKQ0KPiAgCQkJCQlpbnRlbF9kcC0+ aXNfbXN0KTsNCj4gIH0NCj4gIA0KPiAtc3RhdGljIGJvb2wNCj4gLWludGVsX2RwX2dldF9zaW5r X2lycShzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLCB1OA0KPiAqc2lua19pcnFfdmVjdG9yKQ0K PiAtew0KPiAtCXJldHVybiBkcm1fZHBfZHBjZF9yZWFkYigmaW50ZWxfZHAtPmF1eCwNCj4gRFBf REVWSUNFX1NFUlZJQ0VfSVJRX1ZFQ1RPUiwNCj4gLQkJCQkgc2lua19pcnFfdmVjdG9yKSA9PSAx Ow0KPiAtfQ0KPiAtDQo+ICBzdGF0aWMgYm9vbA0KPiAgaW50ZWxfZHBfZ2V0X3NpbmtfaXJxX2Vz aShzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLCB1OA0KPiAqc2lua19pcnFfdmVjdG9yKQ0KPiAg ew0KPiBAQCAtNDQzMiw2ICs0NDI1LDI2IEBAIHN0YXRpYyBib29sIGludGVsX2RwX2hvdHBsdWco c3RydWN0DQo+IGludGVsX2VuY29kZXIgKmVuY29kZXIsDQo+ICAJcmV0dXJuIGNoYW5nZWQ7DQo+ ICB9DQo+ICANCj4gK3N0YXRpYyB2b2lkIGludGVsX2RwX2NoZWNrX3NlcnZpY2VfaXJxKHN0cnVj dCBpbnRlbF9kcCAqaW50ZWxfZHApDQo+ICt7DQo+ICsJdTggdmFsOw0KPiArDQo+ICsJaWYgKGlu dGVsX2RwLT5kcGNkW0RQX0RQQ0RfUkVWXSA8IDB4MTEpDQo+ICsJCXJldHVybjsNCj4gKw0KPiAr CWlmIChkcm1fZHBfZHBjZF9yZWFkYigmaW50ZWxfZHAtPmF1eCwNCj4gKwkJCSAgICAgIERQX0RF VklDRV9TRVJWSUNFX0lSUV9WRUNUT1IsICZ2YWwpICE9IDENCj4gfHwgIXZhbCkNCj4gKwkJcmV0 dXJuOw0KPiArDQo+ICsJZHJtX2RwX2RwY2Rfd3JpdGViKCZpbnRlbF9kcC0+YXV4LA0KPiBEUF9E RVZJQ0VfU0VSVklDRV9JUlFfVkVDVE9SLCB2YWwpOw0KPiArDQo+ICsJaWYgKHZhbCAmIERQX0FV VE9NQVRFRF9URVNUX1JFUVVFU1QpDQo+ICsJCWludGVsX2RwX2hhbmRsZV90ZXN0X3JlcXVlc3Qo aW50ZWxfZHApOw0KPiArDQo+ICsJaWYgKHZhbCAmIChEUF9DUF9JUlEgfCBEUF9TSU5LX1NQRUNJ RklDX0lSUSkpDQo+ICsJCURSTV9ERUJVR19EUklWRVIoIkNQIG9yIHNpbmsgc3BlY2lmaWMgaXJx DQo+IHVuaGFuZGxlZFxuIik7DQo+ICt9DQo+ICsNCj4gIC8qDQo+ICAgKiBBY2NvcmRpbmcgdG8g RFAgc3BlYw0KPiAgICogNS4xLjI6DQo+IEBAIC00NDQ5LDcgKzQ0NjIsNiBAQCBzdGF0aWMgYm9v bA0KPiAgaW50ZWxfZHBfc2hvcnRfcHVsc2Uoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkNCj4g IHsNCj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkcF90b19pOTE1KGlu dGVsX2RwKTsNCj4gLQl1OCBzaW5rX2lycV92ZWN0b3IgPSAwOw0KPiAgCXU4IG9sZF9zaW5rX2Nv dW50ID0gaW50ZWxfZHAtPnNpbmtfY291bnQ7DQo+ICAJYm9vbCByZXQ7DQo+ICANCj4gQEAgLTQ0 NzIsMjAgKzQ0ODQsNyBAQCBpbnRlbF9kcF9zaG9ydF9wdWxzZShzdHJ1Y3QgaW50ZWxfZHANCj4g KmludGVsX2RwKQ0KPiAgCQlyZXR1cm4gZmFsc2U7DQo+ICAJfQ0KPiAgDQo+IC0JLyogVHJ5IHRv IHJlYWQgdGhlIHNvdXJjZSBvZiB0aGUgaW50ZXJydXB0ICovDQo+IC0JaWYgKGludGVsX2RwLT5k cGNkW0RQX0RQQ0RfUkVWXSA+PSAweDExICYmDQo+IC0JICAgIGludGVsX2RwX2dldF9zaW5rX2ly cShpbnRlbF9kcCwgJnNpbmtfaXJxX3ZlY3RvcikgJiYNCj4gLQkgICAgc2lua19pcnFfdmVjdG9y ICE9IDApIHsNCj4gLQkJLyogQ2xlYXIgaW50ZXJydXB0IHNvdXJjZSAqLw0KPiAtCQlkcm1fZHBf ZHBjZF93cml0ZWIoJmludGVsX2RwLT5hdXgsDQo+IC0JCQkJICAgRFBfREVWSUNFX1NFUlZJQ0Vf SVJRX1ZFQ1RPUiwNCj4gLQkJCQkgICBzaW5rX2lycV92ZWN0b3IpOw0KPiAtDQo+IC0JCWlmIChz aW5rX2lycV92ZWN0b3IgJiBEUF9BVVRPTUFURURfVEVTVF9SRVFVRVNUKQ0KPiAtCQkJaW50ZWxf ZHBfaGFuZGxlX3Rlc3RfcmVxdWVzdChpbnRlbF9kcCk7DQo+IC0JCWlmIChzaW5rX2lycV92ZWN0 b3IgJiAoRFBfQ1BfSVJRIHwNCj4gRFBfU0lOS19TUEVDSUZJQ19JUlEpKQ0KPiAtCQkJRFJNX0RF QlVHX0RSSVZFUigiQ1Agb3Igc2luayBzcGVjaWZpYyBpcnENCj4gdW5oYW5kbGVkXG4iKTsNCj4g LQl9DQo+ICsJaW50ZWxfZHBfY2hlY2tfc2VydmljZV9pcnEoaW50ZWxfZHApOw0KPiAgDQo+ICAJ LyogSGFuZGxlIENFQyBpbnRlcnJ1cHRzLCBpZiBhbnkgKi8NCj4gIAlkcm1fZHBfY2VjX2lycSgm aW50ZWxfZHAtPmF1eCk7DQo+IEBAIC01MDIwLDcgKzUwMTksNiBAQCBpbnRlbF9kcF9kZXRlY3Qo c3RydWN0IGRybV9jb25uZWN0b3INCj4gKmNvbm5lY3RvciwNCj4gIAlzdHJ1Y3QgaW50ZWxfZHAg KmludGVsX2RwID0gaW50ZWxfYXR0YWNoZWRfZHAoY29ubmVjdG9yKTsNCj4gIAlzdHJ1Y3QgaW50 ZWxfZW5jb2RlciAqZW5jb2RlciA9ICZkcF90b19kaWdfcG9ydChpbnRlbF9kcCktDQo+ID5iYXNl Ow0KPiAgCWludCBzdGF0dXM7DQo+IC0JdTggc2lua19pcnFfdmVjdG9yID0gMDsNCj4gIA0KPiAg CURSTV9ERUJVR19LTVMoIltDT05ORUNUT1I6JWQ6JXNdXG4iLA0KPiAgCQkgICAgICBjb25uZWN0 b3ItPmJhc2UuaWQsIGNvbm5lY3Rvci0+bmFtZSk7DQo+IEBAIC01MTAzLDIwICs1MTAxLDcgQEAg aW50ZWxfZHBfZGV0ZWN0KHN0cnVjdCBkcm1fY29ubmVjdG9yDQo+ICpjb25uZWN0b3IsDQo+ICAJ ICAgIHRvX2ludGVsX2Nvbm5lY3Rvcihjb25uZWN0b3IpLT5kZXRlY3RfZWRpZCkNCj4gIAkJc3Rh dHVzID0gY29ubmVjdG9yX3N0YXR1c19jb25uZWN0ZWQ7DQo+ICANCj4gLQkvKiBUcnkgdG8gcmVh ZCB0aGUgc291cmNlIG9mIHRoZSBpbnRlcnJ1cHQgKi8NCj4gLQlpZiAoaW50ZWxfZHAtPmRwY2Rb RFBfRFBDRF9SRVZdID49IDB4MTEgJiYNCj4gLQkgICAgaW50ZWxfZHBfZ2V0X3NpbmtfaXJxKGlu dGVsX2RwLCAmc2lua19pcnFfdmVjdG9yKSAmJg0KPiAtCSAgICBzaW5rX2lycV92ZWN0b3IgIT0g MCkgew0KPiAtCQkvKiBDbGVhciBpbnRlcnJ1cHQgc291cmNlICovDQo+IC0JCWRybV9kcF9kcGNk X3dyaXRlYigmaW50ZWxfZHAtPmF1eCwNCj4gLQkJCQkgICBEUF9ERVZJQ0VfU0VSVklDRV9JUlFf VkVDVE9SLA0KPiAtCQkJCSAgIHNpbmtfaXJxX3ZlY3Rvcik7DQo+IC0NCj4gLQkJaWYgKHNpbmtf aXJxX3ZlY3RvciAmIERQX0FVVE9NQVRFRF9URVNUX1JFUVVFU1QpDQo+IC0JCQlpbnRlbF9kcF9o YW5kbGVfdGVzdF9yZXF1ZXN0KGludGVsX2RwKTsNCj4gLQkJaWYgKHNpbmtfaXJxX3ZlY3RvciAm IChEUF9DUF9JUlEgfA0KPiBEUF9TSU5LX1NQRUNJRklDX0lSUSkpDQo+IC0JCQlEUk1fREVCVUdf RFJJVkVSKCJDUCBvciBzaW5rIHNwZWNpZmljIGlycQ0KPiB1bmhhbmRsZWRcbiIpOw0KPiAtCX0N Cj4gKwlpbnRlbF9kcF9jaGVja19zZXJ2aWNlX2lycShpbnRlbF9kcCk7DQo+ICANCj4gIG91dDoN Cj4gIAlpZiAoc3RhdHVzICE9IGNvbm5lY3Rvcl9zdGF0dXNfY29ubmVjdGVkICYmICFpbnRlbF9k cC0+aXNfbXN0KQ0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 Cg==